Skip to content

Conversation

Qelxiros
Copy link
Contributor

@Qelxiros Qelxiros commented Aug 21, 2025

Tracking issue: #112815

@rustbot
Copy link
Collaborator

rustbot commented Aug 21, 2025

r? @petrochenkov

rustbot has assigned @petrochenkov.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 21, 2025
@petrochenkov petrochenkov added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. I-libs-api-nominated Nominated for discussion during a libs-api team meeting. S-waiting-on-team Status: Awaiting decision from the relevant subteam (see the T-<team> label). and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 22, 2025
@Amanieu Amanieu removed the I-libs-api-nominated Nominated for discussion during a libs-api team meeting. label Aug 26, 2025
@dtolnay dtolnay assigned dtolnay and unassigned petrochenkov Aug 26, 2025
@dtolnay
Copy link
Member

dtolnay commented Aug 26, 2025

@rust-lang/libs-api:
@rfcbot fcp merge

These impls enable the following simplification in macro code written without quasi-quoting (#54722):

  let mut stream = TokenStream::new();
- stream.extend([TokenTree::Literal(Literal::i32_suffixed(0))]);
+ stream.extend([Literal::i32_suffixed(0)]);

@rfcbot
Copy link

rfcbot commented Aug 26, 2025

Team member @dtolnay has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-team Status: Awaiting decision from the relevant subteam (see the T-<team> label). T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants