Suppress suggest try wrap when found is unresolved infer #145707
+38
−20
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #145634
In this example,
&Some((1, 2))
is an&_
, and we cannot know the exact type, so I think suppressing this suggestion is the most appropriate choice here. This is similar to / inspired by #145361.I expanded
TypeFlags
to indicate whether a type contains a type withis_ty_var
true.The test with regression(#3680, #5358, #12552) are all ICE, and some are even from many years ago. Therefore, this change in PR should not have a significant impact on them?
Two commits shows the diff of the newly added test.
r? compiler