Skip to content

miri subtree update #145647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 50 commits into from
Aug 21, 2025
Merged

miri subtree update #145647

merged 50 commits into from
Aug 21, 2025

Conversation

RalfJung
Copy link
Member

Subtree update of miri to rust-lang/miri@980da67.

Created using https://github.com/rust-lang/josh-sync.

r? @ghost

Kobzol and others added 30 commits July 29, 2025 10:16
Use GH app for authenticating pull PRs
rely on preinstalled rustup on windows-arm
This updates the rust-version file to adcb3d3.
Pull recent changes from https://github.com/rust-lang/rust via Josh.

Upstream ref: adcb3d3
Filtered ref: 5825740f16c56a1dac078765954330b987825b73

This merge was created using https://github.com/rust-lang/josh-sync.
This updates the rust-version file to 07b7dc9.
Pull recent changes from https://github.com/rust-lang/rust via Josh.

Upstream ref: 07b7dc9
Filtered ref: 3785af8cd0fe0eeb48a0f920ca3fae973cf842d7

This merge was created using https://github.com/rust-lang/josh-sync.
This updates the rust-version file to 4c7749e.
Pull recent changes from https://github.com/rust-lang/rust via Josh.

Upstream ref: 4c7749e
Filtered ref: 9742b5940dcb4aea810f9ce020a92b3f72ed7bb4

This merge was created using https://github.com/rust-lang/josh-sync.
This updates the rust-version file to 1553adf.
Pull recent changes from https://github.com/rust-lang/rust via Josh.

Upstream ref: 1553adf
Filtered ref: e5ee70aa5f36dacdc6df9490e867c45aa4e51c18

This merge was created using https://github.com/rust-lang/josh-sync.
This updates the rust-version file to 3507a74.
Pull recent changes from https://github.com/rust-lang/rust via Josh.

Upstream ref: 3507a74
Filtered ref: 67f9124a1e199effc310447c1c1f9548093bd8f9

This merge was created using https://github.com/rust-lang/josh-sync.
The Miri Cronjob Bot and others added 7 commits August 20, 2025 04:54
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 20, 2025
@rustbot
Copy link
Collaborator

rustbot commented Aug 20, 2025

The Miri subtree was changed

cc @rust-lang/miri

@RalfJung
Copy link
Member Author

@bors r+ p=1

@bors
Copy link
Collaborator

bors commented Aug 20, 2025

📌 Commit 4676552 has been approved by RalfJung

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 20, 2025
Zalathar added a commit to Zalathar/rust that referenced this pull request Aug 20, 2025
bors added a commit that referenced this pull request Aug 20, 2025
Rollup of 5 pull requests

Successful merges:

 - #144915 (Defer tail call ret ty equality to check_tail_calls)
 - #145256 (Add new `--test-codegen-backend` bootstrap option)
 - #145415 (std_detect: RISC-V: implement implication to "C")
 - #145647 (miri subtree update)
 - #145650 (Fix JS search scripts path)

r? `@ghost`
`@rustbot` modify labels: rollup
@Kobzol
Copy link
Member

Kobzol commented Aug 20, 2025

@bors p=0

Deprioritizing, because it is in #145658, and if that gets merged, homu could start testing this immediately.

bors added a commit that referenced this pull request Aug 20, 2025
Rollup of 12 pull requests

Successful merges:

 - #143383 (stabilize `const_array_each_ref`)
 - #144443 (Make target pointer width in target json an integer)
 - #144758 ([Doc] Add links to the various collections)
 - #144915 (Defer tail call ret ty equality to check_tail_calls)
 - #145256 (Add new `--test-codegen-backend` bootstrap option)
 - #145415 (std_detect: RISC-V: implement implication to "C")
 - #145573 (Add an experimental unsafe(force_target_feature) attribute.)
 - #145642 (Do not use effective_visibilities query for Adt types of a local trait while proving a where-clause)
 - #145650 (Fix JS search scripts path)
 - #145654 (Download CI GCC into the correct directory)
 - #145662 (Enforce correct number of arguments for `"x86-interrupt"` functions)
 - #145674 (Enable triagebot `[review-changes-since]` feature)

Failed merges:

 - #145647 (miri subtree update)

r? `@ghost`
`@rustbot` modify labels: rollup
@Kobzol
Copy link
Member

Kobzol commented Aug 20, 2025

That rollup failed, but since this PR seems to have a merge conflict with #145680, I won't reprioritize it.

@RalfJung
Copy link
Member Author

Resolving conflicts in sync PRs is a lot more work than in a normal PR so would still be nice to get this in first.
@bors p=1

@bors
Copy link
Collaborator

bors commented Aug 21, 2025

⌛ Testing commit 4676552 with merge 6ba0ce4...

@bors
Copy link
Collaborator

bors commented Aug 21, 2025

☀️ Test successful - checks-actions
Approved by: RalfJung
Pushing 6ba0ce4 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 21, 2025
@bors bors merged commit 6ba0ce4 into rust-lang:master Aug 21, 2025
11 checks passed
@rustbot rustbot added this to the 1.91.0 milestone Aug 21, 2025
Copy link
Contributor

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 57e620e (parent) -> 6ba0ce4 (this PR)

Test differences

Show 2 test diffs

2 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 6ba0ce40941eee1ca02e9ba49c791ada5158747a --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. pr-check-1: 1731.8s -> 1352.2s (-21.9%)
  2. aarch64-gnu-llvm-19-2: 2541.0s -> 2144.5s (-15.6%)
  3. i686-gnu-2: 6305.7s -> 5437.2s (-13.8%)
  4. x86_64-gnu-llvm-19: 2858.2s -> 2504.5s (-12.4%)
  5. aarch64-msvc-1: 6744.1s -> 7547.4s (11.9%)
  6. dist-aarch64-apple: 6161.0s -> 5447.9s (-11.6%)
  7. i686-gnu-nopt-1: 8319.8s -> 7471.2s (-10.2%)
  8. x86_64-gnu-tools: 3846.2s -> 3471.2s (-9.7%)
  9. dist-ohos-armv7: 4047.0s -> 4436.6s (9.6%)
  10. dist-apple-various: 5073.9s -> 5552.3s (9.4%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (6ba0ce4): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results (secondary -2.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-2.0% [-2.0%, -2.0%] 1
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 469.9s -> 471.281s (0.29%)
Artifact size: 378.22 MiB -> 378.27 MiB (0.01%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.