Skip to content

Refactor attribute parsing to improve ergonomics and some diagnostics #145507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 22, 2025
Merged

Refactor attribute parsing to improve ergonomics and some diagnostics #145507

merged 4 commits into from
Aug 22, 2025
+884 −918

Conversation

jdonszelmann
Copy link
Contributor

No description provided.

@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 16, 2025
@jdonszelmann jdonszelmann marked this pull request as ready for review August 16, 2025 17:51
@rustbot
Copy link
Collaborator

rustbot commented Aug 16, 2025

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 16, 2025
@rustbot
Copy link
Collaborator

rustbot commented Aug 16, 2025

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

@rust-lang rust-lang deleted a comment from rustbot Aug 16, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@jdonszelmann jdonszelmann force-pushed the refactor-attr-parsing branch from 920a37c to e5c14c3 Compare August 18, 2025 10:40
@jdonszelmann
Copy link
Contributor Author

@rustbot review

@davidtwco
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Aug 18, 2025

📌 Commit e5c14c3 has been approved by davidtwco

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 18, 2025
@jieyouxu jieyouxu mentioned this pull request Aug 19, 2025
Closed
@jieyouxu
Copy link
Member

Merge conflict.
@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 19, 2025
@jdonszelmann jdonszelmann force-pushed the refactor-attr-parsing branch from e5c14c3 to a59705e Compare August 19, 2025 11:47
@rustbot

This comment has been minimized.

Sign in to view
@jdonszelmann
Copy link
Contributor Author

@rustbot review

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 19, 2025
@jdonszelmann jdonszelmann force-pushed the refactor-attr-parsing branch from a59705e to 0d2b46c Compare August 19, 2025 11:52
@jdonszelmann jdonszelmann force-pushed the refactor-attr-parsing branch from 0d2b46c to 4791dc5 Compare August 19, 2025 11:57
@jdonszelmann
Copy link
Contributor Author

the rangediff shows a test output changed related to attrs on foreign types which got introduced very recently, hence the conflict. That's why I pushed again to fix that, that was unintentional but the current version is good in that regard.

@jdonszelmann
Copy link
Contributor Author

jdonszelmann commented Aug 19, 2025 •
edited
Loading

i.e. the rangediff shows this bit as removed but I added it back in afterwards:
image

@bors
Copy link
Collaborator

bors commented Aug 20, 2025

☔ The latest upstream changes (presumably #145600) made this pull request unmergeable. Please resolve the merge conflicts.

@jdonszelmann jdonszelmann force-pushed the refactor-attr-parsing branch from 4791dc5 to e1188c4 Compare August 20, 2025 13:39
@rustbot

This comment has been minimized.

Sign in to view
@davidtwco
Copy link
Member

@bors delegate+

@bors
Copy link
Collaborator

bors commented Aug 20, 2025

✌️ @jdonszelmann, you can now approve this pull request!

If @davidtwco told you to "r=me" after making some further change, please make that change, then do @bors r=@davidtwco

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@jdonszelmann jdonszelmann force-pushed the refactor-attr-parsing branch 2 times, most recently from 1152a2c to 49d030b Compare August 20, 2025 14:28
@jdonszelmann
Copy link
Contributor Author

@bors r=davidtwco

@bors
Copy link
Collaborator

bors commented Aug 20, 2025

📌 Commit 49d030b has been approved by davidtwco

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 20, 2025
@jdonszelmann jdonszelmann force-pushed the refactor-attr-parsing branch from 49d030b to becefdd Compare August 21, 2025 11:17
@rustbot
Copy link
Collaborator

rustbot commented Aug 21, 2025

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@jdonszelmann
Copy link
Contributor Author

@bors r=davidtwco

@bors
Copy link
Collaborator

bors commented Aug 21, 2025

📌 Commit becefdd has been approved by davidtwco

It is now in the queue for this repository.

@jhpratt jhpratt mentioned this pull request Aug 21, 2025
Merged
bors added a commit that referenced this pull request Aug 21, 2025
@bors
Auto merge of #145728 - jhpratt:rollup-nwbw8de, r=jhpratt
8e3710e 
Rollup of 16 pull requests

Successful merges:

 - #137494 (libstd: init(): dup() subsequent /dev/nulls instead of opening them again)
 - #144541 (c-variadic: multiple ABIs in the same program for arm)
 - #144613 (aarch64-nintendo-switch-freestanding - Enable CPU features that are always available in a live system (crypto instructions, plus explicit NEON).)
 - #144780 (Add a method to dump MIR in the middle of MIR building)
 - #145137 (Consolidate panicking functions in `slice/index.rs`)
 - #145507 (Refactor attribute parsing to improve ergonomics and some diagnostics)
 - #145604 (Gate static closures behind a parser feature)
 - #145648 (Add two tidy dependency checks)
 - #145661 (update some s390x codegen tests)
 - #145672 (Instantiate higher-ranked binder with erased when checking `IntoIterator` predicate for query instability)
 - #145689 (Migrate `panic_unwind` to use `cfg_select!`)
 - #145700 (Handle `ReEarlyParam` in `type_name`.)
 - #145703 (Remove MIPS targets from CI LLVM platforms)
 - #145704 (ci: don't cleanup windows disk)
 - #145705 (remove an `as` cast in prefetch codegen)
 - #145712 (Update outdated link in bound region comments)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 54da040 into rust-lang:master Aug 22, 2025
10 checks passed
@rustbot rustbot added this to the 1.91.0 milestone Aug 22, 2025
rust-timer added a commit that referenced this pull request Aug 22, 2025
@rust-timer
Unrolled build for #145507
f0e241d 
Rollup merge of #145507 - jdonszelmann:refactor-attr-parsing, r=davidtwco

Refactor attribute parsing to improve ergonomics and some diagnostics
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Aug 22, 2025
@bors
Auto merge of #145728 - jhpratt:rollup-nwbw8de, r=jhpratt
3629e47 
Rollup of 16 pull requests

Successful merges:

 - rust-lang/rust#137494 (libstd: init(): dup() subsequent /dev/nulls instead of opening them again)
 - rust-lang/rust#144541 (c-variadic: multiple ABIs in the same program for arm)
 - rust-lang/rust#144613 (aarch64-nintendo-switch-freestanding - Enable CPU features that are always available in a live system (crypto instructions, plus explicit NEON).)
 - rust-lang/rust#144780 (Add a method to dump MIR in the middle of MIR building)
 - rust-lang/rust#145137 (Consolidate panicking functions in `slice/index.rs`)
 - rust-lang/rust#145507 (Refactor attribute parsing to improve ergonomics and some diagnostics)
 - rust-lang/rust#145604 (Gate static closures behind a parser feature)
 - rust-lang/rust#145648 (Add two tidy dependency checks)
 - rust-lang/rust#145661 (update some s390x codegen tests)
 - rust-lang/rust#145672 (Instantiate higher-ranked binder with erased when checking `IntoIterator` predicate for query instability)
 - rust-lang/rust#145689 (Migrate `panic_unwind` to use `cfg_select!`)
 - rust-lang/rust#145700 (Handle `ReEarlyParam` in `type_name`.)
 - rust-lang/rust#145703 (Remove MIPS targets from CI LLVM platforms)
 - rust-lang/rust#145704 (ci: don't cleanup windows disk)
 - rust-lang/rust#145705 (remove an `as` cast in prefetch codegen)
 - rust-lang/rust#145712 (Update outdated link in bound region comments)

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidtwco davidtwco davidtwco approved these changes

Assignees

@davidtwco davidtwco

Labels
A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.91.0
Development

Successfully merging this pull request may close these issues.
7 participants
@jdonszelmann @rustbot @rust-log-analyzer @davidtwco @bors @jieyouxu @oli-obk