-
Notifications
You must be signed in to change notification settings - Fork 13.7k
Add some conversion trait impls #145504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Jules-Bertholet
wants to merge
3
commits into
rust-lang:master
Choose a base branch
from
Jules-Bertholet:more_conversion_trait_impls
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add some conversion trait impls #145504
Jules-Bertholet
wants to merge
3
commits into
rust-lang:master
from
Jules-Bertholet:more_conversion_trait_impls
+96
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot has assigned @Mark-Simulacrum. Use |
7 tasks
This comment has been minimized.
This comment has been minimized.
7ef29d9
to
3a96604
Compare
This comment has been minimized.
This comment has been minimized.
3a96604
to
676ff1f
Compare
- `impl AsRef<str> for AsciiChar` (unstable) - `impl<T, const N: usize> From<[MaybeUninit<T>; N]> for MaybeUninit<[T; N]>` - `impl<T, const N: usize> AsRef<[MaybeUninit<T>; N]> for MaybeUninit<[T; N]>` - `impl<T, const N: usize> AsRef<[MaybeUninit<T>]> for MaybeUninit<[T; N]>` - `impl<T, const N: usize> AsMut<[MaybeUninit<T>; N]> for MaybeUninit<[T; N]>` - `impl<T, const N: usize> AsMut<[MaybeUninit<T>]> for MaybeUninit<[T; N]>` - `impl<T, const N: usize> From<MaybeUninit<[T; N]>> for [MaybeUninit<T>; N]` - `impl<T, const N: usize> AsRef<[Cell<T>; N]> for Cell<[T; N]>` - `impl<T, const N: usize> AsRef<[Cell<T>]> for Cell<[T; N]>` - `impl<T> AsRef<[Cell<T>]> for Cell<[T]>`
676ff1f
to
bd960c9
Compare
r? libs-api |
clarfonthey
reviewed
Aug 17, 2025
clarfonthey
reviewed
Aug 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
needs-fcp
This change is insta-stable, or significant enough to need a team FCP to proceed.
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-libs-api
Relevant to the library API team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
impl AsRef<str> for AsciiChar
(unstable, cc Tracking Issue forascii::Char
(ACP 179) #110998)impl AsMut<str> for AsciiChar
(unstable, cc Tracking Issue forascii::Char
(ACP 179) #110998)impl<T, const N: usize> From<[MaybeUninit<T>; N]> for MaybeUninit<[T; N]>
(cc Tracking Issue for MaybeUninit methods for arrays #96097)impl<T, const N: usize> AsRef<[MaybeUninit<T>; N]> for MaybeUninit<[T; N]>
(cc Tracking Issue for MaybeUninit methods for arrays #96097)impl<T, const N: usize> AsRef<[MaybeUninit<T>]> for MaybeUninit<[T; N]>
(cc Tracking Issue for MaybeUninit methods for arrays #96097)impl<T, const N: usize> AsMut<[MaybeUninit<T>; N]> for MaybeUninit<[T; N]>
(cc Tracking Issue for MaybeUninit methods for arrays #96097)impl<T, const N: usize> AsMut<[MaybeUninit<T>]> for MaybeUninit<[T; N]>
(cc Tracking Issue for MaybeUninit methods for arrays #96097)impl<T, const N: usize> From<MaybeUninit<[T; N]>> for [MaybeUninit<T>; N]
(cc Tracking Issue for MaybeUninit methods for arrays #96097)impl<T, const N: usize> AsRef<[Cell<T>; N]> for Cell<[T; N]>
(equivalent ofas_array_of_cells
, cc Tracking Issue for Cell::as_array_of_cells #88248)impl<T, const N: usize> AsRef<[Cell<T>]> for Cell<[T; N]>
impl<T> AsRef<[Cell<T>]> for Cell<[T]>
(equivalent ofas_slice_of_cells
)@rustbot label T-libs-api needs-fcp -T-libs
I’ve tried to only add impls that are unlikely to cause single-applicable-impl inference breakage.