Skip to content

Rust documentation, use rustc-dev-guide :3 #145385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Rust documentation, use rustc-dev-guide :3 #145385

wants to merge 2 commits into from

Conversation

lcnr
Copy link
Contributor

@lcnr lcnr commented Aug 14, 2025

The rustc Guide is not something I would immediately recognize as the rustc-dev-guide. Feels better to use the commonly used name for it here.

@rustbot
Copy link
Collaborator

rustbot commented Aug 14, 2025

r? @ehuss

rustbot has assigned @ehuss.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 14, 2025
@lcnr lcnr changed the title Rust documentation, it's called rustc-dev-guide :3 Rust documentation, use rustc-dev-guide :3 Aug 14, 2025
@ehuss
Copy link
Contributor

ehuss commented Aug 14, 2025

Looks good to me. However, I'll defer to @BoxyUwU how you want to refer to it.

r? @BoxyUwU

@rustbot rustbot assigned BoxyUwU and unassigned ehuss Aug 14, 2025
BoxyUwU
BoxyUwU reviewed Aug 14, 2025
View reviewed changes
@BoxyUwU BoxyUwU added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 14, 2025
@jieyouxu jieyouxu closed this Aug 14, 2025
@jieyouxu jieyouxu deleted the lcnr/rustc-dev-guide-3 branch August 14, 2025 15:16
@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Aug 14, 2025
@lcnr lcnr mentioned this pull request Aug 14, 2025
Merged
Kobzol added a commit to Kobzol/rust that referenced this pull request Aug 14, 2025
@Kobzol
Rollup merge of rust-lang#145397 - lcnr:lcnr/rustc-dev-guide-3, r=Box…
05374e7 
…yUwU

Rust documentation, use `rustc-dev-guide` :3

reviving rust-lang#145385 but on my own fork this time

r? `@BoxyUwU`
Kobzol added a commit to Kobzol/rust that referenced this pull request Aug 14, 2025
@Kobzol
Rollup merge of rust-lang#145397 - lcnr:lcnr/rustc-dev-guide-3, r=Box…
1eda78f 
…yUwU

Rust documentation, use `rustc-dev-guide` :3

reviving rust-lang#145385 but on my own fork this time

r? ``@BoxyUwU``
rust-timer added a commit that referenced this pull request Aug 15, 2025
@rust-timer
Unrolled build for #145397
d29a677 
Rollup merge of #145397 - lcnr:lcnr/rustc-dev-guide-3, r=BoxyUwU

Rust documentation, use `rustc-dev-guide` :3

reviving #145385 but on my own fork this time

r? ``@BoxyUwU``
github-actions bot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Aug 18, 2025
@Kobzol
Rollup merge of #145397 - lcnr:lcnr/rustc-dev-guide-3, r=BoxyUwU
36d0f02 
Rust documentation, use `rustc-dev-guide` :3

reviving rust-lang/rust#145385 but on my own fork this time

r? ``@BoxyUwU``
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BoxyUwU BoxyUwU BoxyUwU left review comments

Assignees

@BoxyUwU BoxyUwU

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lcnr @rustbot @ehuss @BoxyUwU @jieyouxu