Skip to content

Implement feature int_lowest_highest_one for integer and NonZero types #145381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 20, 2025
Merged

Implement feature int_lowest_highest_one for integer and NonZero types #145381

merged 1 commit into from
Aug 20, 2025
+321 −0

Conversation

Gnurou
Copy link
Contributor

@Gnurou Gnurou commented Aug 14, 2025 •
edited by rustbot
Loading

Tracking issue: #145203

Implement the accepted ACP #145203 for methods that find the index of the least significant (lowest) and most significant (highest) set bit in an integer for signed, unsigned, and NonZero types.

Also add unit tests for all these types.

@rustbot
Copy link
Collaborator

rustbot commented Aug 14, 2025

r? @jhpratt

rustbot has assigned @jhpratt.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Aug 14, 2025
@rustbot

This comment has been minimized.

Sign in to view
@Gnurou Gnurou force-pushed the int_lowest_highest_one branch from ed51b06 to 520868b Compare August 14, 2025 05:54
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Gnurou
Copy link
Contributor Author

Gnurou commented Aug 14, 2025

Urk, I overlook something with the NonZero tests... Please hold on a bit until I fix the failures. 🙇

@xizheyin
Copy link
Member

You can use @rustbot author to set it to incomplete status. When ready, you can use @rustbot ready to set it to pending review.

@Gnurou
Copy link
Contributor Author

Gnurou commented Aug 14, 2025

@rustbot author

Thanks @xizheyin !

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 14, 2025
@rustbot
Copy link
Collaborator

rustbot commented Aug 14, 2025

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@Gnurou Gnurou force-pushed the int_lowest_highest_one branch from 520868b to c140bc1 Compare August 14, 2025 13:49
jhpratt
jhpratt reviewed Aug 14, 2025
View reviewed changes
@Gnurou
Implement feature int_lowest_highest_one for integer and NonZero types
73d3d28 
Implement the accepted ACP for methods that find the index of the least
significant (lowest) and most significant (highest) set bit in an
integer for signed, unsigned, and NonZero types.

Also add unit tests for all these types.
@Gnurou Gnurou force-pushed the int_lowest_highest_one branch from c140bc1 to 73d3d28 Compare August 18, 2025 10:02
@Gnurou
Copy link
Contributor Author

Gnurou commented Aug 18, 2025

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 18, 2025
@jhpratt
Copy link
Member

jhpratt commented Aug 19, 2025

Thanks!

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Aug 19, 2025

📌 Commit 73d3d28 has been approved by jhpratt

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 19, 2025
jhpratt added a commit to jhpratt/rust that referenced this pull request Aug 19, 2025
@jhpratt
Rollup merge of rust-lang#145381 - Gnurou:int_lowest_highest_one, r=j…
2370fa6 
…hpratt

Implement feature `int_lowest_highest_one` for integer and NonZero types

Tracking issue: rust-lang#145203

Implement the accepted ACP rust-lang#145203 for methods that find the index of the least significant (lowest) and most significant (highest) set bit in an integer for signed, unsigned, and NonZero types.

Also add unit tests for all these types.
@jhpratt jhpratt mentioned this pull request Aug 19, 2025
Closed
jhpratt added a commit to jhpratt/rust that referenced this pull request Aug 19, 2025
@jhpratt
Rollup merge of rust-lang#145381 - Gnurou:int_lowest_highest_one, r=j…
5b15bfd 
…hpratt

Implement feature `int_lowest_highest_one` for integer and NonZero types

Tracking issue: rust-lang#145203

Implement the accepted ACP rust-lang#145203 for methods that find the index of the least significant (lowest) and most significant (highest) set bit in an integer for signed, unsigned, and NonZero types.

Also add unit tests for all these types.
This was referenced Aug 19, 2025
Closed
Merged
bors added a commit that referenced this pull request Aug 20, 2025
@bors
Auto merge of #145644 - jhpratt:rollup-ypo3zcd, r=jhpratt
22a86f8 
Rollup of 13 pull requests

Successful merges:

 - #139357 (Fix parameter order for `_by()` variants of `min` / `max`/ `minmax` in `std::cmp`)
 - #140314 (Rustdoc: typecheck scrape-examples.js)
 - #140794 (mention lint group in default level lint note)
 - #145006 (Clarify EOF handling for `BufRead::skip_until`)
 - #145252 (Demote x86_64-apple-darwin to Tier 2 with host tools)
 - #145359 (Fix bug where `rustdoc-js` tester would not pick the right `search.js` file if there is more than one)
 - #145381 (Implement feature `int_lowest_highest_one` for integer and NonZero types)
 - #145417 (std_detect: RISC-V platform guide documentation)
 - #145531 (Add runtime detection for APX-F and AVX10)
 - #145619 (`std_detect`: Use `rustc-std-workspace-*` to pull in `compiler-builtins`)
 - #145622 (Remove the std workspace patch for `compiler-builtins`)
 - #145623 (Pretty print the name of an future from calling async closure)
 - #145626 (add a fallback implementation for the `prefetch_*` intrinsics )

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 5a0c938 into rust-lang:master Aug 20, 2025
10 checks passed
@rustbot rustbot added this to the 1.91.0 milestone Aug 20, 2025
rust-timer added a commit that referenced this pull request Aug 20, 2025
@rust-timer
Unrolled build for #145381
8743ccf 
Rollup merge of #145381 - Gnurou:int_lowest_highest_one, r=jhpratt

Implement feature `int_lowest_highest_one` for integer and NonZero types

Tracking issue: #145203

Implement the accepted ACP #145203 for methods that find the index of the least significant (lowest) and most significant (highest) set bit in an integer for signed, unsigned, and NonZero types.

Also add unit tests for all these types.
@Gnurou Gnurou mentioned this pull request Aug 20, 2025
Open
5 tasks
@Gnurou Gnurou deleted the int_lowest_highest_one branch August 20, 2025 13:02
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Aug 21, 2025
@bors
Auto merge of #145644 - jhpratt:rollup-ypo3zcd, r=jhpratt
8162bc6 
Rollup of 13 pull requests

Successful merges:

 - rust-lang/rust#139357 (Fix parameter order for `_by()` variants of `min` / `max`/ `minmax` in `std::cmp`)
 - rust-lang/rust#140314 (Rustdoc: typecheck scrape-examples.js)
 - rust-lang/rust#140794 (mention lint group in default level lint note)
 - rust-lang/rust#145006 (Clarify EOF handling for `BufRead::skip_until`)
 - rust-lang/rust#145252 (Demote x86_64-apple-darwin to Tier 2 with host tools)
 - rust-lang/rust#145359 (Fix bug where `rustdoc-js` tester would not pick the right `search.js` file if there is more than one)
 - rust-lang/rust#145381 (Implement feature `int_lowest_highest_one` for integer and NonZero types)
 - rust-lang/rust#145417 (std_detect: RISC-V platform guide documentation)
 - rust-lang/rust#145531 (Add runtime detection for APX-F and AVX10)
 - rust-lang/rust#145619 (`std_detect`: Use `rustc-std-workspace-*` to pull in `compiler-builtins`)
 - rust-lang/rust#145622 (Remove the std workspace patch for `compiler-builtins`)
 - rust-lang/rust#145623 (Pretty print the name of an future from calling async closure)
 - rust-lang/rust#145626 (add a fallback implementation for the `prefetch_*` intrinsics )

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhpratt jhpratt jhpratt left review comments

Assignees

@jhpratt jhpratt

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.91.0
Development

Successfully merging this pull request may close these issues.
6 participants
@Gnurou @rustbot @rust-log-analyzer @xizheyin @jhpratt @bors