fix(debuginfo): handle false positives in overflow check #145297

adwinwhite · 2025-08-12T09:30:57Z

Duplicate wrappers and normal recursive types can lead to false positives.

struct Recursive {
	a: Box<Box<Recursive>>,
}

The ADT stack can be:

Box<Recursive>
Recursive
Box<Box<Recursive>> (Box now detected as expanding)

We can filter them out by tracing the generic arg back through the stack, as true expanding recursive types must have their expanding arg used as generic arg throughout.

r? @wesleywiser

wesleywiser · 2025-08-20T20:21:19Z

Thanks @adwinwhite!

@bors r+

bors · 2025-08-20T20:21:54Z

📌 Commit e13e1e4 has been approved by wesleywiser

It is now in the queue for this repository.

…wesleywiser fix(debuginfo): handle false positives in overflow check Fixes rust-lang#144636. Duplicate wrappers and normal recursive types can lead to false positives. ```rust struct Recursive { a: Box<Box<Recursive>>, } ``` The ADT stack can be: - `Box<Recursive>` - `Recursive` - `Box<Box<Recursive>>` (`Box` now detected as expanding) We can filter them out by tracing the generic arg back through the stack, as true expanding recursive types must have their expanding arg used as generic arg throughout. r? `@wesleywiser`

Rollup of 14 pull requests Successful merges: - #143383 (stabilize `const_array_each_ref`) - #144443 (Make target pointer width in target json an integer) - #144758 ([Doc] Add links to the various collections) - #144915 (Defer tail call ret ty equality to check_tail_calls) - #145137 (Consolidate panicking functions in `slice/index.rs`) - #145256 (Add new `--test-codegen-backend` bootstrap option) - #145297 (fix(debuginfo): handle false positives in overflow check) - #145415 (std_detect: RISC-V: implement implication to "C") - #145642 (Do not use effective_visibilities query for Adt types of a local trait while proving a where-clause) - #145650 (Fix JS search scripts path) - #145654 (Download CI GCC into the correct directory) - #145662 (Enforce correct number of arguments for `"x86-interrupt"` functions) - #145674 (Enable triagebot `[review-changes-since]` feature) - #145678 (Fix typo in docstring) r? `@ghost` `@rustbot` modify labels: rollup

…wesleywiser fix(debuginfo): handle false positives in overflow check Fixes rust-lang#144636. Duplicate wrappers and normal recursive types can lead to false positives. ```rust struct Recursive { a: Box<Box<Recursive>>, } ``` The ADT stack can be: - `Box<Recursive>` - `Recursive` - `Box<Box<Recursive>>` (`Box` now detected as expanding) We can filter them out by tracing the generic arg back through the stack, as true expanding recursive types must have their expanding arg used as generic arg throughout. r? ``@wesleywiser``

Rollup of 15 pull requests Successful merges: - #143383 (stabilize `const_array_each_ref`) - #144758 ([Doc] Add links to the various collections) - #144915 (Defer tail call ret ty equality to check_tail_calls) - #145137 (Consolidate panicking functions in `slice/index.rs`) - #145256 (Add new `--test-codegen-backend` bootstrap option) - #145297 (fix(debuginfo): handle false positives in overflow check) - #145415 (std_detect: RISC-V: implement implication to "C") - #145590 (Prevent impossible combinations in `ast::ModKind`.) - #145621 (Fix some doc typos) - #145642 (Do not use effective_visibilities query for Adt types of a local trait while proving a where-clause) - #145650 (Fix JS search scripts path) - #145654 (Download CI GCC into the correct directory) - #145662 (Enforce correct number of arguments for `"x86-interrupt"` functions) - #145674 (Enable triagebot `[review-changes-since]` feature) - #145678 (Fix typo in docstring) r? `@ghost` `@rustbot` modify labels: rollup

…wesleywiser fix(debuginfo): handle false positives in overflow check Fixes rust-lang#144636. Duplicate wrappers and normal recursive types can lead to false positives. ```rust struct Recursive { a: Box<Box<Recursive>>, } ``` The ADT stack can be: - `Box<Recursive>` - `Recursive` - `Box<Box<Recursive>>` (`Box` now detected as expanding) We can filter them out by tracing the generic arg back through the stack, as true expanding recursive types must have their expanding arg used as generic arg throughout. r? ```@wesleywiser```

Rollup of 19 pull requests Successful merges: - #143383 (stabilize `const_array_each_ref`) - #144758 ([Doc] Add links to the various collections) - #144915 (Defer tail call ret ty equality to check_tail_calls) - #145256 (Add new `--test-codegen-backend` bootstrap option) - #145297 (fix(debuginfo): handle false positives in overflow check) - #145390 (Shorten some dependency chains in the compiler) - #145415 (std_detect: RISC-V: implement implication to "C") - #145525 (stdlib: Replace typedef -> type alias in doc comment) - #145590 (Prevent impossible combinations in `ast::ModKind`.) - #145593 (UnsafePinned::raw_get: sync signature with get) - #145621 (Fix some doc typos) - #145627 (Unconditionally-const supertraits are considered not dyn compatible) - #145642 (Do not use effective_visibilities query for Adt types of a local trait while proving a where-clause) - #145650 (Fix JS search scripts path) - #145654 (Download CI GCC into the correct directory) - #145662 (Enforce correct number of arguments for `"x86-interrupt"` functions) - #145673 (Add flock support for cygwin) - #145674 (Enable triagebot `[review-changes-since]` feature) - #145678 (Fix typo in docstring) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #145297 - adwinwhite:recursive-debuginfo, r=wesleywiser fix(debuginfo): handle false positives in overflow check Fixes #144636. Duplicate wrappers and normal recursive types can lead to false positives. ```rust struct Recursive { a: Box<Box<Recursive>>, } ``` The ADT stack can be: - `Box<Recursive>` - `Recursive` - `Box<Box<Recursive>>` (`Box` now detected as expanding) We can filter them out by tracing the generic arg back through the stack, as true expanding recursive types must have their expanding arg used as generic arg throughout. r? ````@wesleywiser````

apiraino · 2025-08-21T10:28:05Z

We might evaluate a backport during t-compiler triage meeting

@rustbot label +beta-nominated

fix(debuginfo): handle false positives in overflow check

e13e1e4

rustbot assigned wesleywiser Aug 12, 2025

wesleywiser approved these changes Aug 20, 2025

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 20, 2025

jhpratt mentioned this pull request Aug 20, 2025

Rollup of 14 pull requests #145681

Closed

jhpratt mentioned this pull request Aug 21, 2025

Rollup of 15 pull requests #145691

Closed

This was referenced Aug 21, 2025

Rollup of 20 pull requests #145697

Closed

Rollup of 19 pull requests #145701

Merged

bors merged commit 537d5f4 into rust-lang:master Aug 21, 2025
10 checks passed

rustbot added this to the 1.91.0 milestone Aug 21, 2025

rustbot added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Aug 21, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(debuginfo): handle false positives in overflow check #145297

fix(debuginfo): handle false positives in overflow check #145297

adwinwhite commented Aug 12, 2025 •

edited by rustbot

Loading

Uh oh!

wesleywiser commented Aug 20, 2025

Uh oh!

bors commented Aug 20, 2025

Uh oh!

Uh oh!

apiraino commented Aug 21, 2025

Uh oh!

Uh oh!

fix(debuginfo): handle false positives in overflow check #145297

fix(debuginfo): handle false positives in overflow check #145297

Conversation

adwinwhite commented Aug 12, 2025 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wesleywiser commented Aug 20, 2025

Uh oh!

bors commented Aug 20, 2025

Uh oh!

Uh oh!

apiraino commented Aug 21, 2025

Uh oh!

Uh oh!

adwinwhite commented Aug 12, 2025 •

edited by rustbot

Loading