remove `P` #145146

fee1-dead · 2025-08-09T05:57:25Z

Previous work: #141603
MCP: rust-lang/compiler-team#878

rustbot · 2025-08-09T05:57:29Z

rustbot has assigned @lcnr.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot · 2025-08-09T05:57:32Z

Some changes occurred in src/tools/rustfmt

cc @rust-lang/rustfmt

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

Some changes occurred in compiler/rustc_ast/src/expand/autodiff_attrs.rs

cc @ZuseZ4

rust-analyzer is developed in its own repository. If possible, consider making this change to rust-lang/rust-analyzer instead.

cc @rust-lang/rust-analyzer

Some changes occurred in compiler/rustc_builtin_macros/src/autodiff.rs

cc @ZuseZ4

nnethercote · 2025-08-09T06:23:53Z

src/tools/clippy/clippy_lints/src/unnested_or_patterns.rs

 use rustc_ast::{self as ast, DUMMY_NODE_ID, Mutability, Pat, PatKind};
 use rustc_ast_pretty::pprust;
 use rustc_errors::Applicability;
 use rustc_lint::{EarlyContext, EarlyLintPass};
 use rustc_session::impl_lint_pass;
 use rustc_span::DUMMY_SP;
+use std::boxed::Box;


Why is this necessary?

to shadow use rustc_ast::PatKind::*; above which contains a variant named Box

Ok, maybe add a comment?

nnethercote · 2025-08-09T06:25:41Z

Did you grep for P< afterwards? I see some comments got changed, so hopefully yes. r=me once the tests are green.

@bors p=1 because conflict-prone

fee1-dead · 2025-08-09T06:31:35Z

Did you grep for P< afterwards? I see some comments got changed, so hopefully yes

Yes I did, if I searched for it correctly, there's only one mention of it left and its the release notes of Rust 1.15.0.

fee1-dead · 2025-08-09T09:20:34Z

@bors r=nnethercote

bors · 2025-08-09T09:20:37Z

📌 Commit ad1113f has been approved by nnethercote

It is now in the queue for this repository.

…y, r=nnethercote remove `P` Previous work: rust-lang#141603 MCP: rust-lang/compiler-team#878 cc ``@nnethercote``

Rollup of 8 pull requests Successful merges: - #144739 (Use new public libtest `ERROR_EXIT_CODE` constant in rustdoc) - #145089 (Improve error output when a command fails in bootstrap) - #145112 ([win][arm64ec] Partial fix for raw-dylib-link-ordinal on Arm64EC) - #145135 (Stabilize `duration_constructors_lite` feature) - #145146 (remove `P`) - #145152 (Use `to_ascii_lowercase` to avoid heap alloc in `detect_confuse_type`) - #145156 (Override custom Cargo `build-dir` in bootstrap) - #145160 (Change days-threshold to 28 in [behind-upstream]) Failed merges: - #145145 (some `derive_more` refactors) r? `@ghost` `@rustbot` modify labels: rollup

bors · 2025-08-09T23:27:58Z

⌛ Testing commit ad1113f with merge 41ede7b...

bors · 2025-08-10T02:31:34Z

☀️ Test successful - checks-actions
Approved by: nnethercote
Pushing 41ede7b to master...

github-actions · 2025-08-10T02:34:45Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing ca77504 (parent) -> 41ede7b (this PR)

Test differences

Show 60 test diffs

60 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 41ede7bd9bfbc9dc1e46c5c7de3b26524e5c61f0 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

x86_64-apple-2: 2982.4s -> 5102.1s (71.1%)
dist-aarch64-linux: 5618.8s -> 8047.9s (43.2%)
pr-check-2: 2219.0s -> 2734.4s (23.2%)
aarch64-apple: 5367.2s -> 6505.5s (21.2%)
pr-check-1: 1477.6s -> 1764.3s (19.4%)
x86_64-gnu-llvm-19: 2472.7s -> 2866.7s (15.9%)
aarch64-gnu-llvm-19-2: 2298.2s -> 2650.6s (15.3%)
dist-powerpc64le-linux-musl: 6138.4s -> 5267.8s (-14.2%)
dist-apple-various: 4396.6s -> 3785.8s (-13.9%)
armhf-gnu: 4917.0s -> 5493.3s (11.7%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2025-08-10T03:40:42Z

Finished benchmarking commit (41ede7b): comparison URL.

Overall result: ❌✅ regressions and improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.1%	[0.1%, 0.2%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.0%	[-0.1%, -0.0%]	3
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (secondary 3.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.8%	[1.6%, 4.6%]	4
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Cycles

Results (secondary -1.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.9%	[2.4%, 3.2%]	4
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-5.2%	[-7.4%, -1.3%]	4
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 463.988s -> 463.257s (-0.16%)
Artifact size: 377.65 MiB -> 377.39 MiB (-0.07%)

rustbot assigned lcnr Aug 9, 2025

rustbot added F-autodiff `#![feature(autodiff)]` S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-clippy Relevant to the Clippy team. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 9, 2025

This comment has been minimized.

Sign in to view

fee1-dead force-pushed the push-zmqrkurlzrxy branch from 366ce16 to 7ffc537 Compare August 9, 2025 06:06

This comment has been minimized.

Sign in to view

nnethercote reviewed Aug 9, 2025

View reviewed changes

fee1-dead force-pushed the push-zmqrkurlzrxy branch from 7ffc537 to 348eced Compare August 9, 2025 06:24

nnethercote assigned nnethercote and unassigned lcnr Aug 9, 2025

fee1-dead force-pushed the push-zmqrkurlzrxy branch from 348eced to 3ba7950 Compare August 9, 2025 06:30

This comment has been minimized.

Sign in to view

remove P

ad1113f

fee1-dead force-pushed the push-zmqrkurlzrxy branch from 3ba7950 to ad1113f Compare August 9, 2025 07:47

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 9, 2025

Zalathar added a commit to Zalathar/rust that referenced this pull request Aug 9, 2025

Rollup merge of rust-lang#145146 - fee1-dead-contrib:push-zmqrkurlzrx…

60f2e55

…y, r=nnethercote remove `P` Previous work: rust-lang#141603 MCP: rust-lang/compiler-team#878 cc ``@nnethercote``

Zalathar mentioned this pull request Aug 9, 2025

Rollup of 8 pull requests #145161

Closed

bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 10, 2025

bors merged commit 41ede7b into rust-lang:master Aug 10, 2025
11 checks passed

rustbot added this to the 1.91.0 milestone Aug 10, 2025

bors mentioned this pull request Aug 10, 2025

Implement autodiff using intrinsics #142640

Merged

This was referenced Aug 10, 2025

print raw lifetime idents with r# #144897

Open

Implement #[derive(From)] #144922

Merged

fee1-dead deleted the push-zmqrkurlzrxy branch August 12, 2025 15:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

remove `P` #145146

remove `P` #145146

fee1-dead commented Aug 9, 2025 •

edited by rustbot

Loading

Uh oh!

rustbot commented Aug 9, 2025

Uh oh!

rustbot commented Aug 9, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

nnethercote Aug 9, 2025

Uh oh!

fee1-dead Aug 9, 2025 •

edited

Loading

Uh oh!

nnethercote Aug 9, 2025

Uh oh!

nnethercote commented Aug 9, 2025

Uh oh!

fee1-dead commented Aug 9, 2025

Uh oh!

This comment has been minimized.

fee1-dead commented Aug 9, 2025

Uh oh!

bors commented Aug 9, 2025

Uh oh!

bors commented Aug 9, 2025

Uh oh!

bors commented Aug 10, 2025

Uh oh!

Uh oh!

github-actions bot commented Aug 10, 2025

Uh oh!

rust-timer commented Aug 10, 2025

Uh oh!

Uh oh!

remove P #145146

remove P #145146

Conversation

fee1-dead commented Aug 9, 2025 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Aug 9, 2025

Uh oh!

rustbot commented Aug 9, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

nnethercote Aug 9, 2025

Choose a reason for hiding this comment

Uh oh!

fee1-dead Aug 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nnethercote Aug 9, 2025

Choose a reason for hiding this comment

Uh oh!

nnethercote commented Aug 9, 2025

Uh oh!

fee1-dead commented Aug 9, 2025

Uh oh!

This comment has been minimized.

fee1-dead commented Aug 9, 2025

Uh oh!

bors commented Aug 9, 2025

Uh oh!

bors commented Aug 9, 2025

Uh oh!

bors commented Aug 10, 2025

Uh oh!

Uh oh!

github-actions bot commented Aug 10, 2025

Test differences

Job duration changes

Uh oh!

rust-timer commented Aug 10, 2025

Overall result: ❌✅ regressions and improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Uh oh!

remove `P` #145146

remove `P` #145146

fee1-dead commented Aug 9, 2025 •

edited by rustbot

Loading

fee1-dead Aug 9, 2025 •

edited

Loading