Resolver: Batched Import Resolution

[LorrensP-2158466]

Transforms the current algorithm for resolving imports to a batched algorithm. Every import in the indeterminate_imports set is resolved in isolation. This is the only real difference from the current algorithm.

r? petrochenkov

[LorrensP-2158466]

Code looks a little better now and should be more correct than the previous commits, but I have yet to find a way to resolve the current test failures.

[LorrensP-2158466]

Okey, I did fix core not being built, but those other errors happened again. We now resolve the prelude import path when we create such an import at build_reduced_graph phase.

[petrochenkov]

Could you update the tests to make CI green, so I can see the difference?
(Even if the changes do not seem correct.)

[petrochenkov]

Moving prelude_import processing to build_reduced_graph may also be necessary for #139493.

[LorrensP-2158466]

I'll create a pr for it.

[rustbot]

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

[LorrensP-2158466]

Rebased to get the changes from my previous PR.

[LorrensP-2158466]

Ah right, that test.

[LorrensP-2158466]

@petrochenkov I have reverted that change in finalize_resolutions_in, so you can run crater on that if needed. In the mean time i'll try and implemented as you suggested in the zulip thread.

[petrochenkov]

@petrochenkov I have reverted that change in finalize_resolutions_in, so you can run crater on that if needed. In the mean time i'll try and implemented as you suggested in the zulip thread.

Please, set the waiting-on-review label if something is needed from me, otherwise it gets lost easily.
@bors try

[LorrensP-2158466]

Please, set the waiting-on-review label if something is needed from me, otherwise it gets lost easily.

Ah right, sorry!

[rust-bors]

☀️ Try build successful (CI)
Build commit: 2278ef2 (2278ef25f90817c20d6dd0d2da58a990eb6f53cb, parent: 0b278a539440be291466ea463a9b6310eaf4d7bb)

[petrochenkov]

@craterbot check

[craterbot]

👌 Experiment pr-145108-1 created and queued.
🤖 Automatically detected try build 2278ef2
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

[craterbot]

🚧 Experiment pr-145108-1 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

[craterbot]

🎉 Experiment pr-145108-1 is completed!
📊 195 regressed and 3 fixed (713837 total)
📊 1734 spurious results on the retry-regessed-list.txt, consider a retry¹ if this is a significant amount.
📰 Open the summary report.

⚠️ If you notice any spurious failure please add them to the denylist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

Footnotes

1. re-run the experiment with crates=https://crater-reports.s3.amazonaws.com/pr-145108-1/retry-regressed-list.txt ↩

[LorrensP-2158466]

Almost all regressions are due to the privacy error of RustEmbed or a indirect error because of that privacy error.

I found one other type of regression with some crates using polar-rs 44.2, but I don't understand that one:

error[E0308]: mismatched types
    --> src/occupancy.rs:202:36
[INFO] [stdout]     |
 202 |                       max_horizontal([
     |  _____________________--------------_^
     | |                     |
     | |                     arguments to this function are incorrect
 203 | |                         col("A_pseudo"),
 204 | |                         col("C_pseudo"),
 205 | |                         col("G_pseudo"),
 206 | |                         col("T_pseudo"),
 207 | |                     ])
     | |_____________________^ expected `&[Column]`, found `[Expr; 4]`
     |
     = note: expected reference `&[polars::prelude::Column]`
                    found array `[Expr; 4]`
 note: function defined here
    --> /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/polars-ops-0.44.2/src/series/ops/horizontal.rs:4:8
     |
   4 | pub fn max_horizontal(s: &[Column]) -> PolarsResult<Option<Column>> {

Looking up col in polar-rs 44.2 results in:

pub fn col(name: &str) -> Expr;

And I haven't found any other definitions of `max_horizontal.

[LorrensP-2158466]

Should this also check if the binding is introduced through a glob?

Currently, the case of doing the glob import with a macro also succeeds, which fails on nightly. Can we check whether the expansion IDs match?

[LorrensP-2158466]

@rustbot ready

[rust-log-analyzer]

The job aarch64-gnu-llvm-20-1 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

error[E0603]: macro `format_args` is private
    --> /cargo/registry/src/index.crates.io-1949cf8c6b5b557f/tracing-0.1.41/src/macros.rs:2961:104
     |
2961 | ...   $crate::valueset!(@ { (&$next, $crate::__macro_support::Option::Some(&$crate::__macro_support::format_args!($($rest)+) as &dyn Valu...
     |                                                                                                      ^^^^^^^^^^^ private macro
     |
note: the macro `format_args` is defined here
    --> /cargo/registry/src/index.crates.io-1949cf8c6b5b557f/tracing-0.1.41/src/lib.rs:993:34
     |
 993 |     pub use core::{concat, file, format_args, iter::Iterator, line, option::Option};
     |                                  ^^^^^^^^^^^
help: consider importing this macro instead
     |
2961 -         $crate::valueset!(@ { (&$next, $crate::__macro_support::Option::Some(&$crate::__macro_support::format_args!($($rest)+) as &dyn Value)), $($out),* }, $next, )
2961 +         $crate::valueset!(@ { (&$next, $crate::__macro_support::Option::Some(&std::format_args!($($rest)+) as &dyn Value)), $($out),* }, $next, )
     |
help: import `format_args` directly
     |
2961 -         $crate::valueset!(@ { (&$next, $crate::__macro_support::Option::Some(&$crate::__macro_support::format_args!($($rest)+) as &dyn Value)), $($out),* }, $next, )
2961 +         $crate::valueset!(@ { (&$next, $crate::__macro_support::Option::Some(&core::macros::builtin::format_args!($($rest)+) as &dyn Value)), $($out),* }, $next, )
     |

[RUSTC-TIMING] blake3 test:false 1.228
   Compiling sha1 v0.10.6
[RUSTC-TIMING] sha1 test:false 0.383