Revert "Port #[allow_internal_unsafe] to the new attribute system"

[jdonszelmann]

This reverts commit 4f7a6ac (PR: #144857)

r? @Kobzol
cc: @scrabsha

clean revert it seems :3

[Kobzol]

Thanks!

@bors r+ rollup=never p=1

[bors]

📌 Commit 866bc26 has been approved by Kobzol

It is now in the queue for this repository.

[Zalathar]

Context of the revert is a significant perf regression: #144857 (comment)

[bors]

⌛ Testing commit 866bc26 with merge c6bf245...

[rust-log-analyzer]

The job x86_64-gnu-aux failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

failures:

---- f32::test_gamma stdout ----

thread 'f32::test_gamma' (194114) panicked at library/std/tests/floats/f32.rs:198:5:
2.0000012 is not approximately equal to 2.0 (threshold 1e-6, difference 1.1920929e-6)
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
note: in Miri, you may have to set `MIRIFLAGS=-Zmiri-env-forward=RUST_BACKTRACE` for the environment variable to have an effect


failures:
    f32::test_gamma

test result: FAILED. 28 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 4.59s

error: test failed, to rerun pass `-p std --test floats`
Build completed unsuccessfully in 0:04:16
make: *** [Makefile:58: check-aux] Error 1
  local time: Fri Aug  8 12:59:26 UTC 2025
  network time: Fri, 08 Aug 2025 12:59:27 GMT
##[error]Process completed with exit code 2.
Post job cleanup.

[bors]

💔 Test failed - checks-actions

[Kobzol]

@bors retry

[scrabsha]

@Kobzol question for my personal culture: what eldritch horror caused this test to fail? It seems completely unrelated 😱

[Kobzol]

It was failing on all PRs today (https://rust-lang.zulipchat.com/#narrow/channel/242791-t-infra/topic/.E2.9C.94.20spurious.20.60f32.3A.3Atest_gamma.60.20failure.20on.20.60x86_64-gnu-aux.60.3F/with/533500698), so indeed completely unrelated to this PR.

[scrabsha]

Oh, thanks for the link!

[bors]

⌛ Testing commit 866bc26 with merge 4c7749e...

[bors]

☀️ Test successful - checks-actions
Approved by: Kobzol
Pushing 4c7749e to master...

[github-actions]

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing ffb9d94 (parent) -> 4c7749e (this PR)

Test differences

Show 62 test diffs

Stage 1

• errors::verify_passes_allow_internal_unstable_80: [missing] -> pass (J0)
• errors::verify_passes_macro_only_attribute_80: pass -> [missing] (J0)

Additionally, 60 doctest diffs were found. These are ignored, as they are noisy.

Job group index

• J0: aarch64-apple, aarch64-gnu, aarch64-gnu-llvm-19-2, aarch64-msvc-2, i686-gnu-2, i686-gnu-nopt-2, i686-msvc-2, x86_64-apple-1, x86_64-gnu, x86_64-gnu-llvm-19-1, x86_64-gnu-llvm-19-3, x86_64-gnu-llvm-20-1, x86_64-gnu-llvm-20-3, x86_64-gnu-nopt, x86_64-gnu-stable, x86_64-mingw-2, x86_64-msvc-2

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 4c7749e8c8e50ad146da599eea3a250160c1bc2b --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

1. dist-apple-various: 3596.2s -> 5161.2s (43.5%)
2. x86_64-apple-2: 5943.5s -> 5180.1s (-12.8%)
3. x86_64-apple-1: 7456.5s -> 8363.6s (12.2%)
4. x86_64-gnu-aux: 6017.5s -> 6724.9s (11.8%)
5. dist-various-1: 3729.2s -> 4142.2s (11.1%)
6. pr-check-2: 2803.6s -> 2605.2s (-7.1%)
7. x86_64-gnu-llvm-20-1: 3409.4s -> 3645.6s (6.9%)
8. x86_64-gnu-llvm-19-3: 7146.1s -> 6652.1s (-6.9%)
9. dist-aarch64-msvc: 5449.2s -> 5093.3s (-6.5%)
10. dist-i686-mingw: 8559.6s -> 9087.3s (6.2%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

[rust-timer]

Finished benchmarking commit (4c7749e): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Our benchmarks found a performance regression caused by this PR.
This might be an actual regression, but it can also be just noise.

Next Steps:

• If the regression was expected or you think it can be justified,
  please write a comment with sufficient written justification, and add
  @rustbot label: +perf-regression-triaged to it, to mark the regression as triaged.
• If you think that you know of a way to resolve the regression, try to create
  a new PR with a fix for the regression.
• If you do not understand the regression or you think that it is just noise,
  you can ask the @rust-lang/wg-compiler-performance working group for help (members of this group
  were already notified of this PR).

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.8%	[2.6%, 2.9%]	6
Improvements ✅ (primary)	-0.8%	[-4.1%, -0.1%]	121
Improvements ✅ (secondary)	-0.7%	[-1.4%, -0.1%]	39
All ❌✅ (primary)	-0.8%	[-4.1%, -0.1%]	121

Max RSS (memory usage)

Results (primary -2.2%, secondary -1.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.2%	[-2.2%, -2.2%]	1
Improvements ✅ (secondary)	-1.6%	[-2.4%, -0.9%]	4
All ❌✅ (primary)	-2.2%	[-2.2%, -2.2%]	1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 465.236s -> 463.02s (-0.48%)
Artifact size: 377.38 MiB -> 377.40 MiB (0.01%)