-
Notifications
You must be signed in to change notification settings - Fork 13.6k
Add new Tier-3 target: riscv64a23-unknown-linux-gnu #145076
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add new Tier-3 target: riscv64a23-unknown-linux-gnu #145076
Conversation
These commits modify compiler targets. Some changes occurred in src/doc/rustc/src/platform-support cc @Noratrieb |
This comment has been minimized.
This comment has been minimized.
f77bc29
to
577b85a
Compare
src/doc/rustc/src/platform-support/riscv64a23-unknown-linux-gnu.md
Outdated
Show resolved
Hide resolved
```bash | ||
rustup target add riscv64a23-unknown-linux-gnu | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tier 3 targets are usually not distributed via rustup, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct, this instruction would not work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
correct, you can ignore that for now, soon working in progess to promote it to tier-2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, the target docs should accurately reflect the current reality, not the future intent. Remove it for now, you can add it when it's tier 2.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tier 3 targets do not get built nor tested in rust-lang/rust CI, and by implication, no prebuilt artifacts will be distributed for Tier 3 targets.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Problem: Tier 3 targets do not get built nor tested in rust-lang/rust
CI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This Dockerfile is not intended for rust-lang/rust CI. Since rva23 hardware is currently unavailable, I want to provide everyone with a convenient and quick way to test locally. You can manually run tests using the following command:
DEPLOY=1 ./src/ci/docker/run.sh riscv64a23-gnu
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These dockerfiles are our CI, please don't add them yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please refrain from adding unused Dockerfiles. Previous disabled Docker files I believe were ran at some point, but broke and no one had the bandwidth/interest/expertise to fix them.
If anything, I rather delete disabled jobs that were broken for a long time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, I will revert it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently, I’m blocked by this aarch64-gnu-llvm-19-1 CI error and haven’t figure out a good way to fix it yet. can you help pls.
The target is distributed through `rustup`, and otherwise require no | ||
special configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Problem: No, Tier 3 targets are not distributed through rustup
, as Tier 3 targets are not built in rust-lang/rust
CI, we only ship prebuilt artifacts for Tier 2+.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, I’ll make changes later.
```bash | ||
rustup target add riscv64a23-unknown-linux-gnu | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct, this instruction would not work.
@@ -40,6 +40,7 @@ static HOSTS: &[&str] = &[ | |||
"powerpc64le-unknown-linux-gnu", | |||
"powerpc64le-unknown-linux-musl", | |||
"riscv64gc-unknown-linux-gnu", | |||
"riscv64a23-unknown-linux-gnu", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Problem: this and the other entry in build-manifest
I think is wrong, because this is a Tier 3 target, and we don't ship prebuilt artifacts for Tier 3 targets?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for pointing it out. It seems I wrote it in the wrong place.
@@ -155,6 +156,7 @@ static TARGETS: &[&str] = &[ | |||
"riscv64gc-unknown-none-elf", | |||
"riscv64gc-unknown-linux-gnu", | |||
"riscv64gc-unknown-linux-musl", | |||
"riscv64a23-unknown-linux-gnu", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Problem: see other comment about build-manifest
The job Click to see the possible cause of the failure (guessed by this bot)
|
☔ The latest upstream changes (presumably #145077) made this pull request unmergeable. Please resolve the merge conflicts. |
This will run all tests for `riscv64a23-unknown-linux-gnu` in a QEMU instance.
…u.md Co-authored-by: zachs18 <[email protected]>
MCP: Tier 3 target proposal: riscv64a23-unknown-linux-gnu
Changes: