-
Notifications
You must be signed in to change notification settings - Fork 13.6k
Fix doctest output json #144908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Fix doctest output json #144908
Conversation
This comment has been minimized.
This comment has been minimized.
This is very frustrating that |
Well, that is kind one of the outputs of the stage0 redesign. |
Like usual, I will wait for the separate PR I opened to be merged and available. |
We could just decide stage 1 rustdoc shouldn't exist, though that would mean that testing rustdoc would be slightly more work if you're not using download-rustc, since you could no longer just run the tests against stage1 rustdoc to prevent an extra rebuild of rustc (useful when making changes to compiler queries only used by rustdoc) |
I'd rather not. ^^' Once upon a time, changing |
It changed with the stage0 redesign. Before building in-tree libstd was required to build rustc, but not anymore (https://blog.rust-lang.org/inside-rust/2025/05/29/redesigning-the-initial-bootstrap-sequence/). |
…merged-doctests, r=Amanieu Add new `test::print_merged_doctests_times` used by rustdoc to display more detailed time information This PR is the first commit of rust-lang#144908. Sadly, it seems like we can't do all of it at once... r? `@Amanieu`
…merged-doctests, r=Amanieu Add new `test::print_merged_doctests_times` used by rustdoc to display more detailed time information This PR is the first commit of rust-lang#144908. Sadly, it seems like we can't do all of it at once... r? ``@Amanieu``
2413d04
to
51087b2
Compare
The job Click to see the possible cause of the failure (guessed by this bot)
|
…ctests, r=Amanieu Add new `test::print_merged_doctests_times` used by rustdoc to display more detailed time information This PR is the first commit of rust-lang/rust#144908. Sadly, it seems like we can't do all of it at once... r? ``@Amanieu``
☔ The latest upstream changes (presumably #145210) made this pull request unmergeable. Please resolve the merge conflicts. |
Fixes #144798.
Hopefully it will work with the new changes in
libtest
without needing to do both at once.This PR moves the
rustdoc
merged doctest extra information directly intolibtest
to ensure they share the same rendering to prevent the bug uncovered in #144798.cc @lolbinary (as you reviewed the first PR)
And since we're making changes to
libtest
:r? @Amanieu