Add `InterpCx::project_fields` #144890

WaffleLapkin · 2025-08-04T08:13:23Z

I was hoping for a much bigger improvement and this is lukewarm at best ^^'

Still, I think this makes sense.

- don't need type alias to default type argument - `Residual` impl allows to use more std APIs (like `<[T; N]>::try_map`)

rustbot · 2025-08-04T08:13:28Z

r? @nnethercote

rustbot has assigned @nnethercote.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot · 2025-08-04T08:13:29Z

Some changes occurred to the CTFE machinery

cc @RalfJung, @oli-obk, @lcnr

Some changes occurred to the CTFE / Miri interpreter

cc @rust-lang/miri

Some changes occurred to the CTFE / Miri interpreter

cc @rust-lang/miri, @RalfJung, @oli-obk, @lcnr

lcnr · 2025-08-04T13:22:40Z

compiler/rustc_middle/src/mir/interpret/error.rs

    res: Result<T, InterpErrorInfo<'tcx>>,
    guard: Guard,
 }

-// Type alias to be able to set a default type argument.


I have 0 ideas xd

Hm, somehow I must have thought that you can't have defaults in the generics of a struct 🤦

Ralf, stop reading github while on vacation!!!

lcnr · 2025-08-04T13:23:00Z

r? lcnr

@bors r+ rollup

bors · 2025-08-04T13:23:03Z

📌 Commit cf7b674 has been approved by lcnr

It is now in the queue for this repository.

Add `InterpCx::project_fields` I was hoping for a much bigger improvement and this is lukewarm at best ^^' Still, I think this makes sense.

Rollup of 18 pull requests Successful merges: - #144467 (rustdoc template font links only emit `crossorigin` when needed) - #144548 (Rehome 21 `tests/ui/issues/` tests to other subdirectories under `tests/ui/`) - #144596 (libtest: print the type of test being run) - #144741 (fix: Error on illegal `[const]`s inside blocks within legal positions) - #144776 (`Printer` cleanups) - #144779 (Implement debugging output of the bootstrap Step graph into a DOT file) - #144813 (Add a tidy check to prevent adding UI tests directly under `tests/ui/`) - #144817 (Properly reject tail calls to `&FnPtr` or `&FnDef`) - #144852 (Rename `rust_panic_without_hook` to `resume_unwind` ) - #144866 (Remove `SHOULD_EMIT_LINTS` in favor of `should_emit`) - #144867 (Use `as_array` in PartialEq for arrays) - #144872 (Document Poisoning in `LazyCell` and `LazyLock`) - #144877 (coverage: Various small cleanups) - #144887 (`rust-analyzer` subtree update) - #144890 (Add `InterpCx::project_fields`) - #144894 (Delete `tests/ui/threads-sendsync/tcp-stress.rs`) - #144905 (rustc-dev-guide subtree update) - #144920 (Dont print arg span in MIR dump for tail call) r? `@ghost` `@rustbot` modify labels: rollup

Rollup of 17 pull requests Successful merges: - #144467 (rustdoc template font links only emit `crossorigin` when needed) - #144548 (Rehome 21 `tests/ui/issues/` tests to other subdirectories under `tests/ui/`) - #144741 (fix: Error on illegal `[const]`s inside blocks within legal positions) - #144776 (`Printer` cleanups) - #144779 (Implement debugging output of the bootstrap Step graph into a DOT file) - #144813 (Add a tidy check to prevent adding UI tests directly under `tests/ui/`) - #144817 (Properly reject tail calls to `&FnPtr` or `&FnDef`) - #144852 (Rename `rust_panic_without_hook` to `resume_unwind` ) - #144866 (Remove `SHOULD_EMIT_LINTS` in favor of `should_emit`) - #144867 (Use `as_array` in PartialEq for arrays) - #144872 (Document Poisoning in `LazyCell` and `LazyLock`) - #144877 (coverage: Various small cleanups) - #144887 (`rust-analyzer` subtree update) - #144890 (Add `InterpCx::project_fields`) - #144894 (Delete `tests/ui/threads-sendsync/tcp-stress.rs`) - #144905 (rustc-dev-guide subtree update) - #144920 (Dont print arg span in MIR dump for tail call) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #144890 - WaffleLapkin:project_fields, r=lcnr Add `InterpCx::project_fields` I was hoping for a much bigger improvement and this is lukewarm at best ^^' Still, I think this makes sense.

Rollup of 17 pull requests Successful merges: - rust-lang/rust#144467 (rustdoc template font links only emit `crossorigin` when needed) - rust-lang/rust#144548 (Rehome 21 `tests/ui/issues/` tests to other subdirectories under `tests/ui/`) - rust-lang/rust#144741 (fix: Error on illegal `[const]`s inside blocks within legal positions) - rust-lang/rust#144776 (`Printer` cleanups) - rust-lang/rust#144779 (Implement debugging output of the bootstrap Step graph into a DOT file) - rust-lang/rust#144813 (Add a tidy check to prevent adding UI tests directly under `tests/ui/`) - rust-lang/rust#144817 (Properly reject tail calls to `&FnPtr` or `&FnDef`) - rust-lang/rust#144852 (Rename `rust_panic_without_hook` to `resume_unwind` ) - rust-lang/rust#144866 (Remove `SHOULD_EMIT_LINTS` in favor of `should_emit`) - rust-lang/rust#144867 (Use `as_array` in PartialEq for arrays) - rust-lang/rust#144872 (Document Poisoning in `LazyCell` and `LazyLock`) - rust-lang/rust#144877 (coverage: Various small cleanups) - rust-lang/rust#144887 (`rust-analyzer` subtree update) - rust-lang/rust#144890 (Add `InterpCx::project_fields`) - rust-lang/rust#144894 (Delete `tests/ui/threads-sendsync/tcp-stress.rs`) - rust-lang/rust#144905 (rustc-dev-guide subtree update) - rust-lang/rust#144920 (Dont print arg span in MIR dump for tail call) r? `@ghost` `@rustbot` modify labels: rollup

RalfJung · 2025-08-19T06:16:07Z

compiler/rustc_const_eval/src/interpret/visitor.rs

                // ... that contains a `NonNull`... (gladly, only a single field here)
                assert_eq!(nonnull_ptr.layout().fields.count(), 1);
                let raw_ptr = self.ecx().project_field(&nonnull_ptr, FieldIdx::ZERO)?; // the actual raw ptr
+


Why did you add some empty lines in the middle of the sentence?

(Not a big deal but not an improvement IMO either 🤷 )

I think I did not notice // the actual raw ptr part or that it connects to the next comment

In general I find it difficult to read code which looks like

f(....); // comment g(....);

I.e. where the break between logical "blocks" is a comment without a newline.

(this possibly doesn't apply here due to the linked nature of the comments)

small refactor of InterpResult

e3ed3e0

- don't need type alias to default type argument - `Residual` impl allows to use more std APIs (like `<[T; N]>::try_map`)

rustbot assigned nnethercote Aug 4, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 4, 2025

WaffleLapkin changed the title ~~Add InterpCx::project_field~~ Add InterpCx::project_fields Aug 4, 2025

This comment has been minimized.

Sign in to view

WaffleLapkin force-pushed the project_fields branch 2 times, most recently from 15caa11 to f87bd48 Compare August 4, 2025 08:41

This comment has been minimized.

Sign in to view

add project_fields helper function

cf7b674

WaffleLapkin force-pushed the project_fields branch from f87bd48 to cf7b674 Compare August 4, 2025 09:35

lcnr reviewed Aug 4, 2025

View reviewed changes

rustbot assigned lcnr Aug 4, 2025

rustbot unassigned nnethercote Aug 4, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 4, 2025

samueltardieu mentioned this pull request Aug 4, 2025

Rollup of 18 pull requests #144929

Closed

samueltardieu mentioned this pull request Aug 5, 2025

Rollup of 17 pull requests #144934

Merged

bors merged commit 58a7b87 into rust-lang:master Aug 5, 2025
10 checks passed

rustbot added this to the 1.91.0 milestone Aug 5, 2025

WaffleLapkin deleted the project_fields branch August 5, 2025 08:38

Kobzol mentioned this pull request Aug 5, 2025

Rollup of 11 pull requests #144950

Closed

samueltardieu mentioned this pull request Aug 5, 2025

Rollup of 16 pull requests #144951

Closed

RalfJung reviewed Aug 19, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add `InterpCx::project_fields` #144890

Add `InterpCx::project_fields` #144890

Uh oh!

WaffleLapkin commented Aug 4, 2025

Uh oh!

rustbot commented Aug 4, 2025

Uh oh!

rustbot commented Aug 4, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

lcnr Aug 4, 2025

Uh oh!

WaffleLapkin Aug 5, 2025

Uh oh!

RalfJung Aug 5, 2025

Uh oh!

WaffleLapkin Aug 5, 2025

Uh oh!

lcnr commented Aug 4, 2025

Uh oh!

bors commented Aug 4, 2025

Uh oh!

Uh oh!

RalfJung Aug 19, 2025 •

edited

Loading

Uh oh!

WaffleLapkin Aug 19, 2025

Uh oh!

WaffleLapkin Aug 19, 2025

Uh oh!

Uh oh!

Add InterpCx::project_fields #144890

Add InterpCx::project_fields #144890

Uh oh!

Conversation

WaffleLapkin commented Aug 4, 2025

Uh oh!

rustbot commented Aug 4, 2025

Uh oh!

rustbot commented Aug 4, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

lcnr Aug 4, 2025

Choose a reason for hiding this comment

Uh oh!

WaffleLapkin Aug 5, 2025

Choose a reason for hiding this comment

Uh oh!

RalfJung Aug 5, 2025

Choose a reason for hiding this comment

Uh oh!

WaffleLapkin Aug 5, 2025

Choose a reason for hiding this comment

Uh oh!

lcnr commented Aug 4, 2025

Uh oh!

bors commented Aug 4, 2025

Uh oh!

Uh oh!

RalfJung Aug 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

WaffleLapkin Aug 19, 2025

Choose a reason for hiding this comment

Uh oh!

WaffleLapkin Aug 19, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Add `InterpCx::project_fields` #144890

Add `InterpCx::project_fields` #144890

RalfJung Aug 19, 2025 •

edited

Loading