rustc_middle::ty cleanups
#144713
Merged
rustc_middle::ty cleanups
#144713
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's not used in `rustc_middle`, and `rustc_resolve` is a better place for it.
It's not used in `rustc_middle`, and `rustc_trait_selection` is a better place for it.
Next to all the other `EarlyParamRegion` pieces.
It's only used in `rustc_hir_typeck`.
rustbot
added
S-waiting-on-review
|
Some changes occurred in src/tools/clippy cc @rust-lang/clippy changes to the core type system |
|
I think the title of 4c89022 needs to be fixed |
It's only used in `rustc_infer`.
The fields are public, so this doesn't need a method, normal deconstruction and/or field access is good enough.
It's identical to `TyCtxt::get_all_attrs` except it takes `DefId` instead of `impl Into<DefIf>`.
It's only used in `rustc_hir_typeck`.
- Put them in the module that defines the type. - Add some `WithCachedTypeInfo<T>` asserts for consistency.
nnethercote
force-pushed
the
rustc_middle-ty-cleanups
branch
from
6150264 to
7aec38b
Compare
Done, thanks. |
bors
added
S-waiting-on-bors
rust-timer
added a commit
that referenced
this pull request
Jul 31, 2025
Rollup merge of #144713 - nnethercote:rustc_middle-ty-cleanups, r=lcnr `rustc_middle::ty` cleanups r? `@davidtwco`
tautschnig
added a commit
to tautschnig/kani
that referenced
this pull request
Aug 1, 2025
Relevant upstream PR: - rust-lang/rust#144713 (`rustc_middle::ty` cleanups) (and specifically the commit Remove `TyCtxt::get_attrs_unchecked`. therein) Resolves: model-checking#4260
github-merge-queue bot
pushed a commit
to model-checking/kani
that referenced
this pull request
Aug 1, 2025
Relevant upstream PR: - rust-lang/rust#144713 (`rustc_middle::ty` cleanups) (and specifically the commit Remove `TyCtxt::get_attrs_unchecked`. therein) Resolves: #4260 By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @davidtwco