Enable const-vector.rs test on RISC-V (riscv64) #144283
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rustbot has assigned @Mark-Simulacrum. Use |
rustbot
added
S-waiting-on-review
wesleywiser
approved these changes
Jul 22, 2025
|
Thanks @CaiWeiran! @bors r+ rollup |
bors
added
S-waiting-on-bors
|
☔ The latest upstream changes (presumably #144249) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
S-waiting-on-author
CaiWeiran
force-pushed
the
const-vector_test
branch
from
5d1b98d to
a8380f7
Compare
rustbot
removed
the
S-waiting-on-author
Kobzol
added a commit
to Kobzol/rust
that referenced
this pull request
Jul 25, 2025
…leywiser Enable const-vector.rs test on RISC-V (riscv64) This PR replaces [rust-lang#144283](rust-lang#144283) to resolve merge conflicts. This PR adds support for running the `tests/codegen/const-vector.rs` test on the RISC-V (riscv64) architecture. Previously, this test would fail on RISC-V targets due to architecture-specific code generation issues. This patch modifies the test to ensure compatibility while preserving its intent. The change has been tested locally using `./x test` on a riscv64 target, and the test now passes as expected. ### Notes: - This change is scoped specifically to improve RISC-V compatibility. - It does not affect behavior or test results on other architectures.
tgross35
added a commit
to tgross35/rust
that referenced
this pull request
Jul 26, 2025
…leywiser Enable const-vector.rs test on RISC-V (riscv64) This PR replaces [rust-lang#144283](rust-lang#144283) to resolve merge conflicts. This PR adds support for running the `tests/codegen/const-vector.rs` test on the RISC-V (riscv64) architecture. Previously, this test would fail on RISC-V targets due to architecture-specific code generation issues. This patch modifies the test to ensure compatibility while preserving its intent. The change has been tested locally using `./x test` on a riscv64 target, and the test now passes as expected. ### Notes: - This change is scoped specifically to improve RISC-V compatibility. - It does not affect behavior or test results on other architectures.
rust-timer
added a commit
that referenced
this pull request
Jul 26, 2025
Rollup merge of #144341 - CaiWeiran:const-vector_test, r=wesleywiser Enable const-vector.rs test on RISC-V (riscv64) This PR replaces [#144283](#144283) to resolve merge conflicts. This PR adds support for running the `tests/codegen/const-vector.rs` test on the RISC-V (riscv64) architecture. Previously, this test would fail on RISC-V targets due to architecture-specific code generation issues. This patch modifies the test to ensure compatibility while preserving its intent. The change has been tested locally using `./x test` on a riscv64 target, and the test now passes as expected. ### Notes: - This change is scoped specifically to improve RISC-V compatibility. - It does not affect behavior or test results on other architectures.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for running the
tests/codegen/const-vector.rstest on the RISC-V (riscv64) architecture.Previously, this test would fail on RISC-V targets due to architecture-specific code generation issues. This patch modifies the test to ensure compatibility while preserving its intent.
The change has been tested locally using
./x teston a riscv64 target, and the test now passes as expected.Notes: