Skip to content

Conversation

aDotInTheVoid
Copy link
Member

Makes it more convenient to test rustdoc on non x86_64. I mainly care about the aarch64 dev-desktops.

This works because rustdoc uses all target features, not just that of the target.

Makes it more convenient to test rustdoc on non x86_64. I mainly care
about the aarch64 dev-desktops.

This works because rustdoc uses all target features, not just that of
the target.
@rustbot
Copy link
Collaborator

rustbot commented Jul 7, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-rustdoc-json Area: Rustdoc JSON backend S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Jul 7, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jul 7, 2025

These commits modify tests/rustdoc-json.
rustdoc-json is a public (but unstable) interface.

Please ensure that if you've changed the output:

  • It's intentional.
  • The FORMAT_VERSION in src/librustdoc-json-types is bumped if necessary.

cc @aDotInTheVoid, @obi1kenobi

@aDotInTheVoid
Copy link
Member Author

I don't think PR CI will test this, but it does work:

gh-aDotInTheVoid@dev-desktop-eu-1:~/rust3$ uname -m
aarch64
gh-aDotInTheVoid@dev-desktop-eu-1:~/rust3$ ./x test ./tests/rustdoc-json/attrs/target_feature.rs --force-rerun
Building bootstrap
    Finished `dev` profile [unoptimized] target(s) in 0.06s
/home/gh-aDotInTheVoid/rust3/build/aarch64-unknown-linux-gnu/ci-llvm/bin/llvm-strip does not exist; skipping copy
Creating a sysroot for stage2 compiler (use `rustup toolchain link 'name' build/host/stage2`)
Building stage0 tool compiletest (aarch64-unknown-linux-gnu)
    Finished `release` profile [optimized] target(s) in 0.20s
Building stage0 tool jsondocck (aarch64-unknown-linux-gnu)
    Finished `release` profile [optimized] target(s) in 0.17s
Building stage0 tool jsondoclint (aarch64-unknown-linux-gnu)
    Finished `release` profile [optimized] target(s) in 0.17s
Testing stage2 compiletest suite=rustdoc-json mode=rustdoc-json (aarch64-unknown-linux-gnu)

running 1 tests
.

test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 170 filtered out; finished in 426.34ms

Build completed successfully in 0:00:02

@Mark-Simulacrum
Copy link
Member

@bors r+ rollup=iffy

@bors
Copy link
Collaborator

bors commented Jul 13, 2025

📌 Commit 45053e2 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 13, 2025
@bors
Copy link
Collaborator

bors commented Jul 13, 2025

⌛ Testing commit 45053e2 with merge 7e310f4...

@JonathanBrouwer
Copy link
Contributor

Ah I thought this wouldn't work, that's why I added this, thanks for the fix!

@bors
Copy link
Collaborator

bors commented Jul 13, 2025

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 7e310f4 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 13, 2025
@bors bors merged commit 7e310f4 into rust-lang:master Jul 13, 2025
12 checks passed
@rustbot rustbot added this to the 1.90.0 milestone Jul 13, 2025
Copy link
Contributor

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 0fb279b (parent) -> 7e310f4 (this PR)

Test differences

Show 3 test diffs

Stage 2

  • [rustdoc-json] tests/rustdoc-json/attrs/target_feature.rs: ignore (only executed when the architecture is x86_64) -> pass (J0)

Additionally, 2 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 7e310f4b9a3f166d833ed09cf1d1ff96ab84b72c --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. x86_64-apple-1: 7107.1s -> 5699.7s (-19.8%)
  2. x86_64-apple-2: 3828.1s -> 4295.4s (12.2%)
  3. dist-apple-various: 6478.3s -> 5729.5s (-11.6%)
  4. dist-aarch64-apple: 5438.5s -> 4832.1s (-11.2%)
  5. dist-armhf-linux: 4639.4s -> 5073.8s (9.4%)
  6. pr-check-2: 2394.3s -> 2219.3s (-7.3%)
  7. aarch64-gnu-debug: 3987.5s -> 3696.3s (-7.3%)
  8. dist-various-1: 3836.3s -> 4113.6s (7.2%)
  9. x86_64-gnu-llvm-19-3: 6790.2s -> 6383.0s (-6.0%)
  10. x86_64-rust-for-linux: 2672.9s -> 2518.2s (-5.8%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (7e310f4): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-0.4% [-0.4%, -0.4%] 2
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (primary 2.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
6.8% [6.8%, 6.8%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-2.1% [-2.1%, -2.1%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 2.3% [-2.1%, 6.8%] 2

Cycles

Results (secondary 6.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
6.5% [6.5%, 6.5%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 490.115s -> 465.776s (-4.97%)
Artifact size: 374.71 MiB -> 374.73 MiB (0.01%)

@aDotInTheVoid aDotInTheVoid deleted the devdesktoptestattr branch July 14, 2025 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rustdoc-json Area: Rustdoc JSON backend merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants