-
Notifications
You must be signed in to change notification settings - Fork 13.6k
Fix x86_64-unknown-netbsd
platform support page
#143566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that in the target maintainer section, there's a broken link:
This file no longer exists. I assume it's no longer called
rust185
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's called
rust188
now. https://github.com/NetBSD/pkgsrc-wip/blob/master/rust188/Makefile says "[email protected]". That's probably too generic. @he32 we might need at least two maintainers for a Tier 2 target, could you give us contacts for two?Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, yes, pkgsrc-users@ is the signal that "any of the ones with a commit bit and who has anything to contribute may do so", i.e. a more lenient policy than explicitly having to pass any updates under a specific developer's nose.
We have discussed this a bit, and you may enlist @0323pin as an additional maintainer of our amd64 / x86_64 target.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, yes, sorry about that. We have come to adopt the convention that we may have more than one rust version active in pkgsrc-wip at any time, and as such use the rust version as part of the directory name. From time to time we import a new version to pkgsrc proper, where rust has an un-versioned directory name. So ... To reference a file in pkgsrc proper, the rust package can be found mirrored on https://github.com/NetBSD/pkgsrc/tree/trunk/lang/rust
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd be happy to review a follow-up PR :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#143939