Explicitly handle all nodes in generics_of when computing parent
#143292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
oli-obk
reviewed
Jul 1, 2025
| // All of these nodes have no parent from which to inherit generics. | ||
| Node::Item(_) | Node::ForeignItem(_) => None, | ||
|
|
||
| // Params don't really have generics, but we use it when insantiating their value paths. |
There was a problem hiding this comment.
Suggested change
| // Params don't really have generics, but we use it when insantiating their value paths. | |
| // Params don't really have generics, but we use it when instantiating their value paths. |
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
|
@bors r- ill fix the typo |
bors
added
S-waiting-on-author
compiler-errors
force-pushed
the
explicit-generic
branch
from
de65358 to
0330525
Compare
|
@bors r=oli-obk rollup |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Jul 3, 2025
Rollup of 9 pull requests Successful merges: - #143192 (Improve CSS for source code block line numbers) - #143251 (bootstrap: add build.tidy-extra-checks option) - #143273 (Make the enum check work for negative discriminants) - #143292 (Explicitly handle all nodes in `generics_of` when computing parent) - #143316 (Add bootstrap check snapshot tests) - #143321 (byte-addresses memory -> byte-addressed memory) - #143324 (interpret: move the native call preparation logic into Miri) - #143325 (Use non-global interner in `test_string_interning` in bootstrap) - #143327 (miri: improve errors for type validity assertion failures) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Jul 3, 2025
Rollup merge of #143292 - compiler-errors:explicit-generic, r=oli-obk Explicitly handle all nodes in `generics_of` when computing parent If we, for example, forget to feed `generics_of` then it'll silently fall back to empty generics. Make this a bit more explicit.
RalfJung
pushed a commit
to RalfJung/miri
that referenced
this pull request
Jul 3, 2025
Rollup of 9 pull requests Successful merges: - rust-lang/rust#143192 (Improve CSS for source code block line numbers) - rust-lang/rust#143251 (bootstrap: add build.tidy-extra-checks option) - rust-lang/rust#143273 (Make the enum check work for negative discriminants) - rust-lang/rust#143292 (Explicitly handle all nodes in `generics_of` when computing parent) - rust-lang/rust#143316 (Add bootstrap check snapshot tests) - rust-lang/rust#143321 (byte-addresses memory -> byte-addressed memory) - rust-lang/rust#143324 (interpret: move the native call preparation logic into Miri) - rust-lang/rust#143325 (Use non-global interner in `test_string_interning` in bootstrap) - rust-lang/rust#143327 (miri: improve errors for type validity assertion failures) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we, for example, forget to feed
generics_ofthen it'll silently fall back to empty generics. Make this a bit more explicit.