Skip to content

Minor Documentation Improvements #143114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 29, 2025
Merged

Minor Documentation Improvements #143114

merged 3 commits into from
Jun 29, 2025
+3 −3

Conversation

leopardracer
Copy link
Contributor

Description

  • Fixed typos and improved clarity in comments and documentation.

@rustbot
Copy link
Collaborator

rustbot commented Jun 27, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 27, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jun 27, 2025

The Miri subtree was changed

cc @rust-lang/miri

@RalfJung
Copy link
Member

Thanks for the PR!

We usually don't accept random typo fixes on their own, since they are not worth the churn and review effort. However, one of these changes here is in user-facing docs, so I'll accept this. Also, changes to Miri and the other subtrees should usually be sent to those repos rather than to rustc, but I know this can all be quite confusing in the beginning and we're not strictly enforcing this for Miri, so it's fine. Just please keep this in mind for future PRs. :)

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jun 27, 2025

📌 Commit 39092cc has been approved by RalfJung

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 27, 2025
@leopardracer
Copy link
Contributor Author

📌 Commit 39092cc has been approved by RalfJung

It is now in the queue for this repository.

@bors waiting for merge

@RalfJung
Copy link
Member

That's not a valid bors command, and anyway you don't have bors permissions... what are you trying to achieve?

@leopardracer
Copy link
Contributor Author

That's not a valid bors command, and anyway you don't have bors permissions... what are you trying to achieve?

@RalfJung Oh, I didn't know that, sorry! I just saw that all checks had passed and thought it was okay to ping bors. Thanks for pointing it out. I'll keep that in mind next time.

@RalfJung
Copy link
Member

Once I did the bors r+, there's nothing you have to do (unless the bot posts a message asking you to do something, such as when there is a conflict), the bot takes care of the rest. :)

@leopardracer
Copy link
Contributor Author

Once I did the bors r+, there's nothing you have to do (unless the bot posts a message asking you to do something, such as when there is a conflict), the bot takes care of the rest. :)

Thanks so much for the clarification! 🙏

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jun 28, 2025
@matthiaskrgr
Rollup merge of rust-lang#143114 - leopardracer:master, r=RalfJung
a58f216 
Minor Documentation Improvements

---

## Description
- Fixed typos and improved clarity in comments and documentation.

---
@matthiaskrgr matthiaskrgr mentioned this pull request Jun 28, 2025
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jun 28, 2025
@matthiaskrgr
Rollup merge of rust-lang#143114 - leopardracer:master, r=RalfJung
6991c5a 
Minor Documentation Improvements

---

## Description
- Fixed typos and improved clarity in comments and documentation.

---
@matthiaskrgr matthiaskrgr mentioned this pull request Jun 28, 2025
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jun 28, 2025
@matthiaskrgr
Rollup merge of rust-lang#143114 - leopardracer:master, r=RalfJung
01e5abf 
Minor Documentation Improvements

---

## Description
- Fixed typos and improved clarity in comments and documentation.

---
@matthiaskrgr matthiaskrgr mentioned this pull request Jun 28, 2025
Closed
bors added a commit that referenced this pull request Jun 28, 2025
@bors
Auto merge of #143148 - matthiaskrgr:rollup-xlijz8h, r=matthiaskrgr
fa50220 
Rollup of 10 pull requests

Successful merges:

 - #123476 (std::net: adding `unix_socket_exclbind` feature for solaris/illumos.)
 - #142708 (Do not include NUL-terminator in computed length)
 - #142963 (Skip unnecessary components in x64 try builds)
 - #142987 (rustdoc: show attributes on enum variants)
 - #143031 (Add windows-gnullvm hosts to the manifest)
 - #143082 (update internal `send_signal` comment)
 - #143110 (Use tidy to sort `sym::*` items)
 - #143111 (BTreeSet: remove duplicated code by reusing `from_sorted_iter`)
 - #143114 (Minor Documentation Improvements)
 - #143137 (Miri subtree update)

r? `@ghost`
`@rustbot` modify labels: rollup
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jun 28, 2025
@matthiaskrgr
Rollup merge of rust-lang#143114 - leopardracer:master, r=RalfJung
2bf6b83 
Minor Documentation Improvements

---

## Description
- Fixed typos and improved clarity in comments and documentation.

---
@matthiaskrgr matthiaskrgr mentioned this pull request Jun 28, 2025
Closed
bors added a commit that referenced this pull request Jun 28, 2025
@bors
Auto merge of #143153 - matthiaskrgr:rollup-9o7vdtp, r=matthiaskrgr
6745297 
Rollup of 10 pull requests

Successful merges:

 - #123476 (std::net: adding `unix_socket_exclbind` feature for solaris/illumos.)
 - #142708 (Do not include NUL-terminator in computed length)
 - #142963 (Skip unnecessary components in x64 try builds)
 - #142974 (Update stage0 to 1.89.0-beta.1)
 - #142987 (rustdoc: show attributes on enum variants)
 - #143031 (Add windows-gnullvm hosts to the manifest)
 - #143082 (update internal `send_signal` comment)
 - #143110 (Use tidy to sort `sym::*` items)
 - #143111 (BTreeSet: remove duplicated code by reusing `from_sorted_iter`)
 - #143114 (Minor Documentation Improvements)

r? `@ghost`
`@rustbot` modify labels: rollup
@matthiaskrgr matthiaskrgr mentioned this pull request Jun 28, 2025
Merged
bors added a commit that referenced this pull request Jun 28, 2025
@bors
Auto merge of #143157 - matthiaskrgr:rollup-90rtm3a, r=<try>
32c9875 
Rollup of 9 pull requests

Successful merges:

 - #123476 (std::net: adding `unix_socket_exclbind` feature for solaris/illumos.)
 - #142708 (Do not include NUL-terminator in computed length)
 - #142963 (Skip unnecessary components in x64 try builds)
 - #142987 (rustdoc: show attributes on enum variants)
 - #143031 (Add windows-gnullvm hosts to the manifest)
 - #143082 (update internal `send_signal` comment)
 - #143110 (Use tidy to sort `sym::*` items)
 - #143111 (BTreeSet: remove duplicated code by reusing `from_sorted_iter`)
 - #143114 (Minor Documentation Improvements)

r? `@ghost`
`@rustbot` modify labels: rollup

try-job: dist-i586-gnu-i586-i686-musl
bors added a commit that referenced this pull request Jun 28, 2025
@bors
Auto merge of #143157 - matthiaskrgr:rollup-90rtm3a, r=matthiaskrgr
cf38b8e 
Rollup of 9 pull requests

Successful merges:

 - #123476 (std::net: adding `unix_socket_exclbind` feature for solaris/illumos.)
 - #142708 (Do not include NUL-terminator in computed length)
 - #142963 (Skip unnecessary components in x64 try builds)
 - #142987 (rustdoc: show attributes on enum variants)
 - #143031 (Add windows-gnullvm hosts to the manifest)
 - #143082 (update internal `send_signal` comment)
 - #143110 (Use tidy to sort `sym::*` items)
 - #143111 (BTreeSet: remove duplicated code by reusing `from_sorted_iter`)
 - #143114 (Minor Documentation Improvements)

r? `@ghost`
`@rustbot` modify labels: rollup

try-job: dist-i586-gnu-i586-i686-musl
@bors bors merged commit a62de82 into rust-lang:master Jun 29, 2025
10 checks passed
rust-timer added a commit that referenced this pull request Jun 29, 2025
@rust-timer
Unrolled build for #143114
75465d6 
Rollup merge of #143114 - leopardracer:master, r=RalfJung

Minor Documentation Improvements

---

## Description
- Fixed typos and improved clarity in comments and documentation.

---
@rustbot rustbot added this to the 1.90.0 milestone Jun 29, 2025
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Jun 29, 2025
@bors
Auto merge of #143157 - matthiaskrgr:rollup-90rtm3a, r=matthiaskrgr
6b0d277 
Rollup of 9 pull requests

Successful merges:

 - rust-lang/rust#123476 (std::net: adding `unix_socket_exclbind` feature for solaris/illumos.)
 - rust-lang/rust#142708 (Do not include NUL-terminator in computed length)
 - rust-lang/rust#142963 (Skip unnecessary components in x64 try builds)
 - rust-lang/rust#142987 (rustdoc: show attributes on enum variants)
 - rust-lang/rust#143031 (Add windows-gnullvm hosts to the manifest)
 - rust-lang/rust#143082 (update internal `send_signal` comment)
 - rust-lang/rust#143110 (Use tidy to sort `sym::*` items)
 - rust-lang/rust#143111 (BTreeSet: remove duplicated code by reusing `from_sorted_iter`)
 - rust-lang/rust#143114 (Minor Documentation Improvements)

r? `@ghost`
`@rustbot` modify labels: rollup

try-job: dist-i586-gnu-i586-i686-musl
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.90.0
Development

Successfully merging this pull request may close these issues.
5 participants
@leopardracer @rustbot @RalfJung @bors @Mark-Simulacrum