Skip to content

Skip unnecessary components in x64 try builds #142963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Kobzol
Copy link
Contributor

@Kobzol Kobzol commented Jun 24, 2025

We unnecessarily rebuild wasm-component-ld, llvm-bitcode-linker and Cranelift during the intermediate PGO builds several times times, which is unnecessarily and increases the duration of try builds. This PR also disables some unnecessary dist components.

r? @jieyouxu

@rustbot
Copy link
Collaborator

rustbot commented Jun 24, 2025

jieyouxu is not on the review rotation at the moment.
They may take a while to respond.

@Kobzol
Copy link
Contributor Author

Kobzol commented Jun 24, 2025

@bors2 try

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 24, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jun 24, 2025

Some changes occurred in src/tools/opt-dist

cc @Kobzol

@rust-bors
Copy link

rust-bors bot commented Jun 24, 2025

⌛ Trying commit ced1523 with merge e1cdefe

To cancel the try build, run the command @bors2 try cancel.

rust-bors bot added a commit that referenced this pull request Jun 24, 2025
Skip unnecessary components in x64 try builds

We unnecessarily rebuild `wasm-component-ld`, `llvm-bitcode-linker` and Cranelift during the intermediate PGO builds several times times, which is unnecessarily and increases the duration of try builds. This PR also disables some unnecessary dist components.

r? `@jieyouxu`
@Kobzol
Copy link
Contributor Author

Kobzol commented Jun 24, 2025

Recent try builds were ~2.5h.

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Jun 24, 2025
@Kobzol
Copy link
Contributor Author

Kobzol commented Jun 24, 2025

@bors2 try

@rust-bors
Copy link

rust-bors bot commented Jun 24, 2025

⌛ Trying commit 76a8080 with merge 936a203

(The previously running try build was automatically cancelled.)

To cancel the try build, run the command @bors2 try cancel.

rust-bors bot added a commit that referenced this pull request Jun 24, 2025
Skip unnecessary components in x64 try builds

We unnecessarily rebuild `wasm-component-ld`, `llvm-bitcode-linker` and Cranelift during the intermediate PGO builds several times times, which is unnecessarily and increases the duration of try builds. This PR also disables some unnecessary dist components.

r? `@jieyouxu`
@@ -407,13 +407,18 @@ fn main() -> anyhow::Result<()> {
for target in [
"rust-docs",
"rustc-docs",
"rustc-dev",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: to double-check, the "fast try build" is where the user never specified an actual job matcher, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, the try builds most often used for perf. runs. The are so slow now :( A few years ago after my optimizations they were barely 1 hour, but now it's 2.5h :( Just BOLT alone takes >1h, it writes 100 GiB of profiles to disk, lol.

Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Feel free to r=me once the try job comes back okay.

@Kobzol
Copy link
Contributor Author

Kobzol commented Jun 24, 2025

@rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 24, 2025
@rust-bors
Copy link

rust-bors bot commented Jun 24, 2025

☀️ Try build successful (CI)
Build commit: 936a203 (936a203ffd25c86bc604222fb47a7d3f0e429bd5, parent: 36b21637e93b038453924d3c66821089e71d8baa)

@rust-timer
Copy link
Collaborator

Queued 936a203 with parent 36b2163, future comparison URL.
There are currently 4 preceding artifacts in the queue.
It will probably take at least ~6.2 hours until the benchmark run finishes.

@Kobzol
Copy link
Contributor Author

Kobzol commented Jun 24, 2025

(Starting another build to time it with Docker cache primed).

@bors2 try

@rust-bors
Copy link

rust-bors bot commented Jun 24, 2025

⌛ Trying commit 76a8080 with merge d732d09

To cancel the try build, run the command @bors2 try cancel.

rust-bors bot added a commit that referenced this pull request Jun 24, 2025
Skip unnecessary components in x64 try builds

We unnecessarily rebuild `wasm-component-ld`, `llvm-bitcode-linker` and Cranelift during the intermediate PGO builds several times times, which is unnecessarily and increases the duration of try builds. This PR also disables some unnecessary dist components.

r? `@jieyouxu`
@rust-bors
Copy link

rust-bors bot commented Jun 24, 2025

☀️ Try build successful (CI)
Build commit: d732d09 (d732d09fce8a79b588d90ae46965cc2435c617f5, parent: 36b21637e93b038453924d3c66821089e71d8baa)

@Kobzol
Copy link
Contributor Author

Kobzol commented Jun 24, 2025

Ok, 2h. That's still quite slow, but much better than 2.5 hours before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-perf Status: Waiting on a perf run to be completed. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants