-
Notifications
You must be signed in to change notification settings - Fork 13.5k
Skip unnecessary components in x64 try builds #142963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
@bors2 try |
Some changes occurred in src/tools/opt-dist cc @Kobzol |
Skip unnecessary components in x64 try builds We unnecessarily rebuild `wasm-component-ld`, `llvm-bitcode-linker` and Cranelift during the intermediate PGO builds several times times, which is unnecessarily and increases the duration of try builds. This PR also disables some unnecessary dist components. r? `@jieyouxu`
Recent try builds were ~2.5h. |
@bors2 try |
Skip unnecessary components in x64 try builds We unnecessarily rebuild `wasm-component-ld`, `llvm-bitcode-linker` and Cranelift during the intermediate PGO builds several times times, which is unnecessarily and increases the duration of try builds. This PR also disables some unnecessary dist components. r? `@jieyouxu`
@@ -407,13 +407,18 @@ fn main() -> anyhow::Result<()> { | |||
for target in [ | |||
"rust-docs", | |||
"rustc-docs", | |||
"rustc-dev", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: to double-check, the "fast try build" is where the user never specified an actual job matcher, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, the try builds most often used for perf. runs. The are so slow now :( A few years ago after my optimizations they were barely 1 hour, but now it's 2.5h :( Just BOLT alone takes >1h, it writes 100 GiB of profiles to disk, lol.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Feel free to r=me once the try job comes back okay.
@rust-timer queue |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
Queued 936a203 with parent 36b2163, future comparison URL. |
(Starting another build to time it with Docker cache primed). @bors2 try |
Skip unnecessary components in x64 try builds We unnecessarily rebuild `wasm-component-ld`, `llvm-bitcode-linker` and Cranelift during the intermediate PGO builds several times times, which is unnecessarily and increases the duration of try builds. This PR also disables some unnecessary dist components. r? `@jieyouxu`
Ok, 2h. That's still quite slow, but much better than 2.5 hours before. |
We unnecessarily rebuild
wasm-component-ld
,llvm-bitcode-linker
and Cranelift during the intermediate PGO builds several times times, which is unnecessarily and increases the duration of try builds. This PR also disables some unnecessary dist components.r? @jieyouxu