Skip to content

std: introduce path normalize methods at top of std::path #142957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

std: introduce path normalize methods at top of std::path #142957

wants to merge 1 commit into from
+14 −0

Conversation

xizheyin
Copy link
Member

@xizheyin xizheyin commented Jun 24, 2025 •
edited by rustbot
Loading

Closes #142931

Mention other methods that call conponents and canonicalize that fully normalize path. And fix two typo.

r? libs

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jun 24, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@ibraheemdev
Copy link
Member

ibraheemdev commented Jul 6, 2025 •
edited
Loading

Given the discussion on the issue, I think it would make more sense to have an overview in the top-level std::path documentation rather than intra-linking everything. You can open a separate PR for the typos if you wish to get that merged sooner.

@ibraheemdev ibraheemdev added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 6, 2025
@xizheyin
Copy link
Member Author

xizheyin commented Jul 7, 2025

@rustbot ready

I added a section Path normalization on top of std::Path.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 7, 2025
@xizheyin xizheyin changed the title std: mention other methods that normalize a path in normalize_lexically doc std: introduce path normalize methods at top of std::path Jul 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ibraheemdev ibraheemdev

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

normalize_lexically should mention other functions that do basic normalization
4 participants
@xizheyin @rust-log-analyzer @ibraheemdev @rustbot