-
Notifications
You must be signed in to change notification settings - Fork 13.7k
Offload host2 #142696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Offload host2 #142696
Conversation
This comment has been minimized.
This comment has been minimized.
☔ The latest upstream changes (presumably #143026) made this pull request unmergeable. Please resolve the merge conflicts. |
We'll still need #143684 to properly recognize our GPU hardware and run the binary on end-user hardware, but here I'll only add codegen tests, so it should work fine for CI. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
related (also wip) rustc-dev-guide update: rust-lang/rustc-dev-guide#2524 |
c6ca7f4
to
cc13fc3
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
06c8ab6
to
5a3207d
Compare
This comment has been minimized.
This comment has been minimized.
5a3207d
to
487ff89
Compare
This comment has been minimized.
This comment has been minimized.
487ff89
to
8cfcbaf
Compare
This comment has been minimized.
This comment has been minimized.
0feda32
to
2ba8703
Compare
This comment has been minimized.
This comment has been minimized.
2ba8703
to
b603067
Compare
This comment has been minimized.
This comment has been minimized.
b603067
to
08e4dbb
Compare
This comment has been minimized.
This comment has been minimized.
08e4dbb
to
6e948da
Compare
It turns out with enough bugfixes on the host code, this is already enough to launch and run some code. |
Requested reviewer is already assigned to this pull request. Please choose another assignee. |
cc @Kobzol CI failure (failed to clean up disk space), seems unrelated to my work. |
Yeah that's spurious. |
r? @oli-obk
A follow-up to my previous gpu host PR. With this, I can (in theory) run a sufficiently simple Rust function on GPUs. I tested it on AMD, where the amdgcn tartget of rustc causes issues due to Addressspace castings, which might not be valid. If I (manually) fix them, I can run the generated IR on an AMD GPU. This should conceptually also work on NVIDIA or Intel. I updated the dev-guide acordingly: https://rustc-dev-guide.rust-lang.org/offload/usage.html
I am unhappy with the amount of standalone functions in my offload code, so in my second commit I bundled some of the code around two structs which are Rust versions of the LLVM/Offload structs which they represent. The structs themselves only have doc comments. Since I directly lower everything to llvm-ir I didn't saw a big value in modelling the struct member variables.