Skip to content

rework #[naked] attribute parser #142493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

rework #[naked] attribute parser #142493

wants to merge 3 commits into from
+265 −197

Conversation

jdonszelmann
Copy link
Contributor

@jdonszelmann jdonszelmann commented Jun 14, 2025 •
edited
Loading

@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) A-rustdoc-json Area: Rustdoc JSON backend T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Jun 14, 2025
@jdonszelmann jdonszelmann mentioned this pull request Jun 14, 2025
Open
9 tasks
@jdonszelmann jdonszelmann force-pushed the naked branch 2 times, most recently from 48b6d12 to 78a8771 Compare June 19, 2025 08:03
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@jdonszelmann
Copy link
Contributor Author

cc: @folkertdev this might interest you

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Collaborator

bors commented Jun 20, 2025

☔ The latest upstream changes (presumably #142795) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jun 20, 2025
@jdonszelmann jdonszelmann mentioned this pull request Jun 21, 2025
Open
@jdonszelmann jdonszelmann marked this pull request as ready for review June 21, 2025 09:17
@rustbot
Copy link
Collaborator

rustbot commented Jun 21, 2025

Some changes occurred in compiler/rustc_codegen_ssa

cc @WaffleLapkin

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 21, 2025
oli-obk
oli-obk reviewed Jun 21, 2025
View reviewed changes
oli-obk
oli-obk reviewed Jun 21, 2025
View reviewed changes
oli-obk
oli-obk reviewed Jun 21, 2025
View reviewed changes
@jdonszelmann jdonszelmann mentioned this pull request Jun 21, 2025
Open
@jdonszelmann
Copy link
Contributor Author

@rustbot ready

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oli-obk oli-obk oli-obk left review comments

Assignees

@oli-obk oli-obk

Labels
A-attributes Area: Attributes (`#[…]`, `#![…]`) A-rustdoc-json Area: Rustdoc JSON backend S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jdonszelmann @rust-log-analyzer @bors @rustbot @oli-obk