cache `param_env` canonicalization #141451

lcnr · 2025-05-23T14:51:32Z

BLocked on #141581

lcnr · 2025-05-23T14:51:43Z

@bors try @rust-timer queue

[perf] next-solver canonicalization + eager-resolve kinda hacky

bors · 2025-05-23T14:52:55Z

⌛ Trying commit bbb26f3 with merge f57ef94...

bors · 2025-05-23T16:57:32Z

☀️ Try build successful - checks-actions
Build commit: f57ef94 (f57ef94bead8b209710bbaea79a1694b3d13bd6f)

rust-timer · 2025-05-24T02:01:15Z

Finished benchmarking commit (f57ef94): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-26.3%	[-62.9%, -0.6%]	14
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (primary -2.4%, secondary -2.2%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.5%	[2.3%, 4.7%]	2
Improvements ✅ (primary)	-2.4%	[-3.5%, -0.8%]	4
Improvements ✅ (secondary)	-2.7%	[-4.2%, -1.7%]	26
All ❌✅ (primary)	-2.4%	[-3.5%, -0.8%]	4

Cycles

Results (secondary -34.4%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-34.4%	[-54.8%, -5.3%]	9
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 776.992s -> 776.925s (-0.01%)
Artifact size: 365.49 MiB -> 365.58 MiB (0.02%)

lcnr · 2025-05-26T11:00:57Z

@bors try @rust-timer quue

lcnr · 2025-05-26T11:01:02Z

@rust-timer queue

[perf] next-solver canonicalization + eager-resolve kinda hacky

bors · 2025-05-26T11:02:09Z

⌛ Trying commit c3eaa13 with merge ac15b82...

rustbot · 2025-05-26T11:06:28Z

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot · 2025-05-26T11:06:29Z

Some changes occurred to the core trait solver

cc @rust-lang/initiative-trait-system-refactor

add additional `TypeFlags` fast paths Some crates, e.g. `diesel`, have items with a lot of where-clauses (more than 150). In these cases checking the `TypeFlags` of the whole `param_env` can be very beneficial. This adds `fn fold_clauses` to mirror the existing `fn visit_clauses` and then uses this in folders which fold `ParamEnv`s. Split out from #141451, depends on #141442. r? `@compiler-errors`

add additional `TypeFlags` fast paths Some crates, e.g. `diesel`, have items with a lot of where-clauses (more than 150). In these cases checking the `TypeFlags` of the whole `param_env` can be very beneficial. This adds `fn fold_clauses` to mirror the existing `fn visit_clauses` and then uses this in folders which fold `ParamEnv`s. Split out from rust-lang/rust#141451, depends on rust-lang/rust#141442. r? `@compiler-errors`

compiler-errors · 2025-06-09T02:47:05Z

Rebased the remaining two commits, and I'm curious to gauge perf again since other optimizations have landed.

@bors2 try @rust-timer queue

rust-bors · 2025-06-09T02:47:08Z

⌛ Trying commit 758f4c9 with merge eb709e5…

To cancel the try build, run the command @bors2 try cancel.

add more `TypeFlags` fast paths, cache `param_env` canonicalization BLocked on #141581

rust-bors · 2025-06-09T05:16:23Z

☀️ Try build successful (CI)
Build commit: eb709e5 (eb709e5dab5f4e848f0d6aea69b1f1b208007829)

rust-timer · 2025-06-09T06:43:09Z

Finished benchmarking commit (eb709e5): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-18.3%	[-56.0%, -0.2%]	13
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (secondary -0.9%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.9%	[2.9%, 2.9%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.8%	[-3.0%, -2.5%]	2
All ❌✅ (primary)	-	-	0

Cycles

Results (secondary -20.3%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-20.3%	[-45.1%, -2.2%]	9
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 751.176s -> 752.102s (0.12%)
Artifact size: 372.27 MiB -> 372.14 MiB (-0.04%)

add additional `TypeFlags` fast paths Some crates, e.g. `diesel`, have items with a lot of where-clauses (more than 150). In these cases checking the `TypeFlags` of the whole `param_env` can be very beneficial. This adds `fn fold_clauses` to mirror the existing `fn visit_clauses` and then uses this in folders which fold `ParamEnv`s. Split out from rust-lang/rust#141451, depends on rust-lang/rust#141442. r? `@compiler-errors`

compiler-errors · 2025-06-09T16:48:07Z

@bors r+ rollup=never

bors · 2025-06-09T16:48:09Z

📌 Commit 758f4c9 has been approved by compiler-errors

It is now in the queue for this repository.

bors · 2025-06-10T10:42:38Z

⌛ Testing commit 758f4c9 with merge 100199c...

bors · 2025-06-10T13:40:42Z

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing 100199c to master...

github-actions · 2025-06-10T13:43:19Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 40daf23 (parent) -> 100199c (this PR)

Test differences

Show 4 test diffs

4 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 100199c9aa50b0c47b37c9c86335d68b2a77b535 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

dist-apple-various: 5968.4s -> 8142.3s (36.4%)
x86_64-apple-2: 3941.8s -> 5136.4s (30.3%)
dist-aarch64-linux: 7971.2s -> 5579.7s (-30.0%)
aarch64-apple: 5191.3s -> 4059.4s (-21.8%)
mingw-check-1: 1625.0s -> 1928.3s (18.7%)
dist-x86_64-apple: 8117.4s -> 9443.0s (16.3%)
dist-aarch64-apple: 5610.2s -> 4724.6s (-15.8%)
aarch64-gnu-debug: 3546.7s -> 4103.9s (15.7%)
x86_64-gnu-llvm-20-1: 3187.6s -> 3649.2s (14.5%)
x86_64-apple-1: 6353.0s -> 7166.8s (12.8%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2025-06-10T16:36:39Z

Finished benchmarking commit (100199c): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Our benchmarks found a performance regression caused by this PR.
This might be an actual regression, but it can also be just noise.

Next Steps:

If the regression was expected or you think it can be justified,
please write a comment with sufficient written justification, and add
@rustbot label: +perf-regression-triaged to it, to mark the regression as triaged.
If you think that you know of a way to resolve the regression, try to create
a new PR with a fix for the regression.
If you do not understand the regression or you think that it is just noise,
you can ask the @rust-lang/wg-compiler-performance working group for help (members of this group
were already notified of this PR).

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	0.5%	[0.5%, 0.5%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-18.3%	[-56.0%, -0.2%]	13
All ❌✅ (primary)	0.5%	[0.5%, 0.5%]	1

Max RSS (memory usage)

Results (primary -9.2%, secondary 2.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.4%	[1.0%, 3.5%]	4
Improvements ✅ (primary)	-9.2%	[-9.2%, -9.2%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-9.2%	[-9.2%, -9.2%]	1

Cycles

Results (secondary -17.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	1.0%	[1.0%, 1.0%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-19.9%	[-45.1%, -1.8%]	9
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 753.145s -> 755.155s (0.27%)
Artifact size: 372.18 MiB -> 372.17 MiB (-0.00%)

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 23, 2025

bors added a commit that referenced this pull request May 23, 2025

Auto merge of #141451 - lcnr:canonicalize-env-cache, r=<try>

f57ef94

[perf] next-solver canonicalization + eager-resolve kinda hacky

This comment has been minimized.

Sign in to view

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 24, 2025

lcnr mentioned this pull request May 25, 2025

Fold predicate fast path in canonicalizer and eager resolver #141442

Merged

rust-cloud-vms bot force-pushed the canonicalize-env-cache branch 2 times, most recently from 91ee32e to c3eaa13 Compare May 26, 2025 11:00

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 26, 2025

bors added a commit that referenced this pull request May 26, 2025

Auto merge of #141451 - lcnr:canonicalize-env-cache, r=<try>

ac15b82

[perf] next-solver canonicalization + eager-resolve kinda hacky

rust-cloud-vms bot force-pushed the canonicalize-env-cache branch from c3eaa13 to 20a2cd8 Compare May 26, 2025 11:05

lcnr changed the title ~~[perf] next-solver canonicalization + eager-resolve~~ add more TypeFlags fast paths, cache param_env canonicalization May 26, 2025

lcnr marked this pull request as ready for review May 26, 2025 11:06

rustbot assigned davidtwco May 26, 2025

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 26, 2025

lcnr mentioned this pull request May 29, 2025

Next-generation trait solver rust-lang/rust-project-goals#113

Open

4 tasks

lcnr added 2 commits June 8, 2025 22:41

move canonicalize_param_env into sub-fn

87141e3

add param_env cache to canonicalization

758f4c9

compiler-errors force-pushed the canonicalize-env-cache branch from 20a2cd8 to 758f4c9 Compare June 9, 2025 02:46

This comment has been minimized.

Sign in to view

rust-bors bot added a commit that referenced this pull request Jun 9, 2025

Auto merge of #141451 - lcnr:canonicalize-env-cache, r=<try>

eb709e5

add more `TypeFlags` fast paths, cache `param_env` canonicalization BLocked on #141581

This comment has been minimized.

Sign in to view

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 9, 2025

lcnr changed the title ~~add more TypeFlags fast paths, cache param_env canonicalization~~ cache param_env canonicalization Jun 9, 2025

compiler-errors approved these changes Jun 9, 2025

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 9, 2025

bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 10, 2025

bors merged commit 100199c into rust-lang:master Jun 10, 2025
11 checks passed

rustbot added this to the 1.89.0 milestone Jun 10, 2025

lcnr deleted the canonicalize-env-cache branch June 10, 2025 14:27

rustbot added the perf-regression Performance regression. label Jun 10, 2025

cache param_env canonicalization #141451

cache param_env canonicalization #141451

Conversation

lcnr commented May 23, 2025 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lcnr commented May 23, 2025

Uh oh!

This comment has been minimized.

bors commented May 23, 2025

Uh oh!

bors commented May 23, 2025

Uh oh!

This comment has been minimized.

rust-timer commented May 24, 2025

Overall result: ✅ improvements - no action needed

Uh oh!

lcnr commented May 26, 2025

Uh oh!

lcnr commented May 26, 2025

Uh oh!

This comment has been minimized.

bors commented May 26, 2025

Uh oh!

rustbot commented May 26, 2025

Uh oh!

rustbot commented May 26, 2025

Uh oh!

compiler-errors commented Jun 9, 2025

Uh oh!

This comment has been minimized.

rust-bors bot commented Jun 9, 2025

Uh oh!

rust-bors bot commented Jun 9, 2025

Uh oh!

This comment has been minimized.

rust-timer commented Jun 9, 2025

Overall result: ✅ improvements - no action needed

Uh oh!

compiler-errors commented Jun 9, 2025

Uh oh!

bors commented Jun 9, 2025

Uh oh!

bors commented Jun 10, 2025

Uh oh!

bors commented Jun 10, 2025

Uh oh!

Uh oh!

github-actions bot commented Jun 10, 2025

Test differences

Job duration changes

Uh oh!

rust-timer commented Jun 10, 2025

Overall result: ❌✅ regressions and improvements - please read the text below

Uh oh!

Uh oh!

cache `param_env` canonicalization #141451

cache `param_env` canonicalization #141451

lcnr commented May 23, 2025 •

edited by rustbot

Loading