Skip to content

Conversation

Zalathar
Copy link
Contributor

As with DIBuilderBox, the "Box" suffix does a better job of communicating that this is an owning pointer to some borrowable resource.

This also renames the raw method to as_ref, which is what it would have been named originally if the Deref problem (#137603) had been known at the time.

No functional change.

As with `DIBuilderBox`, the "Box" suffix does a better job of communicating
that this is an owning pointer to some borrowable resource.

This also renames the `raw` method to `as_ref`, which is what it would have
been named originally if the `Deref` problem had been known at the time.
@rustbot
Copy link
Collaborator

rustbot commented May 11, 2025

r? @lcnr

rustbot has assigned @lcnr.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 11, 2025
@lcnr
Copy link
Contributor

lcnr commented May 11, 2025

r=me after CI

@Zalathar
Copy link
Contributor Author

@bors r=lcnr rollup

@bors
Copy link
Collaborator

bors commented May 11, 2025

📌 Commit dbdbde2 has been approved by lcnr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 11, 2025
@bors
Copy link
Collaborator

bors commented May 12, 2025

⌛ Testing commit dbdbde2 with merge 718ddf6...

@bors
Copy link
Collaborator

bors commented May 12, 2025

☀️ Test successful - checks-actions
Approved by: lcnr
Pushing 718ddf6 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 12, 2025
@bors bors merged commit 718ddf6 into rust-lang:master May 12, 2025
7 checks passed
@rustbot rustbot added this to the 1.89.0 milestone May 12, 2025
Copy link
Contributor

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 6812af9 (parent) -> 718ddf6 (this PR)

Test differences

No test diffs found

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 718ddf660e6a1802c39b4962cf7eaa4db57025ef --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-aarch64-linux: 7969.9s -> 5464.2s (-31.4%)
  2. aarch64-apple: 3830.7s -> 4720.5s (23.2%)
  3. x86_64-mingw-2: 7020.9s -> 7528.2s (7.2%)
  4. x86_64-apple-1: 7495.9s -> 6994.6s (-6.7%)
  5. dist-x86_64-apple: 7474.2s -> 7967.5s (6.6%)
  6. x86_64-apple-2: 5043.9s -> 4732.4s (-6.2%)
  7. dist-various-2: 3206.9s -> 3402.8s (6.1%)
  8. dist-arm-linux: 5483.4s -> 5195.8s (-5.2%)
  9. dist-various-1: 4272.1s -> 4478.8s (4.8%)
  10. x86_64-gnu: 6681.5s -> 6389.9s (-4.4%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@Zalathar Zalathar deleted the operand-bundle branch May 12, 2025 04:40
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (718ddf6): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-0.2% [-0.2%, -0.2%] 1
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (primary 0.6%, secondary 1.3%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
2.1% [0.4%, 3.8%] 2
Regressions ❌
(secondary)
1.3% [1.3%, 1.3%] 1
Improvements ✅
(primary)
-0.8% [-1.2%, -0.5%] 2
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 0.6% [-1.2%, 3.8%] 4

Cycles

Results (primary -1.4%, secondary 7.4%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
7.4% [7.2%, 7.5%] 2
Improvements ✅
(primary)
-1.4% [-2.3%, -0.4%] 2
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -1.4% [-2.3%, -0.4%] 2

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 772.534s -> 772.98s (0.06%)
Artifact size: 365.43 MiB -> 365.35 MiB (-0.02%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants