Skip to content

Add regression test for #140545 #140568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 3, 2025
Merged

Add regression test for #140545 #140568

merged 1 commit into from
May 3, 2025

Conversation

moxian
Copy link
Contributor

@moxian moxian commented May 1, 2025

Closes #140545

I am not very knowledgable about the typesystem internals, so I couldn't come up with a good name for the test. But I'm happy to move it to a more appropriate place if there is one (tests/ui/impl-trait/non-defining-uses maybe?)

r? types (or reroll as appropriate if this is not actually a T-types issue; i'm clueless)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 1, 2025
@compiler-errors
Copy link
Member

Yeah, just move this to tests/ui/impl-trait/non-defining-uses/double-wrap-with-defining-use.rs or something. It doesn't need an issue number in the UI test file name.

@compiler-errors
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented May 2, 2025

📌 Commit dcee18b has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 2, 2025
bors added a commit to rust-lang-ci/rust that referenced this pull request May 3, 2025
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#139343 (Change signature of File::try_lock and File::try_lock_shared)
 - rust-lang#140505 (linker: Quote symbol names in .def files)
 - rust-lang#140534 (PassWrapper: adapt for llvm/llvm-project@f137c3d592e96330e450a8fd63ef…)
 - rust-lang#140546 (Remove backtrace dep from anyhow in features status dump tool)
 - rust-lang#140548 (Emit user type annotations for free consts in pattern position)
 - rust-lang#140564 (Use present indicative tense in std::io::pipe() API docs)
 - rust-lang#140568 (Add regression test for rust-lang#140545)
 - rust-lang#140606 (Improve hir pretty printing)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 5f9330c into rust-lang:master May 3, 2025
6 checks passed
@rustbot rustbot added this to the 1.88.0 milestone May 3, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request May 3, 2025
Rollup merge of rust-lang#140568 - moxian:reg-140545, r=compiler-errors

Add regression test for rust-lang#140545

Closes rust-lang#140545

I am not very knowledgable about the typesystem internals, so I couldn't come up with a good name for the test. But I'm happy to move it to a more appropriate place if there is one (`tests/ui/impl-trait/non-defining-uses` maybe?)

r? types (or reroll as appropriate if this is not actually a T-types issue; i'm clueless)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Erroneous compile errors when returning impl trait
5 participants