Skip to content

Conversation

onur-ozkan
Copy link
Contributor

self-explanatory

Fixes #140299

@rustbot
Copy link
Collaborator

rustbot commented May 1, 2025

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels May 1, 2025
@onur-ozkan onur-ozkan force-pushed the extend-dylib-paths branch from 33e96ff to 7b25d4a Compare May 1, 2025 19:32
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jieyouxu
Copy link
Member

jieyouxu commented May 2, 2025

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented May 2, 2025

📌 Commit 7b25d4a has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 2, 2025
VlaDexa added a commit to VlaDexa/rust that referenced this pull request May 2, 2025
…ieyouxu

extend the list of registered dylibs on `test::prepare_cargo_test`

self-explanatory

Fixes rust-lang#140299
@cuviper
Copy link
Member

cuviper commented May 2, 2025

Works for me! And since #140299 also reproduces on beta, maybe it's worth backporting?

@rustbot label beta-nominated

@rustbot rustbot added the beta-nominated Nominated for backporting to the compiler in the beta channel. label May 2, 2025
@onur-ozkan
Copy link
Contributor Author

I agree.

@rustbot label beta-accepted

@rustbot rustbot added the beta-accepted Accepted for backporting to the compiler in the beta channel. label May 2, 2025
bors added a commit to rust-lang-ci/rust that referenced this pull request May 2, 2025
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#140485 (Optimize the codegen for `Span::from_expansion`)
 - rust-lang#140509 (transmutability: merge contiguous runs with a common destination)
 - rust-lang#140519 (Use select in projection lookup in `report_projection_error`)
 - rust-lang#140521 (interpret: better error message for out-of-bounds pointer arithmetic and accesses)
 - rust-lang#140536 (Rename `*Guard::try_map` to `filter_map`.)
 - rust-lang#140550 (Stabilize `select_unpredictable`)
 - rust-lang#140563 (extend the list of registered dylibs on `test::prepare_cargo_test`)
 - rust-lang#140572 (Add useful comments on `ExprKind::If` variants.)
 - rust-lang#140574 (Add regression test for 133065)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit bfb8f73 into rust-lang:master May 3, 2025
6 checks passed
@rustbot rustbot added this to the 1.88.0 milestone May 3, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request May 3, 2025
Rollup merge of rust-lang#140563 - onur-ozkan:extend-dylib-paths, r=jieyouxu

extend the list of registered dylibs on `test::prepare_cargo_test`

self-explanatory

Fixes rust-lang#140299
@cuviper cuviper mentioned this pull request May 3, 2025
@cuviper cuviper removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label May 3, 2025
@cuviper cuviper modified the milestones: 1.88.0, 1.87.0 May 3, 2025
bors added a commit to rust-lang-ci/rust that referenced this pull request May 3, 2025
[beta] backports

- Don't allow flattened format_args in const. rust-lang#139624
- set subsections_via_symbols for ld64 helper sections rust-lang#139752
- Fix detection of `main` function if there are expressions around it rust-lang#140220
- rustdoc: Fix doctest heuristic for main fn wrapping rust-lang#140420
- extend the list of registered dylibs on `test::prepare_cargo_test` rust-lang#140563

r? cuviper
@onur-ozkan onur-ozkan deleted the extend-dylib-paths branch May 3, 2025 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Building Rust with rpath disabled causes ~3k test failures in Cargo
5 participants