Check lifetime parameters when resolving impls; use ty::substs in trans
#14055
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: bootstraps, but not fully tested, so let's see what travis yields. ;) |
|
Travis doesn't like your line lengths: /home/travis/build/mozilla/rust/src/librustc/middle/trans/intrinsic.rs:468: line longer than 100 chars |
… a proper ty::substs struct. This is a holdover from the olden days of yore. This patch removes the last vestiges of that practice. This is part of the work I was doing on rust-lang#5527.
|
Rebased, fixed line lengths. |
|
Travis looks happy. |
bors
pushed a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 28, 2025
changelog: none
`x & 15 == 0` is not equivalent to `x.trailing_zeros() > 4`, as `x =
0b10000` is true for the former and false for the latter.
In fact, clippy itself suggests the following:
```rust
pub fn src(x: i32) -> bool {
x & 15 == 0 // ~error: bit mask could be simplified with a call to `trailing_zeros`
^^^^^^^^^^^ help: try: `x.trailing_zeros() >= 4`
}
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code to use
ty::substsin trans. As part of this, uncovered (and fixed) issue #14050.r? @pcwalton