Move inline asm check to typeck, properly handle aliases #140302

compiler-errors · 2025-04-25T16:17:44Z

Pull InlineAsmCtxt down to rustc_hir_typeck, and instead of using things like Ty::is_copy, use the InferCtxt-aware methods. To fix rust-lang/trait-system-refactor-initiative#189, we also add a try_structurally_resolve_* call to expr_ty.

r? lcnr

rustbot · 2025-04-25T16:17:49Z

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

lcnr · 2025-04-25T16:20:11Z

compiler/rustc_hir_typeck/src/inline_asm.rs

-            infcx,
-            typeck_results,
-        }
+    pub(crate) fn new(def_id: LocalDefId, fcx: &'a FnCtxt<'a, 'tcx>) -> Self {


pls swap argument order

or just recompute the DefId

lcnr

r=me after nits

lcnr · 2025-04-25T17:58:25Z

@bors r+ rollup

bors · 2025-04-25T17:58:27Z

📌 Commit f769f42 has been approved by lcnr

It is now in the queue for this repository.

…lcnr Move inline asm check to typeck, properly handle aliases Pull `InlineAsmCtxt` down to `rustc_hir_typeck`, and instead of using things like `Ty::is_copy`, use the `InferCtxt`-aware methods. To fix rust-lang/trait-system-refactor-initiative#189, we also add a `try_structurally_resolve_*` call to `expr_ty`. r? lcnr

…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#123239 (Implement a lint for implicit autoref of raw pointer dereference - take 2) - rust-lang#140215 (transmutability: Support char, NonZeroXxx) - rust-lang#140226 (Update wasm-component-ld to 0.5.13) - rust-lang#140302 (Move inline asm check to typeck, properly handle aliases) - rust-lang#140317 (Remove redundant check) - rust-lang#140318 (Simply try to unpeel AsyncFnKindHelper goal in `emit_specialized_closure_kind_error`) - rust-lang#140325 (Grammar fixes for BufRead::has_data_left docs) r? `@ghost` `@rustbot` modify labels: rollup

matthiaskrgr · 2025-04-26T12:13:09Z

@bors r-
#140329 (comment)

rustbot · 2025-04-27T21:57:41Z

Some changes occurred in compiler/rustc_codegen_ssa

cc @WaffleLapkin

Some changes occurred in compiler/rustc_codegen_cranelift

cc @bjorn3

compiler-errors · 2025-04-27T22:02:55Z

lmao some branches got crossed 💀

lcnr · 2025-04-28T14:04:39Z

@bors r+ rollup

bors · 2025-04-28T14:04:42Z

📌 Commit 3ab6051 has been approved by lcnr

It is now in the queue for this repository.

…lcnr Move inline asm check to typeck, properly handle aliases Pull `InlineAsmCtxt` down to `rustc_hir_typeck`, and instead of using things like `Ty::is_copy`, use the `InferCtxt`-aware methods. To fix rust-lang/trait-system-refactor-initiative#189, we also add a `try_structurally_resolve_*` call to `expr_ty`. r? lcnr

…enton Rollup of 9 pull requests Successful merges: - rust-lang#139308 (add autodiff inline) - rust-lang#140276 (Do not compute type_of for impl item if impl where clauses are unsatisfied) - rust-lang#140302 (Move inline asm check to typeck, properly handle aliases) - rust-lang#140323 (Implement the internal feature `cfg_target_has_reliable_f16_f128`) - rust-lang#140374 (Resolve instance for SymFn in global/naked asm) - rust-lang#140391 (Rename sub_ptr to offset_from_unsigned in docs) - rust-lang#140394 (Make bootstrap git tests more self-contained) - rust-lang#140396 (Workaround for windows-gnu rust-lld test failure) - rust-lang#140402 (only return nested goals for `Certainty::Yes`) r? `@ghost` `@rustbot` modify labels: rollup

[DO NOT MERGE] bootstrap with `-Znext-solver=globally` A revival of rust-lang#124812. Current status: ~~`./x.py b --stage 2` passes 🎉~~ `try` builds succeed 🎉 🎉 🎉 ~~[top 100 most downloaded crates on crates.io compile](rust-lang#133502 (comment) [top 1000 most downloaded crates on crates.io compile](rust-lang#133502 (comment)) [first perf run](rust-lang#133502 (comment)) 👻 ### in-flight changes - rust-lang#124852, unsure whether I actually want to land this PR for now - rust-lang#139587 - https://github.com/lcnr/rust/tree/opaque-type-method-call - rust-lang#140302 - rust-lang#140276 - rust-lang#140260 - rust-lang#140405 r? `@ghost`

…lcnr Move inline asm check to typeck, properly handle aliases Pull `InlineAsmCtxt` down to `rustc_hir_typeck`, and instead of using things like `Ty::is_copy`, use the `InferCtxt`-aware methods. To fix rust-lang/trait-system-refactor-initiative#189, we also add a `try_structurally_resolve_*` call to `expr_ty`. r? lcnr

…enton Rollup of 10 pull requests Successful merges: - rust-lang#139308 (add autodiff inline) - rust-lang#139656 (Stabilize `slice_as_chunks` library feature) - rust-lang#140022 (allow deref patterns to move out of boxes) - rust-lang#140276 (Do not compute type_of for impl item if impl where clauses are unsatisfied) - rust-lang#140302 (Move inline asm check to typeck, properly handle aliases) - rust-lang#140323 (Implement the internal feature `cfg_target_has_reliable_f16_f128`) - rust-lang#140391 (Rename sub_ptr to offset_from_unsigned in docs) - rust-lang#140394 (Make bootstrap git tests more self-contained) - rust-lang#140396 (Workaround for windows-gnu rust-lld test failure) - rust-lang#140402 (only return nested goals for `Certainty::Yes`) Failed merges: - rust-lang#139765 ([beta] Delay `hash_extract_if` stabilization from 1.87 to 1.88) r? `@ghost` `@rustbot` modify labels: rollup

…enton Rollup of 10 pull requests Successful merges: - rust-lang#139308 (add autodiff inline) - rust-lang#139656 (Stabilize `slice_as_chunks` library feature) - rust-lang#140022 (allow deref patterns to move out of boxes) - rust-lang#140276 (Do not compute type_of for impl item if impl where clauses are unsatisfied) - rust-lang#140302 (Move inline asm check to typeck, properly handle aliases) - rust-lang#140323 (Implement the internal feature `cfg_target_has_reliable_f16_f128`) - rust-lang#140391 (Rename sub_ptr to offset_from_unsigned in docs) - rust-lang#140394 (Make bootstrap git tests more self-contained) - rust-lang#140396 (Workaround for windows-gnu rust-lld test failure) - rust-lang#140402 (only return nested goals for `Certainty::Yes`) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#140302 - compiler-errors:inline_asm-bug, r=lcnr Move inline asm check to typeck, properly handle aliases Pull `InlineAsmCtxt` down to `rustc_hir_typeck`, and instead of using things like `Ty::is_copy`, use the `InferCtxt`-aware methods. To fix rust-lang/trait-system-refactor-initiative#189, we also add a `try_structurally_resolve_*` call to `expr_ty`. r? lcnr

[DO NOT MERGE] bootstrap with `-Znext-solver=globally` A revival of rust-lang#124812. Current status: ~~`./x.py b --stage 2` passes 🎉~~ `try` builds succeed 🎉 🎉 🎉 ~~[top 100 most downloaded crates on crates.io compile](rust-lang#133502 (comment) [top 1000 most downloaded crates on crates.io compile](rust-lang#133502 (comment)) [first perf run](rust-lang#133502 (comment)) 👻 ### in-flight changes - rust-lang#124852, unsure whether I actually want to land this PR for now - rust-lang#139587 - https://github.com/lcnr/rust/tree/opaque-type-method-call - rust-lang#140302 - rust-lang#140276 - rust-lang#140260 - rust-lang#140405 r? `@ghost`

rustbot assigned lcnr Apr 25, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 25, 2025

lcnr reviewed Apr 25, 2025

View reviewed changes

compiler-errors force-pushed the inline_asm-bug branch from 51c0f33 to f769f42 Compare April 25, 2025 16:24

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 25, 2025

jhpratt mentioned this pull request Apr 26, 2025

Rollup of 14 pull requests #140321

Closed

matthiaskrgr mentioned this pull request Apr 26, 2025

Rollup of 7 pull requests #140329

Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 26, 2025

compiler-errors force-pushed the inline_asm-bug branch from f769f42 to 3d7402b Compare April 27, 2025 21:57

compiler-errors force-pushed the inline_asm-bug branch from 3d7402b to f769f42 Compare April 27, 2025 22:03

Move inline_asm to typeck, properly handle aliases

3ab6051

compiler-errors force-pushed the inline_asm-bug branch from f769f42 to 3ab6051 Compare April 27, 2025 22:05

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 28, 2025

lcnr mentioned this pull request Apr 28, 2025

[DO NOT MERGE] bootstrap with -Znext-solver=globally #133502

Draft

ChrisDenton mentioned this pull request Apr 28, 2025

Rollup of 9 pull requests #140411

Closed

ChrisDenton mentioned this pull request Apr 28, 2025

Rollup of 10 pull requests #140414

Closed

ChrisDenton mentioned this pull request Apr 28, 2025

Rollup of 10 pull requests #140415

Merged

bors merged commit 3f5406f into rust-lang:master Apr 29, 2025
6 checks passed

rustbot added this to the 1.88.0 milestone Apr 29, 2025

lcnr mentioned this pull request Apr 29, 2025

inline_asm missing normalization rust-lang/trait-system-refactor-initiative#189

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Move inline asm check to typeck, properly handle aliases #140302

Move inline asm check to typeck, properly handle aliases #140302

compiler-errors commented Apr 25, 2025

rustbot commented Apr 25, 2025

lcnr Apr 25, 2025

lcnr Apr 25, 2025

lcnr left a comment

lcnr commented Apr 25, 2025

bors commented Apr 25, 2025

matthiaskrgr commented Apr 26, 2025

rustbot commented Apr 27, 2025

compiler-errors commented Apr 27, 2025

lcnr commented Apr 28, 2025

bors commented Apr 28, 2025

Move inline asm check to typeck, properly handle aliases #140302

Move inline asm check to typeck, properly handle aliases #140302

Conversation

compiler-errors commented Apr 25, 2025

rustbot commented Apr 25, 2025

lcnr Apr 25, 2025

Choose a reason for hiding this comment

lcnr Apr 25, 2025

Choose a reason for hiding this comment

lcnr left a comment

Choose a reason for hiding this comment

lcnr commented Apr 25, 2025

bors commented Apr 25, 2025

matthiaskrgr commented Apr 26, 2025

rustbot commented Apr 27, 2025

compiler-errors commented Apr 27, 2025

lcnr commented Apr 28, 2025

bors commented Apr 28, 2025