'New Philosophical Tutorial' #14017
'New Philosophical Tutorial' #14017
Conversation
src/doc/guide-syntax.md
Outdated
There was a problem hiding this comment.
Do we want to declare this inside of main? At least explicitly explaining that this is possible would be good.
There was a problem hiding this comment.
Good point. As you can see - not much work on this one - not sure if it will even survive the rethink.
|
Would be nice to wrap lines. |
src/doc/new-tutorial.md
Outdated
There was a problem hiding this comment.
probably should be a space between line and }.
|
I'm excited to see this continue to shape up! |
src/doc/guide-syntax.md
Outdated
There was a problem hiding this comment.
Should we consider using a different word here, given that the word "Conditions" had a prior meaning in the code base that I assume is very different than what is going to be presented in this section? (If you search for "conditions" in the github repository you will see what I mean.) I suppose my concern is if people come to the chat room asking about something they read in this section, and old-timer community members say "we don't have conditions anymore", yielding confusion.
There was a problem hiding this comment.
What's a "condition" in this context?
There was a problem hiding this comment.
"You should s/already// be already familiar"
There was a problem hiding this comment.
I'd actually remove the other one.
src/doc/new-tutorial.md
Outdated
There was a problem hiding this comment.
We should probably refer to box instead of the ~ sigil here.
|
Cheers for the feedback guys - helpful stuff. I think this last commit fixes all the minor issues you've mentioned. I'll work with @nikomatsakis to reword some of the vague memory claims and the Point/Line issue. |
|
Continued in #14190 |
internal: remove `TypeWalk` Because less code is better! `hir_ty::TypeWalk` is only used in analysis-stats and its usage can be replaced by checking `TypeFlags` (which is precomputed upon `TyKind` interning so it should make analysis-stats a bit faster, though it was really negligible in my local environment). We should just use chalk's `TypeVisitor` or `TypeFolder` instead even if we come to need it again.
Hi Guys,
Some work in progress on the new tutorial. Complete direction change from the previous PR - we're now aiming at a 'Rust way of doing things' much more than 'syntax basics'.