Add tests for two untested cases of placeholder relations

[amandasystems]

During work on #130227, I discovered several situations not covered by any previously existing UI test. This commit introudces tests to cover that.

r? lcnr

[lcnr]

@bors delegate+

pls squash to a single commit 😁

[bors]

✌️ @amandasystems, you can now approve this pull request!

If @lcnr told you to "r=me" after making some further change, please make that change, then do @bors r=@lcnr

[amandasystems]

Done!

@bors r=@lcnr

[bors]

📌 Commit 857fe8f has been approved by lcnr

It is now in the queue for this repository.

[matthiaskrgr]

@bors r-

[amandasystems]

Ok, re-blessed that output! No idea why it wouldn't match.

@bors r=@lcnr

[bors]

📌 Commit e9d374c has been approved by lcnr

It is now in the queue for this repository.

[bors]

⌛ Testing commit e9d374c with merge 6bc57c6...

[bors]

☀️ Test successful - checks-actions
Approved by: lcnr
Pushing 6bc57c6 to master...

[github-actions]

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 8bf5a8d (parent) -> 6bc57c6 (this PR)

Test differences

Show 33046 test diffs

Stage 1

• c_str2::cstr_index_from_empty: pass -> [missing] (J0)
• collections::btree::map::tests::test_cursor_mut_insert_before_2: pass -> [missing] (J0)
• collections::btree::map::tests::test_extend_ref: pass -> [missing] (J0)
• collections::hash::map::tests::test_iterate: pass -> [missing] (J0)
• f32::test_next_up: pass -> [missing] (J0)
• f64::test_round: pass -> [missing] (J0)
• io::stdio::tests::stdout_unwind_safe: pass -> [missing] (J0)
• iter::adapters::filter::test_next_chunk_does_not_leak: pass -> [missing] (J0)
• iter::adapters::zip::test_zip_nth_back_side_effects_exhausted: pass -> [missing] (J0)
• iter::test_monad_laws_associativity: pass -> [missing] (J0)
• iter::traits::double_ended::test_rev_rposition: pass -> [missing] (J0)
• num::bignum::test_add_small: pass -> [missing] (J0)
• num::dec2flt::parse::valid: pass -> [missing] (J0)
• num::i16::test_next_multiple_of: pass -> [missing] (J0)
• num::ops::test_add_defined: pass -> [missing] (J0)
• num::test_try_i64i64: pass -> [missing] (J0)
• num::test_try_i8usize: pass -> [missing] (J0)
• num::u16::test_div_ceil: pass -> [missing] (J0)
• ptr::test_const_swap_ptr: pass -> [missing] (J0)
• slice::memchr::matches_one: pass -> [missing] (J0)
• slice::test_move_rev_iterator: pass -> [missing] (J0)
• slice::test_rposition: pass -> [missing] (J0)
• str::pattern::str_searcher_empty_needle_multibyte_haystack::bwd: pass -> [missing] (J0)
• sys_common::wtf8::tests::wtf8_to_ascii_lowercase: pass -> [missing] (J0)
• vec_deque::test_drop_with_pop: pass -> [missing] (J0)
• ascii::is_ascii::short::case02_align_to: pass -> [missing] (J1)
• fs::tests::recursive_mkdir_dot: pass -> [missing] (J1)
• num::bench_u16_from_str_radix_2: pass -> [missing] (J1)
• num::int_log::u64_log10_random: pass -> [missing] (J1)
• slice::sort_small_big: pass -> [missing] (J1)
• clean::cfg::tests::test_parse_ok: pass -> [missing] (J2)
• errors::verify_ast_lowering_default_field_in_tuple_0: pass -> [missing] (J2)
• errors::verify_builtin_macros_env_not_defined_55: pass -> [missing] (J2)
• errors::verify_incremental_no_path_4: pass -> [missing] (J2)
• errors::verify_metadata_no_multiple_global_alloc_46: pass -> [missing] (J2)
• errors::verify_session_file_is_not_writeable_28: pass -> [missing] (J2)
• errors::verify_trait_selection_no_value_in_rustc_on_unimplemented_12: pass -> [missing] (J2)
• graph::scc::tests::test_bug_max_zero_stick_shape: pass -> [missing] (J2)
• owned_slice::tests::slice_owned_the_slice: pass -> [missing] (J2)
• parser::tests::multiline_notes: pass -> [missing] (J2)
• spec::tests::riscv64_linux_android: pass -> [missing] (J2)
• tests::bench_copy: pass -> [missing] (J2)
• mem::size_of_32: pass -> [missing] (J3)
• sort::tests::stable::deterministic_string_random: ignore -> [missing] (J4)
• sort::tests::unstable::correct_u64_random_d20: ignore -> [missing] (J4)
• sort::tests::unstable::self_cmp_i32_saw_mixed: ignore -> [missing] (J4)

Stage 2

• collections::binary_heap::test_into_iter_sorted_collect: [missing] -> pass (J0)
• error_with_backtrace_outputs_correctly_with_one_source: [missing] -> pass (J0)
• f64::test_is_normal: [missing] -> pass (J0)
• ffi::os_str::tests::slice_invalid_edge: [missing] -> pass (J0)
• ffi::os_str::tests::test_os_string_with_capacity: [missing] -> pass (J0)
• io::cursor::tests::test_mem_mut_writer: [missing] -> pass (J0)
• iter::adapters::skip::test_skip_nth_back: [missing] -> pass (J0)
• mpsc_sync::drop_unreceived: [missing] -> pass (J0)
• num::i64::test_carrying_mul: [missing] -> pass (J0)
• num::u128::test_pow: [missing] -> pass (J0)
• num::u16::test_count_ones: [missing] -> pass (J0)
• num::u64::test_pow: [missing] -> pass (J0)
• ops::test_bound_cloned_included: [missing] -> pass (J0)
• rc::test_into_from_weak_raw_unsized: [missing] -> pass (J0)
• slice::test_array_chunks_mut_remainder: [missing] -> pass (J0)
• sort::tests::stable::panic_retain_orig_set_i32_random_z1: [missing] -> pass (J0)
• sort::tests::unstable::correct_1k_random_z1: [missing] -> pass (J0)
• sync::test_from_box_slice: [missing] -> pass (J0)
• sys_common::wtf8::tests::wtf8_as_str: [missing] -> pass (J0)
• test_with_extension: [missing] -> pass (J0)
• thread_local_containing_const_statements: [missing] -> pass (J0)
• vec::from_into_inner: [missing] -> pass (J0)
• vec::test_box_zero_allocator: [missing] -> pass (J0)
• vec::test_dedup_by: [missing] -> pass (J0)
• vec::test_from_iter_specialization_panic_during_iteration_drops: [missing] -> pass (J0)
• vec_deque::test_param_int: [missing] -> pass (J0)
• ascii::long::case13_subtract_shifted_bool_match_range: [missing] -> pass (J1)
• btree::set::intersection_10k_neg_vs_100_pos: [missing] -> pass (J1)
• fs::tests::file_lock_drop: [missing] -> pass (J1)
• hash::map::find_existing: [missing] -> pass (J1)
• num::bench_i8_from_str_radix_36: [missing] -> pass (J1)
• os::unix::net::tests::datagram_pair: [missing] -> pass (J1)
• slice::swap_with_slice_u8_3000: [missing] -> pass (J1)
• sort::tests::stable::panic_observable_is_less_random_d2: [missing] -> pass (J1)
• str::find_underscore_char::short_mixed: [missing] -> pass (J1)
• string::bench_exact_size_shrink_to_fit: [missing] -> pass (J1)
• string::from_utf8_lossy_100_ascii: [missing] -> pass (J1)
• error_reporting::traits::on_unimplemented::verify_trait_selection_missing_options_for_on_unimplemented_attr_1: [missing] -> pass (J2)
• errors::verify_codegen_ssa_invalid_monomorphization_float_to_int_unchecked_91: [missing] -> pass (J2)
• errors::verify_codegen_ssa_invalid_monomorphization_simd_argument_95: [missing] -> pass (J2)
• errors::verify_incremental_hard_link_failed_25: [missing] -> pass (J2)
• errors::verify_parse_fn_pointer_cannot_be_async_126: [missing] -> pass (J2)
• errors::verify_parse_invalid_attr_unsafe_162: [missing] -> pass (J2)
• errors::verify_passes_allow_incoherent_impl_51: [missing] -> pass (J2)
• errors::verify_session_apple_deployment_target_too_low_1: [missing] -> pass (J2)
• errors::verify_session_embed_source_insufficient_dwarf_version_22: [missing] -> pass (J2)
• graph::vec_graph::tests::num_nodes: [missing] -> pass (J2)
• parser::tests::minimum_depth: [missing] -> pass (J2)
• spec::tests::armv7s_apple_ios: [missing] -> pass (J2)
• tests::test_unstable_options_tracking_hash: [missing] -> pass (J2)
• os::net::linux_ext::tests::deferaccept: [missing] -> pass (J3)
• sort::tests::unstable::correct_dyn_val_saw_mixed: [missing] -> ignore (J4)
• sort::tests::unstable::self_cmp_cell_i32_random_d20: [missing] -> ignore (J4)
• task::test_waker_will_wake_clone: [missing] -> ignore (J4)

(and 16430 additional test diffs)

Additionally, 16516 doctest diffs were found. These are ignored, as they are noisy.

Job group index

• J0: aarch64-apple, test-various, x86_64-apple-1, x86_64-gnu-aux
• J1: aarch64-apple, test-various, x86_64-apple-1
• J2: aarch64-apple, x86_64-apple-1
• J3: test-various
• J4: x86_64-gnu-aux

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 6bc57c6bf7d0024ad9ea5a2c112f3fc9c383c8a4 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

1. x86_64-apple-2: 5488.8s -> 1578.6s (-71.2%)
2. dist-aarch64-linux: 5378.6s -> 8529.2s (58.6%)
3. test-various: 4111.1s -> 2342.0s (-43.0%)
4. x86_64-apple-1: 8252.8s -> 5026.4s (-39.1%)
5. x86_64-gnu-aux: 6046.9s -> 4222.5s (-30.2%)
6. aarch64-apple: 4320.5s -> 3020.4s (-30.1%)
7. dist-apple-various: 7932.1s -> 5919.0s (-25.4%)
8. dist-x86_64-apple: 9279.8s -> 10610.8s (14.3%)
9. aarch64-gnu-debug: 4239.4s -> 4019.6s (-5.2%)
10. i686-msvc-2: 6959.1s -> 7269.8s (4.5%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

[rust-timer]

Finished benchmarking commit (6bc57c6): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 2.3%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	3.3%	[1.8%, 6.0%]	3
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.8%	[-0.8%, -0.8%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	2.3%	[-0.8%, 6.0%]	4

Cycles

Results (primary 0.5%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.5%	[0.5%, 0.5%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.5%	[0.5%, 0.5%]	1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 776.303s -> 774.196s (-0.27%)
Artifact size: 365.05 MiB -> 365.08 MiB (0.01%)