Add `target_env = "macabi"` and `target_env = "sim"` #139451

madsmtm · 2025-04-06T14:28:33Z

RFC 2992 (tracking issue) introduced cfg(target_abi = ...) with the original motivation being Mac Catalyst and Apple Simulator targets. These do not actually have a changed calling convention in the same sense that e.g. cfg(target_abi = "eabihf") or pointer authentication (arm64e) does, see #133331.

Specifically, for Apple Simulator targets, the binary runs under the following conditions:

Runs with the host macOS kernel (but in a mode configured for iOS/tvOS/...).
Uses frameworks for the specific simulator version being targetted.
System file accesses need to be made relative to the IPHONE_SIMULATOR_ROOT environment variable.
Uses host GPUs directly.

And for Mac Catalyst:

Runs with the host macOS kernel (but in a mode configured for iOS).
Uses mostly host macOS frameworks (though with a few things changed, e.g. the NSImageResizingModeStretch enum has a different value).
Uses host GPUs, camera and other peripherals directly.

As can be seen, these seem better suited as target_envs, since it really is the environment that the binary is running under that's changed (regardless of the Mac Catalyst "macabi" having "abi" in the name). So this PR adds target_env = "sim" and target_env = "macabi", with the idea of possibly deprecating target_abi = "sim" and target_abi = "macabi" in the far future.

This affects iOS Tier 2 targets (aarch64-apple-ios-sim, x86_64-apple-ios, aarch64-apple-ios-macabi and x86_64-apple-ios-macabi), and probably needs a compiler FCP.

Fixes #133331.
Reference PR: rust-lang/reference#1781.
Cargo doc PR: rust-lang/cargo#15404.

r? compiler
CC @workingjubilee
CC target maintainers @deg4uss3r @thomcc @badboy @BlackHoleFox @madsmtm @agg23

rustbot · 2025-04-06T14:28:41Z

These commits modify compiler targets.
(See the Target Tier Policy.)

Some changes occurred in src/doc/rustc/src/platform-support

cc @Noratrieb

Some changes occurred in compiler/rustc_codegen_ssa

cc @WaffleLapkin

Some changes occurred in src/tools/compiletest

cc @jieyouxu

compiler/rustc_target/src/spec/base/apple/tests.rs

`target_abi = "sim"` may be deprecated in the future. See rust-lang/rust#139451.

SparrowLii

It looks fine, but I'm not familar with target options so
r? @workingjubilee since this is from #133331

workingjubilee · 2025-04-08T22:42:43Z

Hm. Reviewing https://github.com/rust-lang/rust-forge/blob/master/src/compiler/proposals-and-stabilization.md#targets this is an unspecified case for approving changes to targets, cc @davidtwco and @wesleywiser

But it is user-facing, I suppose, so an FCP does make sense. Tentatively applying labels assuming that is correct.

apiraino · 2025-04-10T09:40:42Z

I'm also not very familiar with target options but I feel that target_env = "sim" is a bit generic. Would it make sense something that says more explicitly that this is an Apple thing? Example target_env = "ios-sim" or something along this line?

wesleywiser · 2025-04-10T14:17:04Z

Yes, I think an FCP is appropriate for this change.

@rfcbot fcp merge

rfcbot · 2025-04-10T14:17:07Z

madsmtm · 2025-08-06T11:16:44Z

Rebased

@rustbot ready

wesleywiser · 2025-08-08T01:43:47Z

@bors r+

bors · 2025-08-08T01:43:50Z

📌 Commit 1d22c37 has been approved by wesleywiser

It is now in the queue for this repository.

bors · 2025-08-08T09:58:27Z

☔ The latest upstream changes (presumably #145077) made this pull request unmergeable. Please resolve the merge conflicts.

madsmtm · 2025-08-08T11:50:56Z

Rebased (conflict was in tests/ui/check-cfg/well-known-values.stderr).

@bors r=wesleywiser

bors · 2025-08-08T11:50:58Z

📌 Commit d434cae has been approved by wesleywiser

It is now in the queue for this repository.

Rollup of 8 pull requests Successful merges: - #139451 (Add `target_env = "macabi"` and `target_env = "sim"`) - #144039 (Use `tcx.short_string()` in more diagnostics) - #144192 (atomicrmw on pointers: move integer-pointer cast hacks into backend) - #144545 (In rustc_pattern_analysis, put `true` witnesses before `false` witnesses) - #144579 (Implement declarative (`macro_rules!`) attribute macros (RFC 3697)) - #144649 (Account for bare tuples and `Pin` methods in field searching logic) - #144775 (more strongly dissuade use of `skip_binder`) - #144987 (Enable f16 and f128 on targets that were fixed in LLVM21) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #139451 - madsmtm:apple-target-env-abi, r=wesleywiser Add `target_env = "macabi"` and `target_env = "sim"` [RFC 2992](rust-lang/rfcs#2992) ([tracking issue](#80970)) introduced `cfg(target_abi = ...)` with the original motivation being Mac Catalyst and Apple Simulator targets. These do not actually have a changed calling convention in the same sense that e.g. `cfg(target_abi = "eabihf")` or pointer authentication (`arm64e`) does, see #133331. Specifically, for Apple Simulator targets, the binary runs under the following conditions: - Runs with the host macOS kernel (but in a mode configured for iOS/tvOS/...). - Uses frameworks for the specific simulator version being targetted. - System file accesses need to be made relative to the `IPHONE_SIMULATOR_ROOT` environment variable. - Uses host GPUs directly. And for Mac Catalyst: - Runs with the host macOS kernel (but in a mode configured for iOS). - Uses mostly host macOS frameworks (though with a few things changed, e.g. the [`NSImageResizingModeStretch`](https://developer.apple.com/documentation/appkit/nsimage/resizingmode-swift.enum/stretch?language=objc) enum has a different value). - Uses host GPUs, camera and other peripherals directly. As can be seen, these seem better suited as `target_env`s, since it really is the environment that the binary is running under that's changed (regardless of the Mac Catalyst "macabi" having "abi" in the name). So this PR adds `target_env = "sim"` and `target_env = "macabi"`, with the idea of possibly deprecating `target_abi = "sim"` and `target_abi = "macabi"` in the far future. This affects iOS Tier 2 targets (`aarch64-apple-ios-sim`, `x86_64-apple-ios`, `aarch64-apple-ios-macabi` and `x86_64-apple-ios-macabi`), and probably needs a compiler FCP. Fixes #133331. Reference PR: rust-lang/reference#1781. Cargo doc PR: rust-lang/cargo#15404. r? compiler CC `@workingjubilee` CC target maintainers `@deg4uss3r` `@thomcc` `@badboy` `@BlackHoleFox` `@madsmtm` `@agg23`

Rollup of 8 pull requests Successful merges: - rust-lang/rust#139451 (Add `target_env = "macabi"` and `target_env = "sim"`) - rust-lang/rust#144039 (Use `tcx.short_string()` in more diagnostics) - rust-lang/rust#144192 (atomicrmw on pointers: move integer-pointer cast hacks into backend) - rust-lang/rust#144545 (In rustc_pattern_analysis, put `true` witnesses before `false` witnesses) - rust-lang/rust#144579 (Implement declarative (`macro_rules!`) attribute macros (RFC 3697)) - rust-lang/rust#144649 (Account for bare tuples and `Pin` methods in field searching logic) - rust-lang/rust#144775 (more strongly dissuade use of `skip_binder`) - rust-lang/rust#144987 (Enable f16 and f128 on targets that were fixed in LLVM21) r? `@ghost` `@rustbot` modify labels: rollup

rustbot assigned SparrowLii Apr 6, 2025

madsmtm force-pushed the apple-target-env-abi branch from b42ca5f to 0245efb Compare April 6, 2025 14:29

This comment has been minimized.

Sign in to view

madsmtm force-pushed the apple-target-env-abi branch from 0245efb to 8a2104f Compare April 6, 2025 15:16

This was referenced Apr 6, 2025

Add target_env = "macabi" and target_env = "sim" rust-lang/reference#1781

Open

docs(ref): Use better example value in CARGO_CFG_TARGET_ABI rust-lang/cargo#15404

Merged

This comment has been minimized.

Sign in to view

madsmtm force-pushed the apple-target-env-abi branch from 8a2104f to 8ab20f3 Compare April 6, 2025 15:41

BlackHoleFox reviewed Apr 6, 2025

View reviewed changes

compiler/rustc_target/src/spec/base/apple/tests.rs Outdated Show resolved Hide resolved

madsmtm force-pushed the apple-target-env-abi branch from 8ab20f3 to bb4d1b1 Compare April 6, 2025 23:43

github-merge-queue bot pushed a commit to rust-lang/cargo that referenced this pull request Apr 6, 2025

docs(ref): Use better example value in CARGO_CFG_TARGET_ABI (#15404)

c7be060

`target_abi = "sim"` may be deprecated in the future. See rust-lang/rust#139451.

BlackHoleFox approved these changes Apr 7, 2025

View reviewed changes

SparrowLii reviewed Apr 7, 2025

View reviewed changes

rustbot assigned workingjubilee and unassigned SparrowLii Apr 7, 2025

rfcbot added the proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. label Apr 10, 2025

apiraino removed the to-announce Announce this issue on triage meeting label Jul 24, 2025

madsmtm force-pushed the apple-target-env-abi branch from 8be24de to 1d22c37 Compare August 6, 2025 10:59

rustbot added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Aug 6, 2025

madsmtm removed the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Aug 6, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 6, 2025

wesleywiser approved these changes Aug 8, 2025

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 8, 2025

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 8, 2025

Add target_env = "macabi" and target_env = "sim"

d434cae

madsmtm force-pushed the apple-target-env-abi branch from 1d22c37 to d434cae Compare August 8, 2025 11:50

rustbot added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Aug 8, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 8, 2025

madsmtm removed the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Aug 8, 2025

tgross35 mentioned this pull request Aug 8, 2025

Rollup of 8 pull requests #145126

Merged

bors merged commit 6674fe2 into rust-lang:master Aug 9, 2025
10 checks passed

rustbot added this to the 1.91.0 milestone Aug 9, 2025

madsmtm deleted the apple-target-env-abi branch August 9, 2025 11:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add `target_env = "macabi"` and `target_env = "sim"` #139451

Add `target_env = "macabi"` and `target_env = "sim"` #139451

madsmtm commented Apr 6, 2025 •

edited

Loading

Uh oh!

rustbot commented Apr 6, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

Uh oh!

SparrowLii left a comment •

edited

Loading

Uh oh!

workingjubilee commented Apr 8, 2025 •

edited

Loading

Uh oh!

apiraino commented Apr 10, 2025 •

edited

Loading

Uh oh!

wesleywiser commented Apr 10, 2025

Uh oh!

rfcbot commented Apr 10, 2025 •

edited by spastorino

Loading

Uh oh!

madsmtm commented Aug 6, 2025

Uh oh!

wesleywiser commented Aug 8, 2025

Uh oh!

bors commented Aug 8, 2025

Uh oh!

bors commented Aug 8, 2025

Uh oh!

madsmtm commented Aug 8, 2025

Uh oh!

bors commented Aug 8, 2025

Uh oh!

Uh oh!

Uh oh!

Add target_env = "macabi" and target_env = "sim" #139451

Add target_env = "macabi" and target_env = "sim" #139451

Conversation

madsmtm commented Apr 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Apr 6, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

Uh oh!

SparrowLii left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

workingjubilee commented Apr 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

apiraino commented Apr 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wesleywiser commented Apr 10, 2025

Uh oh!

rfcbot commented Apr 10, 2025 • edited by spastorino Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

madsmtm commented Aug 6, 2025

Uh oh!

wesleywiser commented Aug 8, 2025

Uh oh!

bors commented Aug 8, 2025

Uh oh!

bors commented Aug 8, 2025

Uh oh!

madsmtm commented Aug 8, 2025

Uh oh!

bors commented Aug 8, 2025

Uh oh!

Uh oh!

Uh oh!

Add `target_env = "macabi"` and `target_env = "sim"` #139451

Add `target_env = "macabi"` and `target_env = "sim"` #139451

madsmtm commented Apr 6, 2025 •

edited

Loading

SparrowLii left a comment •

edited

Loading

workingjubilee commented Apr 8, 2025 •

edited

Loading

apiraino commented Apr 10, 2025 •

edited

Loading

rfcbot commented Apr 10, 2025 •

edited by spastorino

Loading