Skip to content

Conversation

Zoxc
Copy link
Contributor

@Zoxc Zoxc commented Apr 2, 2025

This changes the unique session hash used to ensure unique anon dep nodes per session from a timestamp to a counter.

This is nicer for debugging as it makes the dep graph deterministic.

@rustbot
Copy link
Collaborator

rustbot commented Apr 2, 2025

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 2, 2025
@davidtwco
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Apr 16, 2025

📌 Commit 027251f has been approved by davidtwco

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 16, 2025
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Apr 16, 2025
Use a session counter to make anon dep nodes unique

This changes the unique session hash used to ensure unique anon dep nodes per session from a timestamp to a counter.

This is nicer for debugging as it makes the dep graph deterministic.
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 17, 2025
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#139084 (hygiene: Rename semi-transparent to semi-opaque)
 - rust-lang#139236 (Use a session counter to make anon dep nodes unique)
 - rust-lang#139650 (Fix `register_group_alias` for tools)
 - rust-lang#139770 (Rename `LifetimeName` as `LifetimeKind`.)
 - rust-lang#139846 (Remove `kw::Empty` uses in rustdoc)
 - rust-lang#139891 (Include optional dso_local marker for functions in `enum-match.rs`)
 - rust-lang#139908 (parser: Remove old diagnostic notes for type ascription syntax)
 - rust-lang#139917 (fix for multiple `#[repr(align(N))]` on functions)

Failed merges:

 - rust-lang#139615 (Remove `name_or_empty`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 844b7c7 into rust-lang:master Apr 17, 2025
6 checks passed
@rustbot rustbot added this to the 1.88.0 milestone Apr 17, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Apr 17, 2025
Rollup merge of rust-lang#139236 - Zoxc:anon-counter, r=davidtwco

Use a session counter to make anon dep nodes unique

This changes the unique session hash used to ensure unique anon dep nodes per session from a timestamp to a counter.

This is nicer for debugging as it makes the dep graph deterministic.
@Zoxc Zoxc deleted the anon-counter branch April 17, 2025 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants