Add serialization support for StrBuf #13875
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
hjr3
commented
May 1, 2014
hjr3
commented
- implement Encodable and Decodable for StrBuf
- implement to_json for StrBuf
| @@ -2205,6 +2205,10 @@ impl ToJson for ~str { | |||
| fn to_json(&self) -> Json { String((*self).clone()) } | |||
| } | |||
|
|
|||
| impl ToJson for StrBuf { | |||
| fn to_json(&self) -> Json { String((*self).clone().into_owned()) } | |||
There was a problem hiding this comment.
Writing String((*self).as_slice().into_owned()) will be more efficient.
|
Thanks; looks pretty good, just a few small comments. |
- implement Encodable and Decodable for StrBuf - implement to_json for StrBuf
|
appreciate the feedback. all fixed up |
|
@alexcrichton does this need to be rescheduled? |
|
It does indeed! Our windows bots have been a little cranky recently... |
bors
added a commit
that referenced
this pull request
May 1, 2014
- implement Encodable and Decodable for StrBuf - implement to_json for StrBuf
arcnmx
pushed a commit
to arcnmx/rust
that referenced
this pull request
Jan 9, 2023
Diagnose private assoc item accesses
flip1995
added a commit
to flip1995/rust
that referenced
this pull request
Dec 26, 2024
`Ty.kind()` is a method. changelog: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.