Rollup of 8 pull requests #136684
Merged
Rollup of 8 pull requests #136684
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit cf34545. That commit led to a regression of rust-lang#132185 . So my analysis that the problem lay in FreeBSD 13.2's specific LLVM version was clearly wrong. Revert that commit until we can figure out the real root cause. Fixes rust-lang#132185
rustc_target has had a lot of weird reexports for various reasons, but now we're at a point where we can actually start reducing their number. We remove weird shadowing-dependent behavior and import directly from rustc_abi instead of doing weird renaming imports. This is only incremental progress and does not entirely fix the crate.
General housekeeping: - Use less reexports from its rustc_target era - Unify some imports as a result - Split the Reg(ister) types into their own files Generally moving stuff around because it makes the crate more consistent.
only check the caller + disallow caller having the attr.
…, r=compiler-errors fix tail call checks wrt `#[track_caller]` Only check the caller + disallow caller having the attribute. fixes rust-lang#134336 r? `@compiler-errors` <sub>apparently there were no tests for `#[track_caller]` before... ooops</sub>
compiler: replace few consts arrays with statics to remove const dupes Locally on `x86_64-pc-windows-msvc` -100kb for `rustc_driver.dll`
…, r=compiler-errors compiler: Clean up weird `rustc_abi` reexports Just general cleanup in `rustc_target` and `rustc_abi`. I was originally going to make a PR with a larger change that also fixed the last few crates and in doing so removed some clutter from `rustc_abi`, but wound up slightly stuck on it, then figured out how to fix it, and then got distracted by other things... so now I'm trying to figure out what I had figured out earlier.
Revert "CI: build FreeBSD artifacts on FreeBSD 13.4" This reverts commit cf34545. That commit led to a regression of rust-lang#132185 . So my analysis that the problem lay in FreeBSD 13.2's specific LLVM version was clearly wrong. Revert that commit until we can figure out the real root cause. Fixes rust-lang#132185 try-job: dist-x86_64-freebsd try-job: dist-various-2
…r, r=compiler-errors MIR validation: add comment explaining the limitations of CfgChecker I hope this right but I am not sure.^^ Cc `@compiler-errors` `@lcnr` `@cjgillot` `@oli-obk`
…u-se
Stabilise `Cursor::{get_mut, set_position}` in `const` scenarios.
Closes: rust-lang#130801
This PR stabilises the `const_mut_cursor` feature gate.
…r=fmease ping me for attribute-related changes r? `@fmease`
…rgau Add `rustc_hir_pretty::item_to_string` function Another one needed for rustdoc. :) r? `@Urgau`
rustbot
added
A-meta
|
@bors r+ rollup=never p=8 |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
📌 Perf builds for each rolled up PR:
previous master: 5ff18d0eae In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
This was referenced Feb 7, 2025
|
Finished benchmarking commit (64e06c0): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (primary -2.2%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 777.403s -> 779.143s (0.22%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
#[track_caller]#135973 (fix tail call checks wrt#[track_caller])rustc_abireexports #136565 (compiler: Clean up weirdrustc_abireexports)Cursor::{get_mut, set_position}inconstscenarios. #136634 (StabiliseCursor::{get_mut, set_position}inconstscenarios.)rustc_hir_pretty::item_to_stringfunction #136644 (Addrustc_hir_pretty::item_to_stringfunction)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup