Skip to content

Conversation

momvart
Copy link
Contributor

@momvart momvart commented Jan 28, 2025

Following #134130, this brings back the ability to mutate AST before lowering.

@rustbot
Copy link
Collaborator

rustbot commented Jan 28, 2025

r? @fmease

rustbot has assigned @fmease.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-rustc-dev-guide Area: rustc-dev-guide S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 28, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jan 28, 2025

The rustc-dev-guide subtree was changed. If this PR only touches the dev guide consider submitting a PR directly to rust-lang/rustc-dev-guide otherwise thank you for updating the dev guide with your changes.

cc @BoxyUwU, @jieyouxu, @Kobzol

@momvart
Copy link
Contributor Author

momvart commented Jan 28, 2025

r? @bjorn3

@rustbot rustbot assigned bjorn3 and unassigned fmease Jan 28, 2025
@bjorn3
Copy link
Member

bjorn3 commented Jan 29, 2025

@bors r+ rollup=maybe

@bors
Copy link
Collaborator

bors commented Jan 29, 2025

📌 Commit 5dfe0f8 has been approved by bjorn3

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 29, 2025
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 29, 2025
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#133382 (Suggest considering casting fn item as fn pointer in more cases)
 - rust-lang#136092 (Test pipes also when not running on Windows and Linux simultaneously)
 - rust-lang#136190 (Remove duplicated code in RISC-V asm bad-reg test)
 - rust-lang#136192 (ci: remove unused windows runner)
 - rust-lang#136205 (Properly check that array length is valid type during built-in unsizing in index)
 - rust-lang#136211 (Update mdbook to 0.4.44)
 - rust-lang#136212 (Tweak `&mut self` suggestion span)
 - rust-lang#136214 (Make crate AST mutation accessible for driver callback)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit c941b1c into rust-lang:master Jan 29, 2025
6 checks passed
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jan 29, 2025
Rollup merge of rust-lang#136214 - momvart:driver_callback_crate_mut, r=bjorn3

Make crate AST mutation accessible for driver callback

Following  rust-lang#134130, this brings back the ability to mutate AST before lowering.
@rustbot rustbot added this to the 1.86.0 milestone Jan 29, 2025
github-actions bot pushed a commit to tautschnig/verify-rust-std that referenced this pull request Mar 11, 2025
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#133382 (Suggest considering casting fn item as fn pointer in more cases)
 - rust-lang#136092 (Test pipes also when not running on Windows and Linux simultaneously)
 - rust-lang#136190 (Remove duplicated code in RISC-V asm bad-reg test)
 - rust-lang#136192 (ci: remove unused windows runner)
 - rust-lang#136205 (Properly check that array length is valid type during built-in unsizing in index)
 - rust-lang#136211 (Update mdbook to 0.4.44)
 - rust-lang#136212 (Tweak `&mut self` suggestion span)
 - rust-lang#136214 (Make crate AST mutation accessible for driver callback)

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rustc-dev-guide Area: rustc-dev-guide S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants