Skip to content

Enable sanitizers on MSVC CI jobs #136155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 11, 2025
Merged

Conversation

tmiasko
Copy link
Contributor

@tmiasko tmiasko commented Jan 27, 2025

Previously MSVC CI would ignore all tests annotated with needs-sanitizer-support header.

Previously MSVC CI would ignore all tests annotated with needs-sanitizer-support header.
@rustbot
Copy link
Collaborator

rustbot commented Jan 27, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Jan 27, 2025
@tmiasko
Copy link
Contributor Author

tmiasko commented Jan 27, 2025

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 27, 2025
Enable sanitizers on MSVC CI jobs

Previously MSVC CI would ignore all tests annotated with needs-sanitizer-support header.

try-jobs: i686-msvc-1
try-jobs: i686-msvc-2
try-job: x86_64-msvc-1
try-job: x86_64-msvc-2
@bors
Copy link
Collaborator

bors commented Jan 27, 2025

⌛ Trying commit 1ba2153 with merge a92c3c2...

@bors
Copy link
Collaborator

bors commented Jan 27, 2025

☀️ Try build successful - checks-actions
Build commit: a92c3c2 (a92c3c2c9b04ac8193bd22d16e268abaf0ec8c63)

@tmiasko
Copy link
Contributor Author

tmiasko commented Jan 27, 2025

i686-msvc-1, i686-msvc-2:
@bors try

@bors
Copy link
Collaborator

bors commented Jan 27, 2025

⌛ Trying commit 1ba2153 with merge 75c98e7...

bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 27, 2025
Enable sanitizers on MSVC CI jobs

Previously MSVC CI would ignore all tests annotated with needs-sanitizer-support header.

try-job: i686-msvc-1
try-job: i686-msvc-2
@tmiasko tmiasko marked this pull request as ready for review January 27, 2025 23:56
@bors
Copy link
Collaborator

bors commented Jan 28, 2025

☀️ Try build successful - checks-actions
Build commit: 75c98e7 (75c98e70dddf7384016c285910e91e7f472aad3c)

@Mark-Simulacrum
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Feb 9, 2025

📌 Commit 1ba2153 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 9, 2025
jhpratt added a commit to jhpratt/rust that referenced this pull request Feb 10, 2025
…Mark-Simulacrum

Enable sanitizers on MSVC CI jobs

Previously MSVC CI would ignore all tests annotated with needs-sanitizer-support header.
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Feb 10, 2025
…Mark-Simulacrum

Enable sanitizers on MSVC CI jobs

Previously MSVC CI would ignore all tests annotated with needs-sanitizer-support header.
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 10, 2025
…kingjubilee

Rollup of 9 pull requests

Successful merges:

 - rust-lang#134626 (Add Four Codegen Tests)
 - rust-lang#135408 (x86: make SSE2 required for i686 hardfloat targets and use it to pass SIMD types)
 - rust-lang#136155 (Enable sanitizers on MSVC CI jobs)
 - rust-lang#136419 (adding autodiff tests)
 - rust-lang#136603 (compiler: gate `extern "{abi}"` in ast_lowering)
 - rust-lang#136628 (ci: upgrade to crosstool-ng 1.27.0)
 - rust-lang#136714 (Update `compiler-builtins` to 0.1.146)
 - rust-lang#136731 (rustc_middle: parallel: TyCtxt: remove "unsafe impl DynSend/DynSync")
 - rust-lang#136761 (tests: `-Copt-level=3` instead of `-O` in codegen tests)

r? `@ghost`
`@rustbot` modify labels: rollup
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Feb 10, 2025
…Mark-Simulacrum

Enable sanitizers on MSVC CI jobs

Previously MSVC CI would ignore all tests annotated with needs-sanitizer-support header.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Feb 10, 2025
…Mark-Simulacrum

Enable sanitizers on MSVC CI jobs

Previously MSVC CI would ignore all tests annotated with needs-sanitizer-support header.
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 11, 2025
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#136107 (Introduce CoercePointeeWellformed for coherence checks at typeck stage)
 - rust-lang#136155 (Enable sanitizers on MSVC CI jobs)
 - rust-lang#136524 (Delay bug when method confirmation cannot upcast object pick of self)
 - rust-lang#136584 (Prevent generic pattern types from being used in libstd)
 - rust-lang#136603 (compiler: gate `extern "{abi}"` in ast_lowering)
 - rust-lang#136821 (assign marcoieni and jdno to infra-ci PRs)
 - rust-lang#136825 (Update books)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 7b49049 into rust-lang:master Feb 11, 2025
7 checks passed
@rustbot rustbot added this to the 1.86.0 milestone Feb 11, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Feb 11, 2025
Rollup merge of rust-lang#136155 - tmiasko:msvc-enable-sanitizers, r=Mark-Simulacrum

Enable sanitizers on MSVC CI jobs

Previously MSVC CI would ignore all tests annotated with needs-sanitizer-support header.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants