tests: Port `translation` to rmake.rs #135818

jieyouxu · 2025-01-21T13:23:31Z

Part of #121876.

This PR partially supersedes #129011 and is co-authored with @Oneirical.

Summary

This PR ports tests/run-make/translation to rmake.rs. Notable changes from the Makefile version include:

We now actually fail if the rustc invocations fail... The Makefile did not have SHELL=/bin/bash -o pipefail, so all the piped rustc invocations to grep vacuously succeeded, even if the broken ftl test case actually regressed over time and ICEs on current master.
- That test case is converted to assert it fails with a FIXME backlinking to -Ztranslate-additional-ftl for a broken fluent bundle with stray interpolation argument unexpectedly ICEs #135817.
The test coverage is expanded to not ignore windows. Instead, the test now uses symlink capability detection to gate test execution.
Added some backlinks to relevant tracking issues and the initial translation infra implementation PR.

Review advice

Best reviewed commit-by-commit.

r? compiler

try-job: aarch64-apple
try-job: i686-mingw

jieyouxu · 2025-01-21T13:25:51Z

Based on triagebot... maybe r? @davidtwco

compiler-errors · 2025-01-21T17:31:03Z

@bors r+ rollup

bors · 2025-01-21T17:31:07Z

📌 Commit 139c5ae has been approved by compiler-errors

It is now in the queue for this repository.

…mpiler-errors tests: Port `translation` to rmake.rs Part of rust-lang#121876. This PR partially supersedes rust-lang#129011 and is co-authored with `@Oneirical.` ## Summary This PR ports `tests/run-make/translation` to rmake.rs. Notable changes from the Makefile version include: - We now actually fail if the rustc invocations fail... The Makefile did not have `SHELL=/bin/bash -o pipefail`, so all the piped rustc invocations to grep vacuously succeeded, even if the broken ftl test case actually regressed over time and ICEs on current master. - That test case is converted to assert it ICEs with a FIXME backlinking to rust-lang#135817. - The test coverage is expanded to not ignore windows. Instead, the test now uses symlink capability detection to gate test execution. - Added some backlinks to relevant tracking issues and the initial translation infra implementation PR. ## Review advice Best reviewed commit-by-commit. r? compiler

Rollup of 8 pull requests Successful merges: - rust-lang#135779 (CI: free disk on linux arm runner) - rust-lang#135794 (Detect missing fields with default values and suggest `..`) - rust-lang#135814 (ci: use ghcr buildkit image) - rust-lang#135818 (tests: Port `translation` to rmake.rs) - rust-lang#135823 (make UI tests that use `--test` work on panic=abort targets) - rust-lang#135837 (Remove test panic from File::open) - rust-lang#135852 (Add `AsyncFn*` to `core` prelude) - rust-lang#135856 (Library: Finalize dyn compatibility renaming) r? `@ghost` `@rustbot` modify labels: rollup

jieyouxu · 2025-01-22T07:48:40Z

Failed in #135861 (comment)
@bors r-

jieyouxu · 2025-01-22T08:12:33Z

Slightly documented assert_exit_code and changed assert -> assert_eq to have a better panic message, added //@ needs-process to the test because wasm32-wasip1 is a great target, but no functional changes otherwise.

@bors r=compiler-errors rollup=iffy

bors · 2025-01-22T08:12:35Z

📌 Commit e142d0c has been approved by compiler-errors

It is now in the queue for this repository.

src/tools/run-make-support/src/command.rs

…iler-errors tests: Port `translation` to rmake.rs Part of rust-lang#121876. This PR partially supersedes rust-lang#129011 and is co-authored with `@Oneirical.` ## Summary This PR ports `tests/run-make/translation` to rmake.rs. Notable changes from the Makefile version include: - We now actually fail if the rustc invocations fail... The Makefile did not have `SHELL=/bin/bash -o pipefail`, so all the piped rustc invocations to grep vacuously succeeded, even if the broken ftl test case actually regressed over time and ICEs on current master. - That test case is converted to assert it fails with a FIXME backlinking to rust-lang#135817. - The test coverage is expanded to not ignore windows. Instead, the test now uses symlink capability detection to gate test execution. - Added some backlinks to relevant tracking issues and the initial translation infra implementation PR. ## Review advice Best reviewed commit-by-commit. r? compiler try-job: aarch64-apple

bors · 2025-01-28T12:26:42Z

⌛ Testing commit 717b16e with merge f0c23fc...

bors · 2025-01-28T14:16:46Z

💔 Test failed - checks-actions

jieyouxu · 2025-01-29T08:06:34Z

@bors r-

Convenience helper for `rustc --print=sysroot`.

Co-authored-by: Oneirical <[email protected]>

jieyouxu · 2025-01-29T08:12:03Z

@bors try

bors · 2025-01-29T08:13:13Z

⌛ Trying commit 6f5a103 with merge a459f75...

tests: Port `translation` to rmake.rs Part of rust-lang#121876. This PR partially supersedes rust-lang#129011 and is co-authored with `@Oneirical.` ## Summary This PR ports `tests/run-make/translation` to rmake.rs. Notable changes from the Makefile version include: - We now actually fail if the rustc invocations fail... The Makefile did not have `SHELL=/bin/bash -o pipefail`, so all the piped rustc invocations to grep vacuously succeeded, even if the broken ftl test case actually regressed over time and ICEs on current master. - That test case is converted to assert it fails with a FIXME backlinking to rust-lang#135817. - The test coverage is expanded to not ignore windows. Instead, the test now uses symlink capability detection to gate test execution. - Added some backlinks to relevant tracking issues and the initial translation infra implementation PR. ## Review advice Best reviewed commit-by-commit. r? compiler try-job: aarch64-apple try-job: i686-mingw

bors · 2025-01-29T10:25:31Z

☀️ Try build successful - checks-actions
Build commit: a459f75 (a459f7545933b917f836764607766733d0060a9d)

jieyouxu · 2025-01-29T10:47:07Z

@bors r=compiler-errors

bors · 2025-01-29T10:47:10Z

📌 Commit 6f5a103 has been approved by compiler-errors

It is now in the queue for this repository.

bors · 2025-01-29T22:01:57Z

⌛ Testing commit 6f5a103 with merge 4a5f1cc...

bors · 2025-01-30T00:44:57Z

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing 4a5f1cc to master...

rust-timer · 2025-01-30T02:07:29Z

Finished benchmarking commit (4a5f1cc): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.3%	[0.3%, 0.3%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (primary -2.3%, secondary -2.8%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.3%	[-2.4%, -2.2%]	3
Improvements ✅ (secondary)	-2.8%	[-2.8%, -2.8%]	1
All ❌✅ (primary)	-2.3%	[-2.4%, -2.2%]	3

Cycles

Results (secondary 2.2%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.2%	[2.2%, 2.2%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 777.289s -> 775.772s (-0.20%)
Artifact size: 328.44 MiB -> 328.49 MiB (0.02%)

rustbot assigned petrochenkov Jan 21, 2025

jieyouxu added the A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic label Jan 21, 2025

This comment was marked as off-topic.

Sign in to view

rustbot assigned davidtwco and unassigned petrochenkov Jan 21, 2025

This was referenced Jan 21, 2025

Migrate libs-through-symlinks and translation run-make tests to rmake #129011

Closed

Tracking Issue for porting run-make tests to use Rust #121876

Closed

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 21, 2025

jieyouxu assigned compiler-errors and unassigned davidtwco Jan 22, 2025

jieyouxu mentioned this pull request Jan 22, 2025

Rollup of 8 pull requests #135861

Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 22, 2025

jieyouxu force-pushed the migrate-translation branch 2 times, most recently from 80be239 to e142d0c Compare January 22, 2025 08:11

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jan 28, 2025

bjorn3 reviewed Jan 28, 2025

View reviewed changes

src/tools/run-make-support/src/command.rs Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 28, 2025

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 29, 2025

jieyouxu and others added 3 commits January 29, 2025 08:10

run-make-support: add sysroot helper

dd616d6

Convenience helper for `rustc --print=sysroot`.

run-make-support: improve docs for assert_exit_code

5f513a6

tests: port translation to rmake.rs

6f5a103

Co-authored-by: Oneirical <[email protected]>

jieyouxu force-pushed the migrate-translation branch from 717b16e to 6f5a103 Compare January 29, 2025 08:11

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 29, 2025

bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 30, 2025

bors merged commit 4a5f1cc into rust-lang:master Jan 30, 2025
7 checks passed

rustbot added this to the 1.86.0 milestone Jan 30, 2025

jieyouxu deleted the migrate-translation branch January 30, 2025 03:16

tests: Port translation to rmake.rs #135818

tests: Port translation to rmake.rs #135818

Uh oh!

Conversation

jieyouxu commented Jan 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Review advice

Uh oh!

This comment was marked as off-topic.

This comment was marked as off-topic.

jieyouxu commented Jan 21, 2025

Uh oh!

compiler-errors commented Jan 21, 2025

Uh oh!

bors commented Jan 21, 2025

Uh oh!

jieyouxu commented Jan 22, 2025

Uh oh!

jieyouxu commented Jan 22, 2025

Uh oh!

bors commented Jan 22, 2025

Uh oh!

Uh oh!

bors commented Jan 28, 2025

Uh oh!

This comment has been minimized.

bors commented Jan 28, 2025

Uh oh!

jieyouxu commented Jan 29, 2025

Uh oh!

jieyouxu commented Jan 29, 2025

Uh oh!

bors commented Jan 29, 2025

Uh oh!

bors commented Jan 29, 2025

Uh oh!

jieyouxu commented Jan 29, 2025

Uh oh!

bors commented Jan 29, 2025

Uh oh!

bors commented Jan 29, 2025

Uh oh!

bors commented Jan 30, 2025

Uh oh!

Uh oh!

rust-timer commented Jan 30, 2025

Overall result: ❌ regressions - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Uh oh!

tests: Port `translation` to rmake.rs #135818

tests: Port `translation` to rmake.rs #135818

jieyouxu commented Jan 21, 2025 •

edited

Loading