Skip to content

Conversation

RalfJung
Copy link
Member

r? @ghost

RalfJung and others added 19 commits December 18, 2024 15:48
add more tests for SC access/fence consistency
Provide a way to compare benchmark results with baseline
Implement many-seeds mode directly in the driver
Error on some invalid flag combinations
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 26, 2024
@rustbot
Copy link
Collaborator

rustbot commented Dec 26, 2024

The Miri subtree was changed

cc @rust-lang/miri

@RalfJung
Copy link
Member Author

@bors r+

@bors
Copy link
Collaborator

bors commented Dec 26, 2024

📌 Commit 60e3bf4 has been approved by RalfJung

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 26, 2024
jieyouxu added a commit to jieyouxu/rust that referenced this pull request Dec 26, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 26, 2024
Rollup of 4 pull requests

Successful merges:

 - rust-lang#134664 (Account for removal of multiline span in suggestion)
 - rust-lang#134774 (fix default-backtrace-ice test)
 - rust-lang#134781 (Add more `begin_panic` normalizations to panic backtrace tests)
 - rust-lang#134784 (Miri subtree update)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors
Copy link
Collaborator

bors commented Dec 26, 2024

⌛ Testing commit 60e3bf4 with merge e2848a0...

@bors
Copy link
Collaborator

bors commented Dec 26, 2024

☀️ Test successful - checks-actions
Approved by: RalfJung
Pushing e2848a0 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 26, 2024
@bors bors merged commit e2848a0 into rust-lang:master Dec 26, 2024
7 checks passed
@rustbot rustbot added this to the 1.85.0 milestone Dec 26, 2024
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (e2848a0): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (secondary -2.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-2.1% [-2.1%, -2.1%] 1
All ❌✅ (primary) - - 0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 764.241s -> 765.315s (0.14%)
Artifact size: 330.53 MiB -> 330.50 MiB (-0.01%)

@RalfJung RalfJung deleted the miri-sync branch December 26, 2024 18:16
poliorcetics pushed a commit to poliorcetics/rust that referenced this pull request Dec 26, 2024
poliorcetics pushed a commit to poliorcetics/rust that referenced this pull request Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants