Skip to content

Conversation

liigo
Copy link
Contributor

@liigo liigo commented Dec 13, 2024

r? jhpratt
since you have reivewed #134193

If someone is looking to contribute, they will want the repository as a whole, not the lib.rs for std.

Now the repository url is reserved, I just add another concrete url as an example, to help people finding target page more quickly&easily.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Dec 13, 2024
@jhpratt
Copy link
Member

jhpratt commented Dec 13, 2024

Genuine question — what's the goal here? I don't find the existing link confusing at all.

@liigo
Copy link
Contributor Author

liigo commented Dec 13, 2024

to help people finding target page more quickly & easily. only the repo url is not enough, the std is deeply hidden in the repo's tree (from newbies view).

@jhpratt
Copy link
Member

jhpratt commented Dec 13, 2024

I find it's quite obvious, as it's in the top-level library directory followed by whatever crate you are working with. However, I've also been contributing for years. I don't personally feel inclined to have any change here, but I'll leave the final decision to someone else.

r? libs-api

@rustbot rustbot added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Dec 13, 2024
@rustbot rustbot assigned dtolnay and unassigned jhpratt Dec 13, 2024
//! The source for this documentation can be found on
//! [GitHub](https://github.com/rust-lang/rust).
//! [GitHub](https://github.com/rust-lang/rust)
//!(e.g. [here](https://github.com/rust-lang/rust/blob/master/library/std/src/lib.rs)).
Copy link
Member

@dtolnay dtolnay Dec 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The character at the beginning of this line is a Unicode "Fullwidth Exclamation Mark", which is not an ASCII exclamation mark. So this line would not be treated as documentation by rustdoc. It is just a comment.

https://www.compart.com/en/unicode/U+FF01

image

image

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 26, 2024
@dtolnay
Copy link
Member

dtolnay commented Dec 26, 2024

IMO the original wording and link are fine as is.

I would accept something like: The source for this documentation can be found on GitHub in the 'library/std/' directory.

@liigo
Copy link
Contributor Author

liigo commented Jan 2, 2025

r? dtolnay

@rustbot
Copy link
Collaborator

rustbot commented Jan 2, 2025

Could not assign reviewer from: dtolnay.
User(s) dtolnay are either the PR author, already assigned, or on vacation, and there are no other candidates.
Use r? to specify someone else to assign.

@liigo
Copy link
Contributor Author

liigo commented Jan 2, 2025

@dtolnay

I would accept something like: The source for this documentation can be found on GitHub in the 'library/std/' directory.

Done.

Copy link
Member

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dtolnay
Copy link
Member

dtolnay commented Jan 2, 2025

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jan 2, 2025

📌 Commit 862fc62 has been approved by dtolnay

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 2, 2025
@bors bors merged commit e11d5f8 into rust-lang:master Jan 3, 2025
6 checks passed
@rustbot rustbot added this to the 1.85.0 milestone Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.