rust_analyzer_settings: force use of 'nightly' toolchain #133712
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rustbot has assigned @Mark-Simulacrum. Use |
rustbot
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
RalfJung
force-pushed
the
rust_analyzer_settings
branch
from
7523152 to
fd13717
Compare
rustbot
added
the
T-bootstrap
jieyouxu
approved these changes
Dec 2, 2024
|
r? jieyouxu @bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 2, 2024
Rollup of 5 pull requests Successful merges: - rust-lang#131416 (Mark `slice::copy_from_slice` unstably const) - rust-lang#131784 (Stabilize unsigned and float variants of `num_midpoint` feature) - rust-lang#133446 (coverage: Use a query to identify which counter/expression IDs are used) - rust-lang#133711 (add isatty doc alias for `is_terminal`) - rust-lang#133712 (rust_analyzer_settings: force use of 'nightly' toolchain) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 2, 2024
Rollup merge of rust-lang#133712 - RalfJung:rust_analyzer_settings, r=jieyouxu rust_analyzer_settings: force use of 'nightly' toolchain The cranelift folder contains a rust-toolchain file. That means when RA opens `compiler/rustc_codegen_cranelift/Cargo.toml`, it will try to use that toolchain or fail. (Maybe that toolchain gets auto-installed for others? On my system, it just fails, but I also run vscodium in a sandbox.) However, it shouldn't be necessary to use more than one toolchain for the rustc workspace. So we can set the `RUSTUP_TOOLCHAIN` variable on the server side to force the same toolchain to be used everywhere. Suggested by `@ChayimFriedman2` in rust-lang/rust-analyzer#18585.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cranelift folder contains a rust-toolchain file. That means when RA opens
compiler/rustc_codegen_cranelift/Cargo.toml, it will try to use that toolchain or fail. (Maybe that toolchain gets auto-installed for others? On my system, it just fails, but I also run vscodium in a sandbox.)However, it shouldn't be necessary to use more than one toolchain for the rustc workspace. So we can set the
RUSTUP_TOOLCHAINvariable on the server side to force the same toolchain to be used everywhere.Suggested by @ChayimFriedman2 in rust-lang/rust-analyzer#18585.