Add suggestion for removing invalid path sep :: in fn def
#130870
Merged
+46
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Nadrieril rustbot has assigned @Nadrieril. Use |
rustbot
added
S-waiting-on-review
compiler-errors
requested changes
Sep 27, 2024
surechen
force-pushed
the
fix_130791
branch
from
55692e7 to
905898c
Compare
This comment has been minimized.
This comment has been minimized.
compiler-errors
requested changes
Sep 27, 2024
rustbot
added
S-waiting-on-author
surechen
force-pushed
the
fix_130791
branch
from
905898c to
67e682d
Compare
This comment has been minimized.
This comment has been minimized.
…efinition.
for example: `fn invalid_path_separator::<T>() {}`
fixes: rust-lang#130791
surechen
force-pushed
the
fix_130791
branch
from
67e682d to
d016595
Compare
rustbot
added
S-waiting-on-review
|
Hello, I think I have modified according to the comment. Could you review it again for me? Thank you. @compiler-errors |
compiler-errors
approved these changes
Oct 12, 2024
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Oct 12, 2024
…rors
Add suggestion for removing invalid path sep `::` in fn def
Add suggestion for removing invalid path separator `::` in function definition.
for example: `fn invalid_path_separator::<T>() {}`
fixes rust-lang#130791
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 12, 2024
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#130870 (Add suggestion for removing invalid path sep `::` in fn def) - rust-lang#131233 (std: fix stdout-before-main) - rust-lang#131239 (Don't assume traits used as type are trait objs in 2021 edition) - rust-lang#131277 (Handle `clippy` cases of `rustc::potential_query_instability` lint) - rust-lang#131567 (Emit an error for unstable attributes that reference already stable features) - rust-lang#131585 (compiletest: Remove the one thing that was checking a directive's `original_line`) - rust-lang#131590 (yeet some clones) - rust-lang#131597 (Take a display name for `tool_check_step!`) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 12, 2024
Rollup of 7 pull requests Successful merges: - rust-lang#130870 (Add suggestion for removing invalid path sep `::` in fn def) - rust-lang#130954 (Stabilize const `ptr::write*` and `mem::replace`) - rust-lang#131233 (std: fix stdout-before-main) - rust-lang#131590 (yeet some clones) - rust-lang#131596 (mark InterpResult as must_use) - rust-lang#131597 (Take a display name for `tool_check_step!`) - rust-lang#131605 (`LLVMConstInt` only allows integer types) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 12, 2024
Rollup merge of rust-lang#130870 - surechen:fix_130791, r=compiler-errors Add suggestion for removing invalid path sep `::` in fn def Add suggestion for removing invalid path separator `::` in function definition. for example: `fn invalid_path_separator::<T>() {}` fixes rust-lang#130791
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add suggestion for removing invalid path separator
::in function definition.for example:
fn invalid_path_separator::<T>() {}fixes #130791