Rollup of 7 pull requests #130755

workingjubilee · 2024-09-23T14:54:47Z

Successful merges:

std: implement the random feature (alternative version) #129201 (std: implement the random feature (alternative version))
bootstrap: Set the dylib path when building books with rustdoc #130536 (bootstrap: Set the dylib path when building books with rustdoc)
Fix break_last_token. #130551 (Fix break_last_token.)
Remove x86_64-fuchsia and aarch64-fuchsia target aliases #130657 (Remove x86_64-fuchsia and aarch64-fuchsia target aliases)
Add more test cases for block-no-opening-brace #130721 (Add more test cases for block-no-opening-brace)
Add rustfmt 2024 reformatting to git blame ignore #130736 (Add rustfmt 2024 reformatting to git blame ignore)
readd @tgross35 and @joboet to the review rotation #130746 (readd @tgross35 and @joboet to the review rotation)

r? @ghost
@rustbot modify labels: rollup

The library path is needed when the toolchain has been configured with `[rust] rpath = false`. Otherwise, building the reference book will get an error when it tries to run rustdoc, like: rustdoc: error while loading shared libraries: librustc_driver-2ec457c3b8826b72.so

It currently doesn't handle the three-char tokens `>>=` and `<<=` correctly. These can be broken twice, resulting in three individual tokens. This is a latent bug that currently doesn't cause any problems, but does cause problems for rust-lang#124141, because that PR increases the usage of lazy token streams.

Implements the ACP rust-lang/libs-team#393.

…shtriplett std: implement the `random` feature (alternative version) Implements the ACP rust-lang/libs-team#393. This PR is an alternative version of rust-lang#129120 that replaces `getentropy` with `CCRandomGenerateBytes` (on macOS) and `arc4random_buf` (other BSDs), since that function is not suited for generating large amounts of data and should only be used to seed other CPRNGs. `CCRandomGenerateBytes`/`arc4random_buf` on the other hand is (on modern platforms) just as secure and uses its own, very strong CPRNG (ChaCha20 on the BSDs, AES on macOS) periodically seeded with `getentropy`.

…k-Simulacrum bootstrap: Set the dylib path when building books with rustdoc The library path is needed when the toolchain has been configured with `[rust] rpath = false`. Otherwise, building the reference book will get an error when it tries to run rustdoc, like: rustdoc: error while loading shared libraries: librustc_driver-2ec457c3b8826b72.so

…r=petrochenkov Fix `break_last_token`. It currently doesn't handle the three-char tokens `>>=` and `<<=` correctly. These can be broken twice, resulting in three individual tokens. This is a latent bug that currently doesn't cause any problems, but does cause problems for rust-lang#124141, because that PR increases the usage of lazy token streams. r? `@petrochenkov`

Remove x86_64-fuchsia and aarch64-fuchsia target aliases Closes rust-lang#106649.

…e, r=jieyouxu Add more test cases for block-no-opening-brace Also add FIXME's for rust-lang#80931 & rust-lang#78168

…ompiler-errors Add rustfmt 2024 reformatting to git blame ignore rust-lang#130724 essentially reformatted the world, so we should add it to the git blame ignore list. Tested with `git blame compiler/rustc_abi/src/lib.rs -L1137,1146`. I first thought that I have to ignore the merge commit, but it seems like the actual commit that did the reformatting should be ignored instead. r? ``@compiler-errors``

@tgross35

readd @tgross35 and @joboet to the review rotation We're both (nearly) back from vacation. CC ``@tgross35``

workingjubilee · 2024-09-23T14:55:06Z

@bors r+ rollup=never p=7

bors · 2024-09-23T14:55:09Z

📌 Commit c7abc85 has been approved by workingjubilee

It is now in the queue for this repository.

bors · 2024-09-23T16:40:43Z

⌛ Testing commit c7abc85 with merge 9d6039c...

bors · 2024-09-23T19:26:26Z

☀️ Test successful - checks-actions
Approved by: workingjubilee
Pushing 9d6039c to master...

rust-timer · 2024-09-23T19:28:24Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#129201	std: implement the `random` feature (alternative version)	`bf50dde9a62ca9af7c1e4bb2e0662976efc2ac9b` (link)
#130536	bootstrap: Set the dylib path when building books with rust…	`fde04488de1007cbe4408d49c7afa676fda8fbf0` (link)
#130551	Fix `break_last_token`.	`9374a629900fbe089e1523e48b23347689013923` (link)
#130657	Remove x86_64-fuchsia and aarch64-fuchsia target aliases	`1d4d3fa90069dcb312e67ad20075c3bdac7bb327` (link)
#130721	Add more test cases for block-no-opening-brace	`df3c52dc7fde035363bbc7a8f41282ad94d83c37` (link)
#130736	Add rustfmt 2024 reformatting to git blame ignore	`a5d8677308e8379f565f7f2e7b502b6c798e771b` (link)
#130746	readd @tgross35 and @joboet to the review rotation	`31cc64c1ef4b310d1931513fbc83137b425f2880` (link)

previous master: 648d024a78

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2024-09-23T20:53:01Z

Finished benchmarking commit (9d6039c): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.5%	[0.2%, 1.3%]	4
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (primary 0.5%, secondary 0.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.3%	[0.4%, 2.3%]	2
Regressions ❌ (secondary)	2.9%	[1.0%, 5.9%]	11
Improvements ✅ (primary)	-1.1%	[-1.1%, -1.1%]	1
Improvements ✅ (secondary)	-3.0%	[-6.4%, -1.1%]	10
All ❌✅ (primary)	0.5%	[-1.1%, 2.3%]	3

Cycles

Results (secondary -7.2%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-7.2%	[-7.9%, -6.6%]	2
All ❌✅ (primary)	-	-	0

Binary size

Results (primary 0.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.1%	[0.0%, 0.2%]	10
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.1%	[0.0%, 0.2%]	10

Bootstrap: 767.841s -> 767.967s (0.02%)
Artifact size: 341.50 MiB -> 341.51 MiB (0.00%)

cuviper and others added 18 commits September 18, 2024 15:01

Remove x86_64-fuchsia and aarch64-fuchsia target aliases

019435b

Add more test cases for block-no-opening-brace

8d28099

Add rustfmt 2024 reformatting to git blame ignore

f7735f9

std: implement the random feature

5c1c725

Implements the ACP rust-lang/libs-team#393.

std: switch to faster random sources on macOS and most BSDs

b9d47cf

miri: shim CCRandomGenerateBytes

a21ff01

random: add tracking issue, address other comments

e94dd9b

update miri test

3ff09a0

readd @tgross35 and @joboet to the review rotation

b0c2c93

Rollup merge of rust-lang#130657 - arttet:fix/fuchsia, r=jieyouxu

021ae2c

Remove x86_64-fuchsia and aarch64-fuchsia target aliases Closes rust-lang#106649.

Rollup merge of rust-lang#130721 - GrigorenkoPV:block-no-opening-brac…

6feefdb

…e, r=jieyouxu Add more test cases for block-no-opening-brace Also add FIXME's for rust-lang#80931 & rust-lang#78168

Rollup merge of rust-lang#130746 - joboet:hello_again, r=joboet

c7abc85

readd @tgross35 and @joboet to the review rotation We're both (nearly) back from vacation. CC ``@tgross35``

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 23, 2024

bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 23, 2024

bors merged commit 9d6039c into rust-lang:master Sep 23, 2024
7 checks passed

rustbot added this to the 1.83.0 milestone Sep 23, 2024

This was referenced Sep 23, 2024

Initial fs implementation for UEFI #129700

Closed

Initial std library support for NuttX #130595

Merged

workingjubilee deleted the rollup-zpja9b3 branch September 24, 2024 23:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 7 pull requests #130755

Rollup of 7 pull requests #130755

Uh oh!

workingjubilee commented Sep 23, 2024

Uh oh!

workingjubilee commented Sep 23, 2024

Uh oh!

bors commented Sep 23, 2024

Uh oh!

bors commented Sep 23, 2024

Uh oh!

bors commented Sep 23, 2024

Uh oh!

Uh oh!

rust-timer commented Sep 23, 2024

Uh oh!

rust-timer commented Sep 23, 2024

Uh oh!

Uh oh!

Rollup of 7 pull requests #130755

Rollup of 7 pull requests #130755

Uh oh!

Conversation

workingjubilee commented Sep 23, 2024

Uh oh!

workingjubilee commented Sep 23, 2024

Uh oh!

bors commented Sep 23, 2024

Uh oh!

bors commented Sep 23, 2024

Uh oh!

bors commented Sep 23, 2024

Uh oh!

Uh oh!

rust-timer commented Sep 23, 2024

Uh oh!

rust-timer commented Sep 23, 2024

Overall result: ❌ regressions - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Uh oh!