Skip to content

Conversation

bvanjoi
Copy link
Contributor

@bvanjoi bvanjoi commented Jun 17, 2024

Fixes #126376
Fixes #126389

Add a branch to handle more cases...

r? @petrochenkov

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 17, 2024
@petrochenkov
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Jun 17, 2024

📌 Commit 2f17535 has been approved by petrochenkov

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 17, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 17, 2024
…iaskrgr

Rollup of 3 pull requests

Successful merges:

 - rust-lang#126568 (mark undetermined if target binding in current ns is not got)
 - rust-lang#126577 (const_refs_to_static test and cleanup)
 - rust-lang#126584 (Do not ICE in privacy when type inference fails.)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit ba26af3 into rust-lang:master Jun 17, 2024
@rustbot rustbot added this to the 1.81.0 milestone Jun 17, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jun 17, 2024
Rollup merge of rust-lang#126568 - bvanjoi:fix-126376, r=petrochenkov

mark undetermined if target binding in current ns is not got

Fixes rust-lang#126376
Fixes rust-lang#126389

Add a branch to handle more cases...

r? `@petrochenkov`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ICE: inconsistent resolution for an import ICE: import.imported_module.get().is_none()
4 participants