Rewrite fpic, simple-dylib and issue-37893 run-make tests in rmake.rs or ui test format
#125662
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-testsuite
|
Some changes occurred in run-make tests. cc @jieyouxu |
Oneirical
force-pushed
the
more-tests-again
branch
from
79dc40b to
4ccefec
Compare
jieyouxu
reviewed
May 28, 2024
Comment on lines
+1
to
+4
| // a.rs is a procedural macro crate, on which b.rs and c.rs depend. A now | ||
| // patched bug caused a compilation failure if the proc-macro crate was | ||
| // initialized with its dependents in this exact order. This test checks | ||
| // that compilation succeeds even when initialization is done in this order. |
There was a problem hiding this comment.
Observation: that sure is some fun combination to diagnose and fix...
| @@ -0,0 +1,4 @@ | |||
| //@ compile-flags --crate-type=dylib -Cprefer-dynamic | |||
There was a problem hiding this comment.
Question: I think this needs to be
//@ compile-flags: --crate-type=dylib -Cprefer-dynamic
but then again I don't recall exactly what compiletest directive parsing accepts. The --crate-type=dylib is redundant though because of the in-source crate_type attribute.
tests/ui/errors/pic-linker.rs
Outdated
| //@ ignore-macos | ||
| //@ ignore-cross-compile | ||
|
|
||
| //@ compile-flags -Clink-args=-Wl,-z,text |
There was a problem hiding this comment.
Question: I think this might need to be //@ compile-flags:
|
The |
|
@bors author |
jieyouxu
added
S-waiting-on-author
|
☔ The latest upstream changes (presumably #125691) made this pull request unmergeable. Please resolve the merge conflicts. |
Oneirical
force-pushed
the
more-tests-again
branch
from
4ccefec to
640126c
Compare
Oneirical
force-pushed
the
more-tests-again
branch
from
640126c to
8c8d0db
Compare
|
Revisions applied. |
rustbot
added
S-waiting-on-review
|
Thanks! |
bors
added
S-waiting-on-bors
fmease
added a commit
to fmease/rust
that referenced
this pull request
May 29, 2024
…ouxu Rewrite `fpic`, `simple-dylib` and `issue-37893` `run-make` tests in `rmake.rs` or ui test format Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html).
This was referenced May 29, 2024
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 30, 2024
Rollup of 7 pull requests Successful merges: - rust-lang#125653 (Migrate `run-make/const-prop-lint` to `rmake.rs`) - rust-lang#125662 (Rewrite `fpic`, `simple-dylib` and `issue-37893` `run-make` tests in `rmake.rs` or ui test format) - rust-lang#125699 (Streamline `x fmt` and improve its output) - rust-lang#125701 ([ACP 362] genericize `ptr::from_raw_parts`) - rust-lang#125723 (Migrate `run-make/crate-data-smoke` to `rmake.rs`) - rust-lang#125733 (Add lang items for `AsyncFn*`, `Future`, `AsyncFnKindHelper`'s associated types) - rust-lang#125734 (ast: Revert a breaking attribute visiting order change) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 30, 2024
Rollup merge of rust-lang#125662 - Oneirical:more-tests-again, r=jieyouxu Rewrite `fpic`, `simple-dylib` and `issue-37893` `run-make` tests in `rmake.rs` or ui test format Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #121876 and the associated Google Summer of Code project.