Record impl args in the proof tree in new solver #124759
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
Some changes occurred to the core trait solver cc @rust-lang/initiative-trait-system-refactor |
|
@bors r=lcnr |
bors
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
|
@bors r=lcnr |
|
@bors rollup |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
May 6, 2024
Record impl args in the proof tree in new solver Rather than rematching them during select. Also use `ImplSource::Param` instead of `ImplSource::Builtin` for alias-bound candidates, so we don't ICE in `Instance::resolve`. r? lcnr
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 6, 2024
…iaskrgr Rollup of 4 pull requests Successful merges: - rust-lang#124209 (Make check-cfg docs more user-friendly) - rust-lang#124759 (Record impl args in the proof tree in new solver) - rust-lang#124809 (borrowck: prepopulate opaque storage more eagerly) - rust-lang#124815 (Update books) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 6, 2024
…iaskrgr Rollup of 3 pull requests Successful merges: - rust-lang#124759 (Record impl args in the proof tree in new solver) - rust-lang#124809 (borrowck: prepopulate opaque storage more eagerly) - rust-lang#124815 (Update books) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 6, 2024
Rollup merge of rust-lang#124759 - compiler-errors:impl-args, r=lcnr Record impl args in the proof tree in new solver Rather than rematching them during select. Also use `ImplSource::Param` instead of `ImplSource::Builtin` for alias-bound candidates, so we don't ICE in `Instance::resolve`. r? lcnr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than rematching them during select.
Also use
ImplSource::Paraminstead ofImplSource::Builtinfor alias-bound candidates, so we don't ICE inInstance::resolve.r? lcnr