Add -lmingwex second time in mingw_libs
#124233
Conversation
Upcoming mingw-w64 releases will contain small math functions refactor which moved implementation around. As a result functions like `lgamma` now depend on libraries in this order: `libmingwex.a` -> `libmsvcrt.a` -> `libmingwex.a`. Fixes rust-lang#124221
|
r? @nnethercote rustbot has assigned @nnethercote. Use |
rustbot
added
S-waiting-on-review
|
These commits modify compiler targets. |
|
Would it be possible to use |
|
In the long run that would be better solution but it was discussed 2 or 3 years ago but nothing has happened since then. |
|
Right but this code looks like it is just setting linker arguments directly, no? So couldn't it just add the group manually for these libs? |
|
Yes, it should work, but I don't know if it's okay to do it. Previous talks were about a more generic solution. |
|
I'd say set it and see what happens^^. More generic solutions would always be good but no reason to block using it here over them (unless there is a very good reason). cc @petrochenkov |
|
I will defer to @petrochenkov here. |
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
Rollup of 5 pull requests Successful merges: - rust-lang#124233 (Add `-lmingwex` second time in `mingw_libs`) - rust-lang#124318 (ignore generics args in attribute paths) - rust-lang#124899 (bootstrap: add comments for the automatic dry run) - rust-lang#124904 (reachable computation: extend explanation of what this does, and why) - rust-lang#124930 (Make sure we consume a generic arg when checking mistyped turbofish) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of rust-lang#124233 - mati865:fix-support-for-upcoming-mingw-w64, r=petrochenkov Add `-lmingwex` second time in `mingw_libs` Upcoming mingw-w64 releases will contain small math functions refactor which moved implementation around. As a result functions like `lgamma` now depend on libraries in this order: `libmingwex.a` -> `libmsvcrt.a` -> `libmingwex.a`. Fixes rust-lang#124221
Upcoming mingw-w64 releases will contain small math functions refactor which moved implementation around. As a result functions like
lgammanow depend on libraries in this order:
libmingwex.a->libmsvcrt.a->libmingwex.a.Fixes #124221