rustdoc: Add syntax highlighting #12416
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview: http://www.contrib.andrew.cmu.edu/~acrichto/doc/std/index.html I just picked the color scheme out of my terminal, no attachment to it! |
| loop { | ||
| let next = lexer.next_token(); | ||
| let test = if next.tok == t::EOF {lexer.pos.get()} else {next.sp.lo}; | ||
| if test > last { |
There was a problem hiding this comment.
This is testing if there's a gap between two tokens, and then checking if that gap contains a comment, right?
|
Pushed with comments addressed. |
| @@ -1231,7 +1232,7 @@ fn render_method(w: &mut Writer, meth: &clean::Item) -> fmt::Result { | |||
|
|
|||
| fn item_struct(w: &mut Writer, it: &clean::Item, | |||
| s: &clean::Struct) -> fmt::Result { | |||
| try!(write!(w, "<pre class='struct'>")); | |||
| try!(write!(w, "<pre class='rtry struct'>")); | |||
|
r=me with comments addressed. |
|
This is awesome. The colors suck, but that's an easy fix for later. |
I like my terminal's colors :( That's also why I'd never get hired as a designer! |
This adds simple syntax highlighting based off libsyntax's lexer to be sure to stay up to date with rust's grammar. Some of the highlighting is a bit ad-hoc, but it definitely seems to get the job done! This currently doesn't highlight rustdoc-rendered function signatures and structs that are emitted to each page because the colors already signify what's clickable and I think we'd have to figure out a different scheme before colorizing them. This does, however, colorize all code examples and source code. Closes rust-lang#11393
bors
added a commit
that referenced
this pull request
Feb 23, 2014
This adds simple syntax highlighting based off libsyntax's lexer to be sure to stay up to date with rust's grammar. Some of the highlighting is a bit ad-hoc, but it definitely seems to get the job done! This currently doesn't highlight rustdoc-rendered function signatures and structs that are emitted to each page because the colors already signify what's clickable and I think we'd have to figure out a different scheme before colorizing them. This does, however, colorize all code examples and source code. Closes #11393
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 25, 2022
Add implicit static lifetime hints
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Mar 7, 2024
Add missing header for `manual_is_variant_and` Noticed this while generating our lint completions failed in rust-analyzer (separate PR from rust-lang/rust-clippy#12415 as I made these via the github interface quickly) changelog: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds simple syntax highlighting based off libsyntax's lexer to be sure to
stay up to date with rust's grammar. Some of the highlighting is a bit ad-hoc,
but it definitely seems to get the job done!
This currently doesn't highlight rustdoc-rendered function signatures and
structs that are emitted to each page because the colors already signify what's
clickable and I think we'd have to figure out a different scheme before
colorizing them. This does, however, colorize all code examples and source code.
Closes #11393