Skip to content

Conversation

jhpratt
Copy link
Member

@jhpratt jhpratt commented Apr 13, 2024

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

eduardosm and others added 8 commits April 12, 2024 21:23
Mailmap only allows one remapping per line, so @pietroalbini wasn't
getting grouped correctly. Fix this.
Avoid more NonNull-raw-NonNull roundtrips in Vec

r? the8472

The standard library in general has a lot of these round-trips from niched types to their raw innards and back. Such round-trips have overhead in debug builds since rust-lang#120594. I removed some such round-trips in that initial PR and I've been meaning to come back and hunt down more such examples (this is the last item on rust-lang#120848).
… r=jhpratt

Stabilize (const_)slice_ptr_len and (const_)slice_ptr_is_empty_nonnull

Stabilized API:

```rust
impl<T> *mut [T] {
    pub const fn len(self) -> usize;
    pub const fn is_empty(self) -> bool;
}

impl<T> *const [T] {
    pub const fn len(self) -> usize;
    pub const fn is_empty(self) -> bool;
}

impl<T> NonNull<[T]> {
    pub const fn is_empty(self) -> bool;
}
```

FCP completed in tracking issue: rust-lang#71146
Fix Pietro's entry in the mailmap

Mailmap only allows one remapping per line, so `@pietroalbini` wasn't getting grouped correctly. Fix this.
Merge cuviper in the mailmap

These emails are associated with my GitHub account already, but I might as well
combine my activity for stuff like the Thanks page too.
@rustbot rustbot added A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Apr 13, 2024
@jhpratt
Copy link
Member Author

jhpratt commented Apr 13, 2024

@bors r+ rollup=never p=4

@bors
Copy link
Collaborator

bors commented Apr 13, 2024

📌 Commit 1a75ce0 has been approved by jhpratt

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 13, 2024
@jhpratt
Copy link
Member Author

jhpratt commented Apr 13, 2024

@bors p=4

@bors
Copy link
Collaborator

bors commented Apr 13, 2024

⌛ Testing commit 1a75ce0 with merge 59c38c0...

@bors
Copy link
Collaborator

bors commented Apr 13, 2024

☀️ Test successful - checks-actions
Approved by: jhpratt
Pushing 59c38c0 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 13, 2024
@bors bors merged commit 59c38c0 into rust-lang:master Apr 13, 2024
@rustbot rustbot added this to the 1.79.0 milestone Apr 13, 2024
@rust-timer
Copy link
Collaborator

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#123835 Avoid more NonNull-raw-NonNull roundtrips in Vec 044b57f72fb19acbe2d5292efc06fca359296420 (link)
#123868 Stabilize (const_)slice_ptr_len and (const_)slice_ptr_is_em… bb3491276fec804c91435d0df9e605f3299830c6 (link)
#123872 Fix Pietro's entry in the mailmap 0aff766a8bce17d697ad71cd5a2451080de4e71d (link)
#123873 Merge cuviper in the mailmap 1c81f63690eabd3d6f5de7a6f922b3be710818e5 (link)

previous master: 6cfd80942e

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (59c38c0): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
0.4% [0.4%, 0.4%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-1.0% [-1.0%, -1.0%] 1
Improvements ✅
(secondary)
-0.3% [-0.3%, -0.3%] 6
All ❌✅ (primary) -0.3% [-1.0%, 0.4%] 2

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
0.1% [0.1%, 0.1%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-2.4% [-2.4%, -2.4%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -1.2% [-2.4%, 0.1%] 2

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-1.2% [-1.2%, -1.2%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -1.2% [-1.2%, -1.2%] 1

Binary size

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
0.0% [0.0%, 0.1%] 10
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-0.1% [-0.7%, -0.0%] 15
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -0.0% [-0.7%, 0.1%] 25

Bootstrap: 674.576s -> 675.861s (0.19%)
Artifact size: 316.03 MiB -> 316.04 MiB (0.00%)

@rustbot rustbot added the perf-regression Performance regression. label Apr 13, 2024
@Kobzol
Copy link
Member

Kobzol commented Apr 16, 2024

The single regression was immediately reverted, the rest were small improvements.

@rustbot label: +perf-regression-triaged

@rustbot rustbot added the perf-regression-triaged The performance regression has been triaged. label Apr 16, 2024
@jhpratt jhpratt deleted the rollup-1kwk0jz branch April 16, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-meta Area: Issues & PRs about the rust-lang/rust repository itself merged-by-bors This PR was explicitly merged by bors. perf-regression Performance regression. perf-regression-triaged The performance regression has been triaged. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants